Blame SOURCES/gdb-rhbz1149205-catch-syscall-after-fork-test.patch

b94e32
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
b94e32
From: Fedora GDB patches <invalid@email.com>
b94e32
Date: Fri, 27 Oct 2017 21:07:50 +0200
b94e32
Subject: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
b94e32
b94e32
;; Fix '`catch syscall' doesn't work for parent after `fork' is called'
b94e32
;; (Philippe Waroquiers, RH BZ 1149205).
b94e32
;;=fedoratest
b94e32
b94e32
URL: <https://sourceware.org/ml/gdb-patches/2013-05/msg00364.html>
b94e32
Message-ID: <1368136582.30058.7.camel@soleil>
b94e32
b94e32
  From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
b94e32
  To: gdb-patches at sourceware dot org
b94e32
  Subject: RFA: fix gdb_assert caused by 'catch signal ...' and fork
b94e32
  Date: Thu, 09 May 2013 23:56:22 +0200
b94e32
b94e32
  The attached patch fixes a gdb_assert caused by the combination of catch
b94e32
  signal and fork:
b94e32
    break-catch-sig.c:152: internal-error: signal_catchpoint_remove_location: Assertion `signal_catch_counts[iter] > 0' failed.
b94e32
b94e32
  The problem is that the signal_catch_counts is decremented by detach_breakpoints.
b94e32
  The fix consists in not detaching breakpoint locations of type bp_loc_other.
b94e32
  The patch introduces a new test.
b94e32
b94e32
Comments by Sergio Durigan Junior:
b94e32
b94e32
  I addded a specific testcase for this patch, which tests exactly the
b94e32
  issue that the customer is facing.  This patch does not solve the
b94e32
  whole problem of catching a syscall and forking (for more details,
b94e32
  see <https://sourceware.org/bugzilla/show_bug.cgi?id=13457>,
b94e32
  specifically comment #3), but it solves the issue reported by the
b94e32
  customer.
b94e32
b94e32
  I also removed the original testcase of this patch, because it
b94e32
  relied on "catch signal", which is a command that is not implemented
b94e32
  in this version of GDB.
b94e32
b94e32
commit bd9673a4ded96ea5c108601501c8e59003ea1be6
b94e32
Author: Philippe Waroquiers <philippe@sourceware.org>
b94e32
Date:   Tue May 21 18:47:05 2013 +0000
b94e32
b94e32
    Fix internal error caused by interaction between catch signal and fork
b94e32
b94e32
diff --git a/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c
b94e32
new file mode 100644
b94e32
--- /dev/null
b94e32
+++ b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c
b94e32
@@ -0,0 +1,11 @@
b94e32
+#include <stdio.h>
b94e32
+#include <unistd.h>
b94e32
+
b94e32
+int
b94e32
+main (int argc, char **argv)
b94e32
+{
b94e32
+  if (fork () == 0)
b94e32
+    sleep (1);
b94e32
+  chdir (".");
b94e32
+  return 0;
b94e32
+}
b94e32
diff --git a/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp
b94e32
new file mode 100644
b94e32
--- /dev/null
b94e32
+++ b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp
b94e32
@@ -0,0 +1,58 @@
b94e32
+# Copyright 2015 Free Software Foundation, Inc.
b94e32
+
b94e32
+# This program is free software; you can redistribute it and/or modify
b94e32
+# it under the terms of the GNU General Public License as published by
b94e32
+# the Free Software Foundation; either version 3 of the License, or
b94e32
+# (at your option) any later version.
b94e32
+#
b94e32
+# This program is distributed in the hope that it will be useful,
b94e32
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
b94e32
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
b94e32
+# GNU General Public License for more details.
b94e32
+#
b94e32
+# You should have received a copy of the GNU General Public License
b94e32
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
b94e32
+
b94e32
+if { [is_remote target] || ![isnative] } then {
b94e32
+    continue
b94e32
+}
b94e32
+
b94e32
+set testfile "gdb-rhbz1149205-catch-syscall-fork"
b94e32
+set srcfile ${testfile}.c
b94e32
+set binfile [standard_output_file ${testfile}]
b94e32
+
b94e32
+# Until "catch syscall" is implemented on other targets...
b94e32
+if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then {
b94e32
+    continue
b94e32
+}
b94e32
+
b94e32
+# This shall be updated whenever 'catch syscall' is implemented
b94e32
+# on some architecture.
b94e32
+#if { ![istarget "i\[34567\]86-*-linux*"]
b94e32
+if { ![istarget "x86_64-*-linux*"] && ![istarget "i\[34567\]86-*-linux*"]
b94e32
+     && ![istarget "powerpc-*-linux*"] && ![istarget "powerpc64-*-linux*"]
b94e32
+     && ![istarget "sparc-*-linux*"] && ![istarget "sparc64-*-linux*"] } {
b94e32
+     continue
b94e32
+}
b94e32
+
b94e32
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
b94e32
+    untested ${testfile}.exp
b94e32
+    return -1
b94e32
+}
b94e32
+
b94e32
+gdb_exit
b94e32
+gdb_start
b94e32
+gdb_reinitialize_dir $srcdir/$subdir
b94e32
+gdb_load $binfile
b94e32
+
b94e32
+if { ![runto_main] } {
b94e32
+    return -1
b94e32
+}
b94e32
+
b94e32
+gdb_test "catch syscall chdir" \
b94e32
+  "Catchpoint $decimal \\\(syscall (.)?chdir(.)? \\\[$decimal\\\]\\\)" \
b94e32
+  "catch syscall chdir"
b94e32
+
b94e32
+gdb_test "continue" \
b94e32
+  "Continuing\.\r\n.*\r\nCatchpoint $decimal \\\(call to syscall .?chdir.?.*" \
b94e32
+  "continue from catch syscall after fork"