|
 |
f8cceb |
diff -rup binutils.orig/gas/symbols.c binutils-2.38/gas/symbols.c
|
|
|
f8cceb |
--- binutils.orig/gas/symbols.c 2022-03-09 11:43:34.706610216 +0000
|
|
|
f8cceb |
+++ binutils-2.38/gas/symbols.c 2022-03-09 11:45:57.540686508 +0000
|
|
|
f8cceb |
@@ -61,8 +61,10 @@ struct symbol_flags
|
|
|
f8cceb |
/* Whether the symbol can be re-defined. */
|
|
|
f8cceb |
unsigned int volatil : 1;
|
|
|
f8cceb |
|
|
|
f8cceb |
- /* Whether the symbol is a forward reference. */
|
|
|
f8cceb |
+ /* Whether the symbol is a forward reference, and whether such has
|
|
|
f8cceb |
+ been determined. */
|
|
|
f8cceb |
unsigned int forward_ref : 1;
|
|
|
f8cceb |
+ unsigned int forward_resolved : 1;
|
|
|
f8cceb |
|
|
|
f8cceb |
/* This is set if the symbol is defined in an MRI common section.
|
|
|
f8cceb |
We handle such sections as single common symbols, so symbols
|
|
|
f8cceb |
@@ -202,7 +204,7 @@ static void *
|
|
|
f8cceb |
symbol_entry_find (htab_t table, const char *name)
|
|
|
f8cceb |
{
|
|
|
f8cceb |
hashval_t hash = htab_hash_string (name);
|
|
|
f8cceb |
- symbol_entry_t needle = { { { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 },
|
|
|
f8cceb |
+ symbol_entry_t needle = { { { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 },
|
|
|
f8cceb |
hash, name, 0, 0, 0 } };
|
|
|
f8cceb |
return htab_find_with_hash (table, &needle, hash);
|
|
|
f8cceb |
}
|
|
|
f8cceb |
@@ -784,7 +786,9 @@ symbol_clone (symbolS *orgsymP, int repl
|
|
|
f8cceb |
symbolS *
|
|
|
f8cceb |
symbol_clone_if_forward_ref (symbolS *symbolP, int is_forward)
|
|
|
f8cceb |
{
|
|
|
f8cceb |
- if (symbolP && !symbolP->flags.local_symbol)
|
|
|
f8cceb |
+ if (symbolP
|
|
|
f8cceb |
+ && !symbolP->flags.local_symbol
|
|
|
f8cceb |
+ && !symbolP->flags.forward_resolved)
|
|
|
f8cceb |
{
|
|
|
f8cceb |
symbolS *orig_add_symbol = symbolP->x->value.X_add_symbol;
|
|
|
f8cceb |
symbolS *orig_op_symbol = symbolP->x->value.X_op_symbol;
|
|
|
f8cceb |
@@ -837,6 +841,7 @@ symbol_clone_if_forward_ref (symbolS *sy
|
|
|
f8cceb |
|
|
|
f8cceb |
symbolP->x->value.X_add_symbol = add_symbol;
|
|
|
f8cceb |
symbolP->x->value.X_op_symbol = op_symbol;
|
|
|
f8cceb |
+ symbolP->flags.forward_resolved = 1;
|
|
|
f8cceb |
}
|
|
|
f8cceb |
|
|
|
f8cceb |
return symbolP;
|
|
|
f8cceb |
diff -rup binutils.orig/gas/testsuite/gas/elf/dwarf2-18.d binutils-2.38/gas/testsuite/gas/elf/dwarf2-18.d
|
|
|
f8cceb |
--- binutils.orig/gas/testsuite/gas/elf/dwarf2-18.d 2022-03-09 11:43:34.487611632 +0000
|
|
|
f8cceb |
+++ binutils-2.38/gas/testsuite/gas/elf/dwarf2-18.d 2022-03-09 11:48:03.298873228 +0000
|
|
|
f8cceb |
@@ -2,9 +2,8 @@
|
|
|
f8cceb |
#readelf: -x.rodata -wL
|
|
|
f8cceb |
#name: DWARF2 18
|
|
|
f8cceb |
# The am33 cr16 crx ft32 mn10 msp430 nds32 and rl78 targets do not evaluate the subtraction of symbols at assembly time.
|
|
|
f8cceb |
-# The mep targets turns some view computations into complex relocations.
|
|
|
f8cceb |
# The riscv targets do not support the subtraction of symbols.
|
|
|
f8cceb |
-#xfail: am3*-* cr16-* crx-* ft32*-* mep-* mn10*-* msp430-* nds32*-* riscv*-* rl78-*
|
|
|
f8cceb |
+#xfail: am3*-* cr16-* crx-* ft32*-* mn10*-* msp430-* nds32*-* riscv*-* rl78-*
|
|
|
f8cceb |
|
|
|
f8cceb |
Hex dump of section '\.rodata':
|
|
|
f8cceb |
0x00000000 0100 *.*
|
|
|
f8cceb |
--- binutils.orig/gas/dwarf2dbg.c 2022-03-10 09:13:18.516639363 +0000
|
|
|
f8cceb |
+++ binutils-2.38/gas/dwarf2dbg.c 2022-03-10 12:45:25.191933733 +0000
|
|
|
f8cceb |
@@ -402,18 +402,27 @@ set_or_check_view (struct line_entry *e,
|
|
|
f8cceb |
if (viewx.X_op != O_constant || viewx.X_add_number)
|
|
|
f8cceb |
{
|
|
|
f8cceb |
expressionS incv;
|
|
|
f8cceb |
+ expressionS *p_view;
|
|
|
f8cceb |
|
|
|
f8cceb |
if (!p->loc.u.view)
|
|
|
f8cceb |
- {
|
|
|
f8cceb |
- p->loc.u.view = symbol_temp_make ();
|
|
|
f8cceb |
- gas_assert (!S_IS_DEFINED (p->loc.u.view));
|
|
|
f8cceb |
- }
|
|
|
f8cceb |
+ p->loc.u.view = symbol_temp_make ();
|
|
|
f8cceb |
|
|
|
f8cceb |
memset (&incv, 0, sizeof (incv));
|
|
|
f8cceb |
incv.X_unsigned = 1;
|
|
|
f8cceb |
incv.X_op = O_symbol;
|
|
|
f8cceb |
incv.X_add_symbol = p->loc.u.view;
|
|
|
f8cceb |
incv.X_add_number = 1;
|
|
|
f8cceb |
+ p_view = symbol_get_value_expression (p->loc.u.view);
|
|
|
f8cceb |
+ if (p_view->X_op == O_constant || p_view->X_op == O_symbol)
|
|
|
f8cceb |
+ {
|
|
|
f8cceb |
+ /* If we can, constant fold increments so that a chain of
|
|
|
f8cceb |
+ expressions v + 1 + 1 ... + 1 is not created.
|
|
|
f8cceb |
+ resolve_expression isn't ideal for this purpose. The
|
|
|
f8cceb |
+ base v might not be resolvable until later. */
|
|
|
f8cceb |
+ incv.X_op = p_view->X_op;
|
|
|
f8cceb |
+ incv.X_add_symbol = p_view->X_add_symbol;
|
|
|
f8cceb |
+ incv.X_add_number = p_view->X_add_number + 1;
|
|
|
f8cceb |
+ }
|
|
|
f8cceb |
|
|
|
f8cceb |
if (viewx.X_op == O_constant)
|
|
|
f8cceb |
{
|