Blame SOURCES/gdb-test-bt-cfi-without-die.patch

4416f5
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
4416f5
From: Fedora GDB patches <invalid@email.com>
4416f5
Date: Fri, 27 Oct 2017 21:07:50 +0200
4416f5
Subject: gdb-test-bt-cfi-without-die.patch
4416f5
4416f5
;; [delayed-symfile] Test a backtrace regression on CFIs without DIE (BZ 614604).
4416f5
;;=fedoratest
4416f5
4416f5
http://sourceware.org/ml/archer/2010-q3/msg00028.html
4416f5
4416f5
On Wed, 25 Feb 2009 00:14:29 +0100, Jan Kratochvil wrote:
4416f5
> commit 6a37c2b9962258ecf9299cc34a650e64a06acaa5
4416f5
>
4416f5
> There was a regression on gdb.base/savedregs.exp.
4416f5
>
4416f5
> quick_addrmap/require_partial_symbols should be used even for the unwind debug
4416f5
> info checking as its load has been also delayed by this branch.
4416f5
[...]
4416f5
> --- a/gdb/dwarf2-frame.c
4416f5
> +++ b/gdb/dwarf2-frame.c
4416f5
[...]
4416f5
> @@ -1499,6 +1500,14 @@ dwarf2_frame_find_fde (CORE_ADDR *pc)
4416f5
>        struct dwarf2_fde *fde;
4416f5
>        CORE_ADDR offset;
4416f5
>
4416f5
> +      if (objfile->quick_addrmap)
4416f5
> +	{
4416f5
> +	  if (!addrmap_find (objfile->quick_addrmap, *pc))
4416f5
> +	    continue;
4416f5
> +	}
4416f5
> +      /* FIXME: Read-in only .debug_frame/.eh_frame without .debug_info?  */
4416f5
> +      require_partial_symbols (objfile);
4416f5
> +
4416f5
4416f5
but this has caused a different regression (as discussed in the confcall).
4416f5
4416f5
QUICK_ADDRMAP is built only from .debug_aranges.  But we can have existing
4416f5
built .debug_aranges for CUs in OBJFILE but still some CUs do not need to have
4416f5
DWARF at all while they can feature CFIs (.eh_frame or .debug_frame).
4416f5
It has been described by Daniel Jacobowitz at:
4416f5
	Re: [2/4] RFC: check psymtabs_addrmap before reading FDEs
4416f5
	http://sourceware.org/ml/gdb-patches/2010-07/msg00012.html
4416f5
4416f5
Sorry for this regression by me (in that fix of a different regression).
4416f5
4416f5
Fixed it the "slow way" as this branch is now obsoleted by .gdb-index.
4416f5
4416f5
No regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu.
4416f5
4416f5
Checked-in.
4416f5
4416f5
Thanks,
4416f5
Jan
4416f5
4416f5
eb8df8566acc1ed963e3e9b77c13b9c2c3db03fb
4416f5
4416f5
Test CFI is parsed even for range (function) not described by any DIE.
4416f5
4416f5
https://bugzilla.redhat.com/show_bug.cgi?id=614028
4416f5
4416f5
gdb/
4416f5
	* dwarf2-frame.c (dwarf2_frame_find_fde): Remove the
4416f5
	OBJFILE->QUICK_ADDRMAP check.  New comment why.
4416f5
4416f5
gdb/testsuite/
4416f5
	* gdb.base/cfi-without-die.exp, gdb.base/cfi-without-die-main.c,
4416f5
	gdb.base/cfi-without-die-caller.c: New files.
4416f5
4416f5
diff --git a/gdb/testsuite/gdb.base/cfi-without-die-caller.c b/gdb/testsuite/gdb.base/cfi-without-die-caller.c
4416f5
new file mode 100644
4416f5
--- /dev/null
4416f5
+++ b/gdb/testsuite/gdb.base/cfi-without-die-caller.c
4416f5
@@ -0,0 +1,28 @@
4416f5
+/* This testcase is part of GDB, the GNU debugger.
4416f5
+
4416f5
+   Copyright 2005, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
4416f5
+
4416f5
+   This program is free software; you can redistribute it and/or modify
4416f5
+   it under the terms of the GNU General Public License as published by
4416f5
+   the Free Software Foundation; either version 3 of the License, or
4416f5
+   (at your option) any later version.
4416f5
+
4416f5
+   This program is distributed in the hope that it will be useful,
4416f5
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
4416f5
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
4416f5
+   GNU General Public License for more details.
4416f5
+
4416f5
+   You should have received a copy of the GNU General Public License
4416f5
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
4416f5
+
4416f5
+typedef int (*callback_t) (void);
4416f5
+
4416f5
+int
4416f5
+caller (callback_t callback)
4416f5
+{
4416f5
+  /* Ensure some frame content to push away the return address.  */
4416f5
+  volatile const long one = 1;
4416f5
+
4416f5
+  /* Modify the return value to prevent any tail-call optimization.  */
4416f5
+  return (*callback) () - one;
4416f5
+}
4416f5
diff --git a/gdb/testsuite/gdb.base/cfi-without-die-main.c b/gdb/testsuite/gdb.base/cfi-without-die-main.c
4416f5
new file mode 100644
4416f5
--- /dev/null
4416f5
+++ b/gdb/testsuite/gdb.base/cfi-without-die-main.c
4416f5
@@ -0,0 +1,32 @@
4416f5
+/* This testcase is part of GDB, the GNU debugger.
4416f5
+
4416f5
+   Copyright 2005, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
4416f5
+
4416f5
+   This program is free software; you can redistribute it and/or modify
4416f5
+   it under the terms of the GNU General Public License as published by
4416f5
+   the Free Software Foundation; either version 3 of the License, or
4416f5
+   (at your option) any later version.
4416f5
+
4416f5
+   This program is distributed in the hope that it will be useful,
4416f5
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
4416f5
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
4416f5
+   GNU General Public License for more details.
4416f5
+
4416f5
+   You should have received a copy of the GNU General Public License
4416f5
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
4416f5
+
4416f5
+typedef int (*callback_t) (void);
4416f5
+
4416f5
+extern int caller (callback_t callback);
4416f5
+
4416f5
+int
4416f5
+callback (void)
4416f5
+{
4416f5
+  return 1;
4416f5
+}
4416f5
+
4416f5
+int
4416f5
+main (void)
4416f5
+{
4416f5
+  return caller (callback);
4416f5
+}
4416f5
diff --git a/gdb/testsuite/gdb.base/cfi-without-die.exp b/gdb/testsuite/gdb.base/cfi-without-die.exp
4416f5
new file mode 100644
4416f5
--- /dev/null
4416f5
+++ b/gdb/testsuite/gdb.base/cfi-without-die.exp
4416f5
@@ -0,0 +1,71 @@
4416f5
+# Copyright 2010 Free Software Foundation, Inc.
4416f5
+
4416f5
+# This program is free software; you can redistribute it and/or modify
4416f5
+# it under the terms of the GNU General Public License as published by
4416f5
+# the Free Software Foundation; either version 3 of the License, or
4416f5
+# (at your option) any later version.
4416f5
+#
4416f5
+# This program is distributed in the hope that it will be useful,
4416f5
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
4416f5
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
4416f5
+# GNU General Public License for more details.
4416f5
+#
4416f5
+# You should have received a copy of the GNU General Public License
4416f5
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
4416f5
+
4416f5
+# Test CFI is parsed even for range (function) not described by any DIE.
4416f5
+
4416f5
+set testfile cfi-without-die
4416f5
+set srcmainfile ${testfile}-main.c
4416f5
+set srccallerfile ${testfile}-caller.c
4416f5
+set executable ${testfile}
4416f5
+set objmainfile [standard_output_file ${testfile}-main.o]
4416f5
+set objcallerfile [standard_output_file ${testfile}-caller.o]
4416f5
+set binfile [standard_output_file ${executable}]
4416f5
+
4416f5
+if { [gdb_compile "${srcdir}/${subdir}/${srccallerfile}" ${objcallerfile} \
4416f5
+      object [list {additional_flags=-fomit-frame-pointer -fno-unwind-tables -fno-asynchronous-unwind-tables}]] != ""
4416f5
+     || [gdb_compile "${srcdir}/${subdir}/${srcmainfile}" ${objmainfile} object {debug}] != ""
4416f5
+     || [gdb_compile "${objmainfile} ${objcallerfile}" ${binfile} executable {}] != "" } {
4416f5
+     untested ${testfile}.exp
4416f5
+     return -1
4416f5
+}
4416f5
+
4416f5
+clean_restart $executable
4416f5
+
4416f5
+if ![runto callback] then {
4416f5
+   fail "verify unwinding: Can't run to callback"
4416f5
+   return 0
4416f5
+}
4416f5
+set test "verify unwinding breaks without CFI"
4416f5
+gdb_test_multiple "bt" $test {
4416f5
+    -re " in \[?\]\[?\] .*\r\n$gdb_prompt $" {
4416f5
+	# It may backtrace through some random frames even to main().
4416f5
+	pass $test
4416f5
+    }
4416f5
+    -re " in main .*\r\n$gdb_prompt $" {
4416f5
+	fail $test
4416f5
+    }
4416f5
+    -re "\r\n$gdb_prompt $" {
4416f5
+	pass $test
4416f5
+    }
4416f5
+}
4416f5
+
4416f5
+if { [gdb_compile "${srcdir}/${subdir}/${srccallerfile}" ${objcallerfile} \
4416f5
+      object [list {additional_flags=-fomit-frame-pointer -funwind-tables -fasynchronous-unwind-tables}]] != ""
4416f5
+     || [gdb_compile "${srcdir}/${subdir}/${srcmainfile}" ${objmainfile} object {debug}] != ""
4416f5
+     || [gdb_compile "${objmainfile} ${objcallerfile}" ${binfile} executable {}] != "" } {
4416f5
+     untested ${testfile}.exp
4416f5
+     return -1
4416f5
+}
4416f5
+
4416f5
+clean_restart $executable
4416f5
+
4416f5
+if ![runto callback] then {
4416f5
+   fail "test CFI without DIEs: Can't run to callback"
4416f5
+   return 0
4416f5
+}
4416f5
+# #0  callback () at ...
4416f5
+# #1  0x00000000004004e9 in caller ()
4416f5
+# #2  0x00000000004004cd in main () at ...
4416f5
+gdb_test "bt" "#0 +callback \[^\r\n\]+\r\n#1 \[^\r\n\]+ in caller \[^\r\n\]+\r\n#2 \[^\r\n\]+ in main \[^\r\n\]+" "verify unwindin works for CFI without DIEs"