Blame SOURCES/gdb-runtest-pie-override.patch

132741
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
132741
From: Fedora GDB patches <invalid@email.com>
132741
Date: Fri, 27 Oct 2017 21:07:50 +0200
132741
Subject: gdb-runtest-pie-override.patch
132741
132741
;; Hack for proper PIE run of the testsuite.
132741
;;=fedoratest
132741
132741
make check//unix/-fPIE/-pie RUNTESTFLAGS=solib-display.exp
132741
132741
gcc -fpic -c  -fPIE -pie -o x.o x.c
132741
/usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/Scrt1.o: In function `_start':
132741
(.text+0x20): undefined reference to `main'
132741
132741
=> Change the order for overrides.
132741
132741
One has to also use -fPIC rather than -fPIE, -fPIC is stronger.
132741
132741
The correct way would be:
132741
make check//unix RUNTESTFLAGS='CC_FOR_TARGET=gcc\ -fPIC\ -pie CXX_FOR_TARGET=g++\ -fPIC\ -pie solib-display.exp'
132741
132741
But there is a problem with testsuite.unix non-unique subdir name and also
132741
a problem with make -j parallelization of the testsuite.
132741
132741
diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
132741
--- a/gdb/testsuite/lib/future.exp
132741
+++ b/gdb/testsuite/lib/future.exp
132741
@@ -197,6 +197,10 @@ proc gdb_default_target_compile_1 {source destfile type options} {
132741
     set ldflags ""
132741
     set dest [target_info name]
132741
 
132741
+    if {[board_info $dest exists multilib_flags]} {
132741
+	append add_flags " [board_info $dest multilib_flags]"
132741
+    }
132741
+
132741
     if {[info exists CFLAGS_FOR_TARGET]} {
132741
 	append add_flags " $CFLAGS_FOR_TARGET"
132741
     }
132741
@@ -531,10 +535,6 @@ proc gdb_default_target_compile_1 {source destfile type options} {
132741
 	}
132741
     }
132741
 
132741
-    if {[board_info $dest exists multilib_flags]} {
132741
-	append add_flags " [board_info $dest multilib_flags]"
132741
-    }
132741
-
132741
     verbose "doing compile"
132741
 
132741
     set sources ""