Blame SOURCES/gdb-rhbz1149205-catch-syscall-after-fork-test.patch

4416f5
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
4416f5
From: Fedora GDB patches <invalid@email.com>
4416f5
Date: Fri, 27 Oct 2017 21:07:50 +0200
4416f5
Subject: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
4416f5
4416f5
;; Fix '`catch syscall' doesn't work for parent after `fork' is called'
4416f5
;; (Philippe Waroquiers, RH BZ 1149205).
4416f5
;;=fedoratest
4416f5
4416f5
URL: <https://sourceware.org/ml/gdb-patches/2013-05/msg00364.html>
4416f5
Message-ID: <1368136582.30058.7.camel@soleil>
4416f5
4416f5
  From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
4416f5
  To: gdb-patches at sourceware dot org
4416f5
  Subject: RFA: fix gdb_assert caused by 'catch signal ...' and fork
4416f5
  Date: Thu, 09 May 2013 23:56:22 +0200
4416f5
4416f5
  The attached patch fixes a gdb_assert caused by the combination of catch
4416f5
  signal and fork:
4416f5
    break-catch-sig.c:152: internal-error: signal_catchpoint_remove_location: Assertion `signal_catch_counts[iter] > 0' failed.
4416f5
4416f5
  The problem is that the signal_catch_counts is decremented by detach_breakpoints.
4416f5
  The fix consists in not detaching breakpoint locations of type bp_loc_other.
4416f5
  The patch introduces a new test.
4416f5
4416f5
Comments by Sergio Durigan Junior:
4416f5
4416f5
  I addded a specific testcase for this patch, which tests exactly the
4416f5
  issue that the customer is facing.  This patch does not solve the
4416f5
  whole problem of catching a syscall and forking (for more details,
4416f5
  see <https://sourceware.org/bugzilla/show_bug.cgi?id=13457>,
4416f5
  specifically comment #3), but it solves the issue reported by the
4416f5
  customer.
4416f5
4416f5
  I also removed the original testcase of this patch, because it
4416f5
  relied on "catch signal", which is a command that is not implemented
4416f5
  in this version of GDB.
4416f5
4416f5
commit bd9673a4ded96ea5c108601501c8e59003ea1be6
4416f5
Author: Philippe Waroquiers <philippe@sourceware.org>
4416f5
Date:   Tue May 21 18:47:05 2013 +0000
4416f5
4416f5
    Fix internal error caused by interaction between catch signal and fork
4416f5
4416f5
diff --git a/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c
4416f5
new file mode 100644
4416f5
--- /dev/null
4416f5
+++ b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c
4416f5
@@ -0,0 +1,11 @@
4416f5
+#include <stdio.h>
4416f5
+#include <unistd.h>
4416f5
+
4416f5
+int
4416f5
+main (int argc, char **argv)
4416f5
+{
4416f5
+  if (fork () == 0)
4416f5
+    sleep (1);
4416f5
+  chdir (".");
4416f5
+  return 0;
4416f5
+}
4416f5
diff --git a/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp
4416f5
new file mode 100644
4416f5
--- /dev/null
4416f5
+++ b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp
4416f5
@@ -0,0 +1,58 @@
4416f5
+# Copyright 2015 Free Software Foundation, Inc.
4416f5
+
4416f5
+# This program is free software; you can redistribute it and/or modify
4416f5
+# it under the terms of the GNU General Public License as published by
4416f5
+# the Free Software Foundation; either version 3 of the License, or
4416f5
+# (at your option) any later version.
4416f5
+#
4416f5
+# This program is distributed in the hope that it will be useful,
4416f5
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
4416f5
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
4416f5
+# GNU General Public License for more details.
4416f5
+#
4416f5
+# You should have received a copy of the GNU General Public License
4416f5
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
4416f5
+
4416f5
+if { [is_remote target] || ![isnative] } then {
4416f5
+    continue
4416f5
+}
4416f5
+
4416f5
+set testfile "gdb-rhbz1149205-catch-syscall-fork"
4416f5
+set srcfile ${testfile}.c
4416f5
+set binfile [standard_output_file ${testfile}]
4416f5
+
4416f5
+# Until "catch syscall" is implemented on other targets...
4416f5
+if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then {
4416f5
+    continue
4416f5
+}
4416f5
+
4416f5
+# This shall be updated whenever 'catch syscall' is implemented
4416f5
+# on some architecture.
4416f5
+#if { ![istarget "i\[34567\]86-*-linux*"]
4416f5
+if { ![istarget "x86_64-*-linux*"] && ![istarget "i\[34567\]86-*-linux*"]
4416f5
+     && ![istarget "powerpc-*-linux*"] && ![istarget "powerpc64-*-linux*"]
4416f5
+     && ![istarget "sparc-*-linux*"] && ![istarget "sparc64-*-linux*"] } {
4416f5
+     continue
4416f5
+}
4416f5
+
4416f5
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
4416f5
+    untested ${testfile}.exp
4416f5
+    return -1
4416f5
+}
4416f5
+
4416f5
+gdb_exit
4416f5
+gdb_start
4416f5
+gdb_reinitialize_dir $srcdir/$subdir
4416f5
+gdb_load $binfile
4416f5
+
4416f5
+if { ![runto_main] } {
4416f5
+    return -1
4416f5
+}
4416f5
+
4416f5
+gdb_test "catch syscall chdir" \
4416f5
+  "Catchpoint $decimal \\\(syscall (.)?chdir(.)? \\\[$decimal\\\]\\\)" \
4416f5
+  "catch syscall chdir"
4416f5
+
4416f5
+gdb_test "continue" \
4416f5
+  "Continuing\.\r\n.*\r\nCatchpoint $decimal \\\(call to syscall .?chdir.?.*" \
4416f5
+  "continue from catch syscall after fork"