Blame SOURCES/0135-Use-printpid-in-decoders.patch

097fad
From 4d1964761ad04028a0e6288821ee0feef5ca8fc1 Mon Sep 17 00:00:00 2001
097fad
From: =?UTF-8?q?=C3=81kos=20Uzonyi?= <uzonyi.akos@gmail.com>
097fad
Date: Wed, 10 Jun 2020 13:18:50 +0200
097fad
Subject: [PATCH 135/138] Use printpid in decoders
097fad
097fad
* getpid.c: New file.
097fad
* Makefile.am (libstrace_a_SOURCES): Add it.
097fad
* linux/dummy.h (sys_getpid, sys_getppid, sys_gettid,
097fad
sys_setpgid, sys_setpgrp): Remove.
097fad
* util.c (printfd_pid_tracee_ns): Implement using translate_pid.
097fad
* defs.h (printnum_pid): New function definition.
097fad
(printfd_pid_tracee_ns): Update documentation
097fad
* util.c: (printnum_pid): New function.
097fad
* print_fields.h (PRINT_FIELD_TID): New macro.
097fad
(PRINT_FIELD_TGID): Likewise.
097fad
(PRINT_FIELD_PGID): Likewise.
097fad
(PRINT_FIELD_SID): Likewise.
097fad
* affinity.c: Print PIDs with printpid.
097fad
* block.c: Likewise.
097fad
* bpf.c: Likewise.
097fad
* capability.c: Likewise.
097fad
* clone.c: Likewise.
097fad
* fcntl.c: Likewise.
097fad
* get_robust_list.c: Likewise.
097fad
* ioprio.c: Likewise.
097fad
* kcmp.c: Likewise.
097fad
* msghdr.c: Likewise.
097fad
* net.c: Likewise.
097fad
* netlink.c: Likewise.
097fad
* numa.c: Likewise.
097fad
* pidfd_open.c: Likewise.
097fad
* printsiginfo.c: Likewise.
097fad
* process.c: Likewise.
097fad
* process_vm.c: Likewise.
097fad
* resource.c: Likewise.
097fad
* sched.c: Likewise.
097fad
* signal.c: Likewise.
097fad
* sockaddr.c: Likewise.
097fad
* wait.c: Likewise.
097fad
* kcmp.c (SYS_FUNC(kcmp)): Fix KCMP_FILE pid arguments.
097fad
* tests/kcmp.c (printpidfd): Print path if VERBOSE_FD.
097fad
(main): Use our real pid if real fds are used.
097fad
---
097fad
 Makefile.am       |  1 +
097fad
 affinity.c        |  6 ++++--
097fad
 block.c           |  2 +-
097fad
 bpf.c             |  2 +-
097fad
 capability.c      |  4 +++-
097fad
 clone.c           | 14 +++++++-------
097fad
 defs.h            |  5 ++++-
097fad
 fcntl.c           | 24 ++++++++++++++++++++++--
097fad
 get_robust_list.c |  3 ++-
097fad
 getpid.c          | 46 ++++++++++++++++++++++++++++++++++++++++++++++
097fad
 ioprio.c          | 26 ++++++++++++++++++++++----
097fad
 ipc_shmctl.c      |  4 ++--
097fad
 kcmp.c            |  5 ++++-
097fad
 linux/dummy.h     |  8 +-------
097fad
 msghdr.c          |  2 +-
097fad
 net.c             |  2 +-
097fad
 netlink.c         |  5 +++--
097fad
 numa.c            |  6 ++++--
097fad
 pidfd_open.c      |  2 +-
097fad
 print_fields.h    | 24 ++++++++++++++++++++++++
097fad
 printsiginfo.c    |  2 +-
097fad
 process.c         |  3 ++-
097fad
 process_vm.c      |  6 ++++--
097fad
 resource.c        | 27 ++++++++++++++++++++++++---
097fad
 sched.c           | 25 ++++++++++++++++---------
097fad
 signal.c          | 21 +++++++++++++++------
097fad
 sockaddr.c        |  2 +-
097fad
 tests/kcmp.c      | 25 ++++++++++++++++++++++---
097fad
 util.c            | 22 +++++++++++++++-------
097fad
 wait.c            | 36 ++++++++++++++++++++++++------------
097fad
 30 files changed, 278 insertions(+), 82 deletions(-)
097fad
 create mode 100644 getpid.c
097fad
097fad
Index: strace-5.7/Makefile.am
097fad
===================================================================
097fad
--- strace-5.7.orig/Makefile.am	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/Makefile.am	2020-09-09 18:49:06.780401433 +0200
097fad
@@ -135,6 +135,7 @@
097fad
 	getcpu.c	\
097fad
 	getcwd.c	\
097fad
 	getpagesize.c \
097fad
+	getpid.c	\
097fad
 	getrandom.c	\
097fad
 	hdio.c		\
097fad
 	hostname.c	\
097fad
Index: strace-5.7/affinity.c
097fad
===================================================================
097fad
--- strace-5.7.orig/affinity.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/affinity.c	2020-09-09 15:55:03.979108297 +0200
097fad
@@ -82,7 +82,8 @@
097fad
 	const int pid = tcp->u_arg[0];
097fad
 	const unsigned int len = tcp->u_arg[1];
097fad
 
097fad
-	tprintf("%d, %u, ", pid, len);
097fad
+	printpid(tcp, pid, PT_TGID);
097fad
+	tprintf(", %u, ", len);
097fad
 	print_affinitylist(tcp, tcp->u_arg[2], len);
097fad
 
097fad
 	return RVAL_DECODED;
097fad
@@ -94,7 +95,8 @@
097fad
 	const unsigned int len = tcp->u_arg[1];
097fad
 
097fad
 	if (entering(tcp)) {
097fad
-		tprintf("%d, %u, ", pid, len);
097fad
+		printpid(tcp, pid, PT_TGID);
097fad
+		tprintf(", %u, ", len);
097fad
 	} else {
097fad
 		print_affinitylist(tcp, tcp->u_arg[2], tcp->u_rval);
097fad
 	}
097fad
Index: strace-5.7/block.c
097fad
===================================================================
097fad
--- strace-5.7.orig/block.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/block.c	2020-09-09 15:55:03.979108297 +0200
097fad
@@ -179,7 +179,7 @@
097fad
 			PRINT_FIELD_U(", ", buts, buf_nr);
097fad
 			PRINT_FIELD_U(", ", buts, start_lba);
097fad
 			PRINT_FIELD_U(", ", buts, end_lba);
097fad
-			PRINT_FIELD_D(", ", buts, pid);
097fad
+			PRINT_FIELD_TGID(", ", buts, pid, tcp);
097fad
 			return 0;
097fad
 		} else {
097fad
 			struct_blk_user_trace_setup buts;
097fad
Index: strace-5.7/bpf.c
097fad
===================================================================
097fad
--- strace-5.7.orig/bpf.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/bpf.c	2020-09-09 15:55:03.980108298 +0200
097fad
@@ -927,7 +927,7 @@
097fad
 	if (entering(tcp)) {
097fad
 		set_tcb_priv_ulong(tcp, attr.buf_len);
097fad
 
097fad
-		PRINT_FIELD_D("{task_fd_query={", attr, pid);
097fad
+		PRINT_FIELD_TGID("{task_fd_query={", attr, pid, tcp);
097fad
 		PRINT_FIELD_FD(", ", attr, fd, tcp);
097fad
 		PRINT_FIELD_U(", ", attr, flags);
097fad
 		PRINT_FIELD_U(", ", attr, buf_len);
097fad
Index: strace-5.7/capability.c
097fad
===================================================================
097fad
--- strace-5.7.orig/capability.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/capability.c	2020-09-09 15:55:03.980108298 +0200
097fad
@@ -70,7 +70,9 @@
097fad
 	tprints("{version=");
097fad
 	printxval(cap_version, h->version,
097fad
 		  "_LINUX_CAPABILITY_VERSION_???");
097fad
-	tprintf(", pid=%d}", h->pid);
097fad
+	tprints(", pid=");
097fad
+	printpid(tcp, h->pid, PT_TGID);
097fad
+	tprints("}");
097fad
 }
097fad
 
097fad
 static void
097fad
Index: strace-5.7/clone.c
097fad
===================================================================
097fad
--- strace-5.7.orig/clone.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/clone.c	2020-09-09 15:55:03.980108298 +0200
097fad
@@ -114,14 +114,14 @@
097fad
 		 */
097fad
 		if ((flags & (CLONE_PARENT_SETTID|CLONE_PIDFD|CLONE_CHILD_SETTID
097fad
 			      |CLONE_CHILD_CLEARTID|CLONE_SETTLS)) == 0)
097fad
-			return RVAL_DECODED;
097fad
+			return RVAL_DECODED | RVAL_TID;
097fad
 	} else {
097fad
 		if (flags & (CLONE_PARENT_SETTID|CLONE_PIDFD)) {
097fad
 			kernel_ulong_t addr = tcp->u_arg[ARG_PTID];
097fad
 
097fad
 			tprints(", parent_tid=");
097fad
 			if (flags & CLONE_PARENT_SETTID)
097fad
-				printnum_int(tcp, addr, "%u");
097fad
+				printnum_pid(tcp, addr, PT_TID);
097fad
 			else
097fad
 				printnum_fd(tcp, addr);
097fad
 		}
097fad
@@ -134,7 +134,7 @@
097fad
 			printaddr(tcp->u_arg[ARG_CTID]);
097fad
 		}
097fad
 	}
097fad
-	return 0;
097fad
+	return RVAL_TID;
097fad
 }
097fad
 
097fad
 
097fad
@@ -229,7 +229,7 @@
097fad
 
097fad
 		if ((arg.flags & (CLONE_PIDFD | CLONE_PARENT_SETTID)) ||
097fad
 		    (size > fetch_size))
097fad
-			return 0;
097fad
+			return RVAL_TID;
097fad
 
097fad
 		goto out;
097fad
 	}
097fad
@@ -256,7 +256,7 @@
097fad
 
097fad
 	if (arg.flags & CLONE_PARENT_SETTID) {
097fad
 		tprintf("%sparent_tid=", pfx);
097fad
-		printnum_int(tcp, arg.parent_tid, "%d"); /* TID */
097fad
+		printnum_pid(tcp, arg.parent_tid, PT_TID);
097fad
 		pfx = ", ";
097fad
 	}
097fad
 
097fad
@@ -279,7 +279,7 @@
097fad
 out:
097fad
 	tprintf(", %" PRI_klu, size);
097fad
 
097fad
-	return RVAL_DECODED;
097fad
+	return RVAL_DECODED | RVAL_TID;
097fad
 }
097fad
 
097fad
 
097fad
@@ -300,5 +300,5 @@
097fad
 
097fad
 SYS_FUNC(fork)
097fad
 {
097fad
-	return RVAL_DECODED;
097fad
+	return RVAL_DECODED | RVAL_TGID;
097fad
 }
097fad
Index: strace-5.7/defs.h
097fad
===================================================================
097fad
--- strace-5.7.orig/defs.h	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/defs.h	2020-09-09 15:55:03.980108298 +0200
097fad
@@ -1101,7 +1101,7 @@
097fad
 
097fad
 /**
097fad
  * Print file descriptor fd owned by process with ID pid (from the PID NS
097fad
- * of the tracee the descriptor tcp).  This is a stub.
097fad
+ * of the tracee).
097fad
  */
097fad
 extern void printfd_pid_tracee_ns(struct tcb *tcp, pid_t pid, int fd);
097fad
 
097fad
@@ -1562,6 +1562,9 @@
097fad
 extern bool
097fad
 printnum_fd(struct tcb *, kernel_ulong_t addr);
097fad
 
097fad
+extern bool
097fad
+printnum_pid(struct tcb *const tcp, const kernel_ulong_t addr, enum pid_type type);
097fad
+
097fad
 static inline bool
097fad
 printnum_slong(struct tcb *tcp, kernel_ulong_t addr)
097fad
 {
097fad
Index: strace-5.7/fcntl.c
097fad
===================================================================
097fad
--- strace-5.7.orig/fcntl.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/fcntl.c	2020-09-09 15:55:03.981108298 +0200
097fad
@@ -28,7 +28,7 @@
097fad
 	PRINT_FIELD_D(", ", *fl, l_start);
097fad
 	PRINT_FIELD_D(", ", *fl, l_len);
097fad
 	if (getlk)
097fad
-		PRINT_FIELD_D(", ", *fl, l_pid);
097fad
+		PRINT_FIELD_TGID(", ", *fl, l_pid, tcp);
097fad
 	tprints("}");
097fad
 }
097fad
 
097fad
@@ -59,7 +59,22 @@
097fad
 		return;
097fad
 
097fad
 	PRINT_FIELD_XVAL("{", owner, type, f_owner_types, "F_OWNER_???");
097fad
-	PRINT_FIELD_D(", ", owner, pid);
097fad
+
097fad
+	enum pid_type pid_type = PT_NONE;
097fad
+	switch (owner.type)
097fad
+	{
097fad
+	case F_OWNER_TID:
097fad
+		pid_type = PT_TID;
097fad
+		break;
097fad
+	case F_OWNER_PID:
097fad
+		pid_type = PT_TGID;
097fad
+		break;
097fad
+	case F_OWNER_PGRP:
097fad
+		pid_type = PT_PGID;
097fad
+		break;
097fad
+	}
097fad
+	tprints(", pid=");
097fad
+	printpid(tcp, owner.pid, pid_type);
097fad
 	tprints("}");
097fad
 }
097fad
 
097fad
@@ -74,6 +89,9 @@
097fad
 		printflags(fdflags, tcp->u_arg[2], "FD_???");
097fad
 		break;
097fad
 	case F_SETOWN:
097fad
+		tprints(", ");
097fad
+		printpid_tgid_pgid(tcp, tcp->u_arg[2]);
097fad
+		break;
097fad
 	case F_SETPIPE_SZ:
097fad
 		tprintf(", %" PRI_kld, tcp->u_arg[2]);
097fad
 		break;
097fad
@@ -116,6 +134,8 @@
097fad
 		printsignal(tcp->u_arg[2]);
097fad
 		break;
097fad
 	case F_GETOWN:
097fad
+		return RVAL_DECODED |
097fad
+		       ((int) tcp->u_rval < 0 ? RVAL_PGID : RVAL_TGID);
097fad
 	case F_GETPIPE_SZ:
097fad
 		break;
097fad
 	case F_GETFD:
097fad
Index: strace-5.7/get_robust_list.c
097fad
===================================================================
097fad
--- strace-5.7.orig/get_robust_list.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/get_robust_list.c	2020-09-09 15:55:03.981108298 +0200
097fad
@@ -10,7 +10,8 @@
097fad
 SYS_FUNC(get_robust_list)
097fad
 {
097fad
 	if (entering(tcp)) {
097fad
-		tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+		printpid(tcp, tcp->u_arg[0], PT_TID);
097fad
+		tprints(", ");
097fad
 	} else {
097fad
 		printnum_ptr(tcp, tcp->u_arg[1]);
097fad
 		tprints(", ");
097fad
Index: strace-5.7/getpid.c
097fad
===================================================================
097fad
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
097fad
+++ strace-5.7/getpid.c	2020-09-09 15:55:03.981108298 +0200
097fad
@@ -0,0 +1,46 @@
097fad
+/*
097fad
+ * Copyright (c) 2020 Ákos Uzonyi <uzonyi.akos@gmail.com>
097fad
+ * All rights reserved.
097fad
+ *
097fad
+ * SPDX-License-Identifier: LGPL-2.1-or-later
097fad
+ */
097fad
+
097fad
+#include "defs.h"
097fad
+
097fad
+SYS_FUNC(getpid)
097fad
+{
097fad
+	return RVAL_DECODED | RVAL_TGID;
097fad
+}
097fad
+
097fad
+SYS_FUNC(gettid)
097fad
+{
097fad
+	return RVAL_DECODED | RVAL_TID;
097fad
+}
097fad
+
097fad
+SYS_FUNC(getpgrp)
097fad
+{
097fad
+	return RVAL_DECODED | RVAL_PGID;
097fad
+}
097fad
+
097fad
+SYS_FUNC(getpgid)
097fad
+{
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+
097fad
+	return RVAL_DECODED | RVAL_PGID;
097fad
+}
097fad
+
097fad
+SYS_FUNC(getsid)
097fad
+{
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+
097fad
+	return RVAL_DECODED | RVAL_SID;
097fad
+}
097fad
+
097fad
+SYS_FUNC(setpgid)
097fad
+{
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+	tprints(", ");
097fad
+	printpid(tcp, tcp->u_arg[1], PT_PGID);
097fad
+
097fad
+	return RVAL_DECODED;
097fad
+}
097fad
Index: strace-5.7/ioprio.c
097fad
===================================================================
097fad
--- strace-5.7.orig/ioprio.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/ioprio.c	2020-09-09 15:55:03.981108298 +0200
097fad
@@ -49,13 +49,30 @@
097fad
 		? tprints_comment : tprints)(str);
097fad
 }
097fad
 
097fad
+static void
097fad
+ioprio_print_who(struct tcb *tcp, int which, int who)
097fad
+{
097fad
+	switch (which)
097fad
+	{
097fad
+	case IOPRIO_WHO_PROCESS:
097fad
+		printpid(tcp, who, PT_TGID);
097fad
+		break;
097fad
+	case IOPRIO_WHO_PGRP:
097fad
+		printpid(tcp, who, PT_PGID);
097fad
+		break;
097fad
+	default:
097fad
+		tprintf("%d", who);
097fad
+		break;
097fad
+	}
097fad
+}
097fad
+
097fad
 SYS_FUNC(ioprio_get)
097fad
 {
097fad
 	if (entering(tcp)) {
097fad
 		/* int which */
097fad
 		printxval(ioprio_who, tcp->u_arg[0], "IOPRIO_WHO_???");
097fad
-		/* int who */
097fad
-		tprintf(", %d", (int) tcp->u_arg[1]);
097fad
+		tprints(", ");
097fad
+		ioprio_print_who(tcp, tcp->u_arg[0], tcp->u_arg[1]);
097fad
 		return 0;
097fad
 	} else {
097fad
 		if (syserror(tcp))
097fad
@@ -72,8 +89,9 @@
097fad
 {
097fad
 	/* int which */
097fad
 	printxval(ioprio_who, tcp->u_arg[0], "IOPRIO_WHO_???");
097fad
-	/* int who */
097fad
-	tprintf(", %d, ", (int) tcp->u_arg[1]);
097fad
+	tprints(", ");
097fad
+	ioprio_print_who(tcp, tcp->u_arg[0], tcp->u_arg[1]);
097fad
+	tprints(", ");
097fad
 	/* int ioprio */
097fad
 	if (xlat_verbose(xlat_verbosity) != XLAT_STYLE_ABBREV)
097fad
 		tprintf("%d", (int) tcp->u_arg[2]);
097fad
Index: strace-5.7/ipc_shmctl.c
097fad
===================================================================
097fad
--- strace-5.7.orig/ipc_shmctl.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/ipc_shmctl.c	2020-09-09 15:55:03.981108298 +0200
097fad
@@ -54,8 +54,8 @@
097fad
 		PRINT_FIELD_UID(", ", shmid_ds.shm_perm, cgid);
097fad
 		tprints("}");
097fad
 		tprintf(", shm_segsz=%u", (unsigned) shmid_ds.shm_segsz);
097fad
-		PRINT_FIELD_D(", ", shmid_ds, shm_cpid);
097fad
-		PRINT_FIELD_D(", ", shmid_ds, shm_lpid);
097fad
+		PRINT_FIELD_TGID(", ", shmid_ds, shm_cpid, tcp);
097fad
+		PRINT_FIELD_TGID(", ", shmid_ds, shm_lpid, tcp);
097fad
 		tprintf(", shm_nattch=%u", (unsigned) shmid_ds.shm_nattch);
097fad
 		tprintf(", shm_atime=%u", (unsigned) shmid_ds.shm_atime);
097fad
 		tprintf(", shm_dtime=%u", (unsigned) shmid_ds.shm_dtime);
097fad
Index: strace-5.7/kcmp.c
097fad
===================================================================
097fad
--- strace-5.7.orig/kcmp.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/kcmp.c	2020-09-09 15:55:03.981108298 +0200
097fad
@@ -30,7 +30,10 @@
097fad
 	kernel_ulong_t idx1 = tcp->u_arg[3];
097fad
 	kernel_ulong_t idx2 = tcp->u_arg[4];
097fad
 
097fad
-	tprintf("%d, %d, ", pid1, pid2);
097fad
+	printpid(tcp, pid1, PT_TGID);
097fad
+	tprints(", ");
097fad
+	printpid(tcp, pid2, PT_TGID);
097fad
+	tprints(", ");
097fad
 	printxval(kcmp_types, type, "KCMP_???");
097fad
 
097fad
 	switch (type) {
097fad
Index: strace-5.7/linux/dummy.h
097fad
===================================================================
097fad
--- strace-5.7.orig/linux/dummy.h	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/linux/dummy.h	2020-09-09 15:55:03.982108299 +0200
097fad
@@ -53,6 +53,7 @@
097fad
 # define sys_getgid		sys_getuid
097fad
 # define sys_getgid16		sys_getuid16
097fad
 # define sys_getpeername		sys_getsockname
097fad
+# define sys_getppid		sys_getpid
097fad
 # define sys_getresgid		sys_getresuid
097fad
 # define sys_getresgid16		sys_getresuid16
097fad
 # define sys_lstat		sys_stat
097fad
@@ -87,10 +88,6 @@
097fad
 # define sys_vfork		sys_fork
097fad
 
097fad
 /* printargs does the right thing */
097fad
-# define sys_getpgrp		printargs
097fad
-# define sys_getpid		printargs
097fad
-# define sys_getppid		printargs
097fad
-# define sys_gettid		printargs
097fad
 # define sys_idle		printargs
097fad
 # define sys_munlockall		printargs
097fad
 # define sys_pause		printargs
097fad
@@ -108,10 +105,7 @@
097fad
 
097fad
 /* printargs_d does the right thing */
097fad
 # define sys_exit		printargs_d
097fad
-# define sys_getpgid		printargs_d
097fad
-# define sys_getsid		printargs_d
097fad
 # define sys_nice		printargs_d
097fad
-# define sys_setpgid		printargs_d
097fad
 # define sys_setpgrp		printargs_d
097fad
 # define sys_timer_delete	printargs_d
097fad
 # define sys_timer_getoverrun	printargs_d
097fad
Index: strace-5.7/msghdr.c
097fad
===================================================================
097fad
--- strace-5.7.orig/msghdr.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/msghdr.c	2020-09-09 15:55:03.982108299 +0200
097fad
@@ -69,7 +69,7 @@
097fad
 {
097fad
 	const struct ucred *uc = cmsg_data;
097fad
 
097fad
-	PRINT_FIELD_D("{", *uc, pid);
097fad
+	PRINT_FIELD_TGID("{", *uc, pid, tcp);
097fad
 	PRINT_FIELD_UID(", ", *uc, uid);
097fad
 	PRINT_FIELD_UID(", ", *uc, gid);
097fad
 	tprints("}");
097fad
Index: strace-5.7/net.c
097fad
===================================================================
097fad
--- strace-5.7.orig/net.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/net.c	2020-09-09 15:55:03.982108299 +0200
097fad
@@ -601,7 +601,7 @@
097fad
 	if (umoven_or_printaddr(tcp, addr, len, &uc))
097fad
 		return;
097fad
 
097fad
-	PRINT_FIELD_LEN("{", uc, pid, len, PRINT_FIELD_D);
097fad
+	PRINT_FIELD_LEN("{", uc, pid, len, PRINT_FIELD_TGID, tcp);
097fad
 	PRINT_FIELD_LEN(", ", uc, uid, len, PRINT_FIELD_UID);
097fad
 	PRINT_FIELD_LEN(", ", uc, gid, len, PRINT_FIELD_UID);
097fad
 	tprints("}");
097fad
Index: strace-5.7/netlink.c
097fad
===================================================================
097fad
--- strace-5.7.orig/netlink.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/netlink.c	2020-09-09 15:55:03.982108299 +0200
097fad
@@ -446,8 +446,9 @@
097fad
 	decode_nlmsg_flags(nlmsghdr->nlmsg_flags,
097fad
 			   nlmsghdr->nlmsg_type, family);
097fad
 
097fad
-	tprintf(", seq=%u, pid=%d}", nlmsghdr->nlmsg_seq,
097fad
-		nlmsghdr->nlmsg_pid);
097fad
+	tprintf(", seq=%u, pid=", nlmsghdr->nlmsg_seq);
097fad
+	printpid(tcp, nlmsghdr->nlmsg_pid, PT_TGID);
097fad
+	tprints("}");
097fad
 }
097fad
 
097fad
 static bool
097fad
Index: strace-5.7/numa.c
097fad
===================================================================
097fad
--- strace-5.7.orig/numa.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/numa.c	2020-09-09 15:55:03.982108299 +0200
097fad
@@ -44,7 +44,8 @@
097fad
 
097fad
 SYS_FUNC(migrate_pages)
097fad
 {
097fad
-	tprintf("%d, %" PRI_klu ", ", (int) tcp->u_arg[0], tcp->u_arg[1]);
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+	tprintf(", %" PRI_klu ", ", tcp->u_arg[1]);
097fad
 	print_nodemask(tcp, tcp->u_arg[2], tcp->u_arg[1]);
097fad
 	tprints(", ");
097fad
 	print_nodemask(tcp, tcp->u_arg[3], tcp->u_arg[1]);
097fad
@@ -170,7 +171,8 @@
097fad
 	kernel_ulong_t buf;
097fad
 
097fad
 	if (entering(tcp)) {
097fad
-		tprintf("%d, %" PRI_klu ", ", (int) tcp->u_arg[0], npages);
097fad
+		printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+		tprintf(", %" PRI_klu ", ", npages);
097fad
 		print_array(tcp, tcp->u_arg[2], npages, &buf, current_wordsize,
097fad
 			    tfetch_mem, print_addr, 0);
097fad
 		tprints(", ");
097fad
Index: strace-5.7/pidfd_open.c
097fad
===================================================================
097fad
--- strace-5.7.orig/pidfd_open.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/pidfd_open.c	2020-09-09 15:55:03.983108300 +0200
097fad
@@ -10,7 +10,7 @@
097fad
 SYS_FUNC(pidfd_open)
097fad
 {
097fad
 	/* pid_t pid */
097fad
-	tprintf("%d", (int) tcp->u_arg[0]);
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
 
097fad
 	/* unsigned int flags */
097fad
 	tprintf(", %#x", (unsigned int) tcp->u_arg[1]);
097fad
Index: strace-5.7/print_fields.h
097fad
===================================================================
097fad
--- strace-5.7.orig/print_fields.h	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/print_fields.h	2020-09-09 15:55:03.983108300 +0200
097fad
@@ -236,6 +236,30 @@
097fad
 		printfd((tcp_), (where_).field_);			\
097fad
 	} while (0)
097fad
 
097fad
+# define PRINT_FIELD_TID(prefix_, where_, field_, tcp_)			\
097fad
+	do {								\
097fad
+		STRACE_PRINTF("%s%s=", (prefix_), #field_);		\
097fad
+		printpid((tcp_), (where_).field_, PT_TID);			\
097fad
+	} while (0)
097fad
+
097fad
+# define PRINT_FIELD_TGID(prefix_, where_, field_, tcp_)			\
097fad
+	do {								\
097fad
+		STRACE_PRINTF("%s%s=", (prefix_), #field_);		\
097fad
+		printpid((tcp_), (where_).field_, PT_TGID);			\
097fad
+	} while (0)
097fad
+
097fad
+# define PRINT_FIELD_PGID(prefix_, where_, field_, tcp_)			\
097fad
+	do {								\
097fad
+		STRACE_PRINTF("%s%s=", (prefix_), #field_);		\
097fad
+		printpid((tcp_), (where_).field_, PT_PGID);			\
097fad
+	} while (0)
097fad
+
097fad
+# define PRINT_FIELD_SID(prefix_, where_, field_, tcp_)			\
097fad
+	do {								\
097fad
+		STRACE_PRINTF("%s%s=", (prefix_), #field_);		\
097fad
+		printpid((tcp_), (where_).field_, PT_SID);			\
097fad
+	} while (0)
097fad
+
097fad
 # define PRINT_FIELD_STRN(prefix_, where_, field_, len_, tcp_)		\
097fad
 	do {								\
097fad
 		STRACE_PRINTF("%s%s=", (prefix_), #field_);		\
097fad
Index: strace-5.7/printsiginfo.c
097fad
===================================================================
097fad
--- strace-5.7.orig/printsiginfo.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/printsiginfo.c	2020-09-09 15:55:03.983108300 +0200
097fad
@@ -58,7 +58,7 @@
097fad
 static void
097fad
 printsigsource(struct tcb *tcp, const siginfo_t *sip)
097fad
 {
097fad
-	PRINT_FIELD_D(", ", *sip, si_pid);
097fad
+	PRINT_FIELD_TGID(", ", *sip, si_pid, tcp);
097fad
 	PRINT_FIELD_UID(", ", *sip, si_uid);
097fad
 }
097fad
 
097fad
Index: strace-5.7/process.c
097fad
===================================================================
097fad
--- strace-5.7.orig/process.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/process.c	2020-09-09 15:55:03.983108300 +0200
097fad
@@ -92,7 +92,8 @@
097fad
 		}
097fad
 
097fad
 		/* pid */
097fad
-		tprintf(", %d", pid);
097fad
+		tprints(", ");
097fad
+		printpid(tcp, pid, PT_TGID);
097fad
 
097fad
 		/* addr */
097fad
 		switch (request) {
097fad
Index: strace-5.7/process_vm.c
097fad
===================================================================
097fad
--- strace-5.7.orig/process_vm.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/process_vm.c	2020-09-09 15:55:03.983108300 +0200
097fad
@@ -13,7 +13,8 @@
097fad
 {
097fad
 	if (entering(tcp)) {
097fad
 		/* arg 1: pid */
097fad
-		tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+		printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+		tprints(", ");
097fad
 	} else {
097fad
 		kernel_ulong_t local_iovcnt = tcp->u_arg[2];
097fad
 		kernel_ulong_t remote_iovcnt = tcp->u_arg[4];
097fad
@@ -42,7 +43,8 @@
097fad
 	kernel_ulong_t flags = tcp->u_arg[5];
097fad
 
097fad
 	/* arg 1: pid */
097fad
-	tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+	tprints(", ");
097fad
 	/* arg 2: local iov */
097fad
 	tprint_iov(tcp, local_iovcnt, tcp->u_arg[1], IOV_DECODE_STR);
097fad
 	/* arg 3: local iovcnt */
097fad
Index: strace-5.7/resource.c
097fad
===================================================================
097fad
--- strace-5.7.orig/resource.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/resource.c	2020-09-09 15:55:03.984108300 +0200
097fad
@@ -142,7 +142,8 @@
097fad
 SYS_FUNC(prlimit64)
097fad
 {
097fad
 	if (entering(tcp)) {
097fad
-		tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+		printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+		tprints(", ");
097fad
 		printxval(resources, tcp->u_arg[1], "RLIMIT_???");
097fad
 		tprints(", ");
097fad
 		print_rlimit64(tcp, tcp->u_arg[2]);
097fad
@@ -179,10 +180,28 @@
097fad
 
097fad
 #include "xlat/priorities.h"
097fad
 
097fad
+static void
097fad
+priority_print_who(struct tcb *tcp, int which, int who)
097fad
+{
097fad
+	switch (which)
097fad
+	{
097fad
+	case PRIO_PROCESS:
097fad
+		printpid(tcp, who, PT_TGID);
097fad
+		break;
097fad
+	case PRIO_PGRP:
097fad
+		printpid(tcp, who, PT_PGID);
097fad
+		break;
097fad
+	default:
097fad
+		tprintf("%d", who);
097fad
+		break;
097fad
+	}
097fad
+}
097fad
+
097fad
 SYS_FUNC(getpriority)
097fad
 {
097fad
 	printxval(priorities, tcp->u_arg[0], "PRIO_???");
097fad
-	tprintf(", %d", (int) tcp->u_arg[1]);
097fad
+	tprints(", ");
097fad
+	priority_print_who(tcp, tcp->u_arg[0], tcp->u_arg[1]);
097fad
 
097fad
 	return RVAL_DECODED;
097fad
 }
097fad
@@ -190,7 +209,9 @@
097fad
 SYS_FUNC(setpriority)
097fad
 {
097fad
 	printxval(priorities, tcp->u_arg[0], "PRIO_???");
097fad
-	tprintf(", %d, %d", (int) tcp->u_arg[1], (int) tcp->u_arg[2]);
097fad
+	tprints(", ");
097fad
+	priority_print_who(tcp, tcp->u_arg[0], tcp->u_arg[1]);
097fad
+	tprintf(", %d", (int) tcp->u_arg[2]);
097fad
 
097fad
 	return RVAL_DECODED;
097fad
 }
097fad
Index: strace-5.7/sched.c
097fad
===================================================================
097fad
--- strace-5.7.orig/sched.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/sched.c	2020-09-09 15:55:03.984108300 +0200
097fad
@@ -21,7 +21,7 @@
097fad
 SYS_FUNC(sched_getscheduler)
097fad
 {
097fad
 	if (entering(tcp)) {
097fad
-		tprintf("%d", (int) tcp->u_arg[0]);
097fad
+		printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
 	} else if (!syserror(tcp)) {
097fad
 		tcp->auxstr = xlookup(schedulers, (kernel_ulong_t) tcp->u_rval);
097fad
 		return RVAL_STR;
097fad
@@ -31,7 +31,8 @@
097fad
 
097fad
 SYS_FUNC(sched_setscheduler)
097fad
 {
097fad
-	tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+	tprints(", ");
097fad
 	printxval(schedulers, tcp->u_arg[1], "SCHED_???");
097fad
 	tprints(", ");
097fad
 	printnum_int(tcp, tcp->u_arg[2], "%d");
097fad
@@ -41,16 +42,19 @@
097fad
 
097fad
 SYS_FUNC(sched_getparam)
097fad
 {
097fad
-	if (entering(tcp))
097fad
-		tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
-	else
097fad
+	if (entering(tcp)) {
097fad
+		printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+		tprints(", ");
097fad
+	} else {
097fad
 		printnum_int(tcp, tcp->u_arg[1], "%d");
097fad
+	}
097fad
 	return 0;
097fad
 }
097fad
 
097fad
 SYS_FUNC(sched_setparam)
097fad
 {
097fad
-	tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+	tprints(", ");
097fad
 	printnum_int(tcp, tcp->u_arg[1], "%d");
097fad
 
097fad
 	return RVAL_DECODED;
097fad
@@ -68,7 +72,8 @@
097fad
 			 const print_obj_by_addr_fn print_ts)
097fad
 {
097fad
 	if (entering(tcp)) {
097fad
-		tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+		printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+		tprints(", ");
097fad
 	} else {
097fad
 		if (syserror(tcp))
097fad
 			printaddr(tcp->u_arg[1]);
097fad
@@ -160,7 +165,8 @@
097fad
 SYS_FUNC(sched_setattr)
097fad
 {
097fad
 	if (entering(tcp)) {
097fad
-		tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+		printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+		tprints(", ");
097fad
 		print_sched_attr(tcp, tcp->u_arg[1], 0);
097fad
 	} else {
097fad
 		struct sched_attr attr;
097fad
@@ -179,7 +185,8 @@
097fad
 SYS_FUNC(sched_getattr)
097fad
 {
097fad
 	if (entering(tcp)) {
097fad
-		tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+		printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+		tprints(", ");
097fad
 	} else {
097fad
 		const unsigned int size = tcp->u_arg[2];
097fad
 
097fad
Index: strace-5.7/signal.c
097fad
===================================================================
097fad
--- strace-5.7.orig/signal.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/signal.c	2020-09-09 15:55:03.984108300 +0200
097fad
@@ -439,7 +439,8 @@
097fad
 SYS_FUNC(kill)
097fad
 {
097fad
 	/* pid */
097fad
-	tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+	printpid_tgid_pgid(tcp, tcp->u_arg[0]);
097fad
+	tprints(", ");
097fad
 	/* signal */
097fad
 	printsignal(tcp->u_arg[1]);
097fad
 
097fad
@@ -448,7 +449,7 @@
097fad
 
097fad
 SYS_FUNC(tkill)
097fad
 {
097fad
-	tprintf("%d", (int) tcp->u_arg[0]);
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TID);
097fad
 	tprints(", ");
097fad
 	printsignal(tcp->u_arg[1]);
097fad
 
097fad
@@ -457,8 +458,12 @@
097fad
 
097fad
 SYS_FUNC(tgkill)
097fad
 {
097fad
-	/* tgid, tid */
097fad
-	tprintf("%d, %d, ", (int) tcp->u_arg[0], (int) tcp->u_arg[1]);
097fad
+	/* tgid */
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+	tprints(", ");
097fad
+	/* tid */
097fad
+	printpid(tcp, tcp->u_arg[1], PT_TID);
097fad
+	tprints(", ");
097fad
 	/* signal */
097fad
 	printsignal(tcp->u_arg[2]);
097fad
 
097fad
@@ -624,7 +629,8 @@
097fad
 
097fad
 SYS_FUNC(rt_sigqueueinfo)
097fad
 {
097fad
-	tprintf("%d, ", (int) tcp->u_arg[0]);
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+	tprints(", ");
097fad
 	print_sigqueueinfo(tcp, tcp->u_arg[1], tcp->u_arg[2]);
097fad
 
097fad
 	return RVAL_DECODED;
097fad
@@ -632,7 +638,10 @@
097fad
 
097fad
 SYS_FUNC(rt_tgsigqueueinfo)
097fad
 {
097fad
-	tprintf("%d, %d, ", (int) tcp->u_arg[0], (int) tcp->u_arg[1]);
097fad
+	printpid(tcp, tcp->u_arg[0], PT_TGID);
097fad
+	tprints(", ");
097fad
+	printpid(tcp, tcp->u_arg[1], PT_TID);
097fad
+	tprints(", ");
097fad
 	print_sigqueueinfo(tcp, tcp->u_arg[2], tcp->u_arg[3]);
097fad
 
097fad
 	return RVAL_DECODED;
097fad
Index: strace-5.7/sockaddr.c
097fad
===================================================================
097fad
--- strace-5.7.orig/sockaddr.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/sockaddr.c	2020-09-09 15:55:03.984108300 +0200
097fad
@@ -416,7 +416,7 @@
097fad
 {
097fad
 	const struct sockaddr_nl *const sa_nl = buf;
097fad
 
097fad
-	PRINT_FIELD_D("", *sa_nl, nl_pid);
097fad
+	PRINT_FIELD_TGID("", *sa_nl, nl_pid, tcp);
097fad
 	PRINT_FIELD_0X(", ", *sa_nl, nl_groups);
097fad
 }
097fad
 
097fad
Index: strace-5.7/tests/kcmp.c
097fad
===================================================================
097fad
--- strace-5.7.orig/tests/kcmp.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/tests/kcmp.c	2020-09-09 18:49:06.780401433 +0200
097fad
@@ -64,7 +64,26 @@
097fad
 static void
097fad
 printpidfd(const char *prefix, pid_t pid, unsigned fd)
097fad
 {
097fad
-	printf("%s%d", prefix, fd);
097fad
+	const char *path = NULL;
097fad
+
097fad
+# if VERBOSE_FD
097fad
+	if (pid == getpid()) {
097fad
+		switch (fd)
097fad
+		{
097fad
+		case NULL_FD:
097fad
+			path = null_path;
097fad
+			break;
097fad
+		case ZERO_FD:
097fad
+			path = zero_path;
097fad
+			break;
097fad
+		}
097fad
+	}
097fad
+# endif
097fad
+
097fad
+	if (path)
097fad
+		printf("%s%d<%s>", prefix, fd, path);
097fad
+	else
097fad
+		printf("%s%d", prefix, fd);
097fad
 }
097fad
 
097fad
 /*
097fad
@@ -179,7 +198,7 @@
097fad
 	/* KCMP_FILE is the only type which has additional args */
097fad
 	do_kcmp(3141592653U, 2718281828U, ARG_STR(KCMP_FILE), bogus_idx1,
097fad
 		bogus_idx2);
097fad
-	do_kcmp(-1, -1, ARG_STR(KCMP_FILE), NULL_FD, ZERO_FD);
097fad
+	do_kcmp(getpid(), getpid(), ARG_STR(KCMP_FILE), NULL_FD, ZERO_FD);
097fad
 
097fad
 	/* Types without additional args */
097fad
 	do_kcmp(-1, -1, ARG_STR(KCMP_VM), bogus_idx1, bogus_idx2);
097fad
@@ -198,7 +217,7 @@
097fad
 	for (i = 0; i < ARRAY_SIZE(slot_data); i++) {
097fad
 		memcpy(slot, slot_data + i, sizeof(*slot));
097fad
 
097fad
-		do_kcmp(getpid(), getppid(), ARG_STR(KCMP_EPOLL_TFD), NULL_FD,
097fad
+		do_kcmp(getpid(), -1, ARG_STR(KCMP_EPOLL_TFD), NULL_FD,
097fad
 			(uintptr_t) slot, 1);
097fad
 	}
097fad
 
097fad
Index: strace-5.7/util.c
097fad
===================================================================
097fad
--- strace-5.7.orig/util.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/util.c	2020-09-09 18:49:07.951402131 +0200
097fad
@@ -392,6 +392,18 @@
097fad
 	return true;
097fad
 }
097fad
 
097fad
+bool
097fad
+printnum_pid(struct tcb *const tcp, const kernel_ulong_t addr, enum pid_type type)
097fad
+{
097fad
+	int pid;
097fad
+	if (umove_or_printaddr(tcp, addr, &pid))
097fad
+		return false;
097fad
+	tprints("[");
097fad
+	printpid(tcp, pid, type);
097fad
+	tprints("]");
097fad
+	return true;
097fad
+}
097fad
+
097fad
 /**
097fad
  * Prints time to a (static internal) buffer and returns pointer to it.
097fad
  * Returns NULL if the provided time specification is not correct.
097fad
@@ -616,7 +628,7 @@
097fad
 printfd_pid(struct tcb *tcp, pid_t pid, int fd)
097fad
 {
097fad
 	char path[PATH_MAX + 1];
097fad
-	if (!number_set_array_is_empty(decode_fd_set, 0)
097fad
+	if (pid > 0 && !number_set_array_is_empty(decode_fd_set, 0)
097fad
 	    && getfdpath_pid(pid, fd, path, sizeof(path)) >= 0) {
097fad
 		tprintf("%d<", (int) fd);
097fad
 		if (is_number_in_set(DECODE_FD_SOCKET, decode_fd_set) &&
097fad
@@ -641,12 +653,8 @@
097fad
 void
097fad
 printfd_pid_tracee_ns(struct tcb *tcp, pid_t pid, int fd)
097fad
 {
097fad
-	/*
097fad
-	 * TODO: We want to have the same formatting as printfd here,
097fad
-	 *       but we should figure out first which process in strace's
097fad
-	 *       PID NS is referred to by pid in tracee's PID NS.
097fad
-	 */
097fad
-	tprintf("%d", fd);
097fad
+	int strace_pid = translate_pid(tcp, pid, PT_TGID, NULL);
097fad
+	printfd_pid(tcp, strace_pid, fd);
097fad
 }
097fad
 
097fad
 /*
097fad
Index: strace-5.7/wait.c
097fad
===================================================================
097fad
--- strace-5.7.orig/wait.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/wait.c	2020-09-09 15:55:03.985108301 +0200
097fad
@@ -80,14 +80,8 @@
097fad
 	   void (*const print_rusage)(struct tcb *, kernel_ulong_t))
097fad
 {
097fad
 	if (entering(tcp)) {
097fad
-		/* On Linux, kernel-side pid_t is typedef'ed to int
097fad
-		 * on all arches. Also, glibc-2.8 truncates wait3 and wait4
097fad
-		 * pid argument to int on 64bit arches, producing,
097fad
-		 * for example, wait4(4294967295, ...) instead of -1
097fad
-		 * in strace. We have to use int here, not long.
097fad
-		 */
097fad
-		int pid = tcp->u_arg[0];
097fad
-		tprintf("%d, ", pid);
097fad
+		printpid_tgid_pgid(tcp, tcp->u_arg[0]);
097fad
+		tprintf(", ");
097fad
 	} else {
097fad
 		int status;
097fad
 
097fad
@@ -108,7 +102,7 @@
097fad
 				printaddr(tcp->u_arg[3]);
097fad
 		}
097fad
 	}
097fad
-	return 0;
097fad
+	return RVAL_TGID;
097fad
 }
097fad
 
097fad
 SYS_FUNC(waitpid)
097fad
@@ -134,10 +128,28 @@
097fad
 
097fad
 SYS_FUNC(waitid)
097fad
 {
097fad
+	unsigned int idtype = (unsigned int) tcp->u_arg[0];
097fad
+	int id = tcp->u_arg[1];
097fad
+
097fad
 	if (entering(tcp)) {
097fad
-		printxval(waitid_types, tcp->u_arg[0], "P_???");
097fad
-		int pid = tcp->u_arg[1];
097fad
-		tprintf(", %d, ", pid);
097fad
+		printxval(waitid_types, idtype, "P_???");
097fad
+		tprints(", ");
097fad
+		switch (idtype)
097fad
+		{
097fad
+		case P_PID:
097fad
+			printpid(tcp, id, PT_TGID);
097fad
+			break;
097fad
+		case P_PIDFD:
097fad
+			printfd(tcp, id);
097fad
+			break;
097fad
+		case P_PGID:
097fad
+			printpid(tcp, id, PT_PGID);
097fad
+			break;
097fad
+		default:
097fad
+			tprintf("%d", id);
097fad
+			break;
097fad
+		}
097fad
+		tprints(", ");
097fad
 	} else {
097fad
 		/* siginfo */
097fad
 		printsiginfo_at(tcp, tcp->u_arg[2]);
097fad
Index: strace-5.7/tests-m32/kcmp.c
097fad
===================================================================
097fad
--- strace-5.7.orig/tests-m32/kcmp.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/tests-m32/kcmp.c	2020-09-09 18:49:06.780401433 +0200
097fad
@@ -64,7 +64,26 @@
097fad
 static void
097fad
 printpidfd(const char *prefix, pid_t pid, unsigned fd)
097fad
 {
097fad
-	printf("%s%d", prefix, fd);
097fad
+	const char *path = NULL;
097fad
+
097fad
+# if VERBOSE_FD
097fad
+	if (pid == getpid()) {
097fad
+		switch (fd)
097fad
+		{
097fad
+		case NULL_FD:
097fad
+			path = null_path;
097fad
+			break;
097fad
+		case ZERO_FD:
097fad
+			path = zero_path;
097fad
+			break;
097fad
+		}
097fad
+	}
097fad
+# endif
097fad
+
097fad
+	if (path)
097fad
+		printf("%s%d<%s>", prefix, fd, path);
097fad
+	else
097fad
+		printf("%s%d", prefix, fd);
097fad
 }
097fad
 
097fad
 /*
097fad
@@ -179,7 +198,7 @@
097fad
 	/* KCMP_FILE is the only type which has additional args */
097fad
 	do_kcmp(3141592653U, 2718281828U, ARG_STR(KCMP_FILE), bogus_idx1,
097fad
 		bogus_idx2);
097fad
-	do_kcmp(-1, -1, ARG_STR(KCMP_FILE), NULL_FD, ZERO_FD);
097fad
+	do_kcmp(getpid(), getpid(), ARG_STR(KCMP_FILE), NULL_FD, ZERO_FD);
097fad
 
097fad
 	/* Types without additional args */
097fad
 	do_kcmp(-1, -1, ARG_STR(KCMP_VM), bogus_idx1, bogus_idx2);
097fad
@@ -198,7 +217,7 @@
097fad
 	for (i = 0; i < ARRAY_SIZE(slot_data); i++) {
097fad
 		memcpy(slot, slot_data + i, sizeof(*slot));
097fad
 
097fad
-		do_kcmp(getpid(), getppid(), ARG_STR(KCMP_EPOLL_TFD), NULL_FD,
097fad
+		do_kcmp(getpid(), -1, ARG_STR(KCMP_EPOLL_TFD), NULL_FD,
097fad
 			(uintptr_t) slot, 1);
097fad
 	}
097fad
 
097fad
Index: strace-5.7/tests-mx32/kcmp.c
097fad
===================================================================
097fad
--- strace-5.7.orig/tests-mx32/kcmp.c	2020-09-09 15:52:09.159983257 +0200
097fad
+++ strace-5.7/tests-mx32/kcmp.c	2020-09-09 18:49:06.780401433 +0200
097fad
@@ -64,7 +64,26 @@
097fad
 static void
097fad
 printpidfd(const char *prefix, pid_t pid, unsigned fd)
097fad
 {
097fad
-	printf("%s%d", prefix, fd);
097fad
+	const char *path = NULL;
097fad
+
097fad
+# if VERBOSE_FD
097fad
+	if (pid == getpid()) {
097fad
+		switch (fd)
097fad
+		{
097fad
+		case NULL_FD:
097fad
+			path = null_path;
097fad
+			break;
097fad
+		case ZERO_FD:
097fad
+			path = zero_path;
097fad
+			break;
097fad
+		}
097fad
+	}
097fad
+# endif
097fad
+
097fad
+	if (path)
097fad
+		printf("%s%d<%s>", prefix, fd, path);
097fad
+	else
097fad
+		printf("%s%d", prefix, fd);
097fad
 }
097fad
 
097fad
 /*
097fad
@@ -179,7 +198,7 @@
097fad
 	/* KCMP_FILE is the only type which has additional args */
097fad
 	do_kcmp(3141592653U, 2718281828U, ARG_STR(KCMP_FILE), bogus_idx1,
097fad
 		bogus_idx2);
097fad
-	do_kcmp(-1, -1, ARG_STR(KCMP_FILE), NULL_FD, ZERO_FD);
097fad
+	do_kcmp(getpid(), getpid(), ARG_STR(KCMP_FILE), NULL_FD, ZERO_FD);
097fad
 
097fad
 	/* Types without additional args */
097fad
 	do_kcmp(-1, -1, ARG_STR(KCMP_VM), bogus_idx1, bogus_idx2);
097fad
@@ -198,7 +217,7 @@
097fad
 	for (i = 0; i < ARRAY_SIZE(slot_data); i++) {
097fad
 		memcpy(slot, slot_data + i, sizeof(*slot));
097fad
 
097fad
-		do_kcmp(getpid(), getppid(), ARG_STR(KCMP_EPOLL_TFD), NULL_FD,
097fad
+		do_kcmp(getpid(), -1, ARG_STR(KCMP_EPOLL_TFD), NULL_FD,
097fad
 			(uintptr_t) slot, 1);
097fad
 	}
097fad
 
097fad
Index: strace-5.7/Makefile.in
097fad
===================================================================
097fad
--- strace-5.7.orig/Makefile.in	2020-09-09 15:54:59.569105143 +0200
097fad
+++ strace-5.7/Makefile.in	2020-09-09 19:06:15.159014394 +0200
097fad
@@ -322,13 +322,13 @@
097fad
 	flock.c flock.h fs_x_ioctl.c fsconfig.c fsmount.c fsopen.c \
097fad
 	fspick.c fstatfs.c fstatfs64.c futex.c gcc_compat.h \
097fad
 	get_personality.c get_personality.h get_robust_list.c getcpu.c \
097fad
-	getcwd.c getpagesize.c getrandom.c hdio.c hostname.c inotify.c \
097fad
-	inotify_ioctl.c io.c io_uring.c ioctl.c ioperm.c iopl.c \
097fad
-	ioprio.c ipc.c ipc_defs.h ipc_msg.c ipc_msgctl.c ipc_sem.c \
097fad
-	ipc_shm.c ipc_shmctl.c kcmp.c kernel_dirent.h kernel_rusage.h \
097fad
-	kernel_timespec.h kernel_timeval.h kernel_timex.h \
097fad
-	kernel_types.h kernel_v4l2_types.h kexec.c keyctl.c \
097fad
-	keyctl_kdf_params.h kill_save_errno.h kvm.c \
097fad
+	getcwd.c getpagesize.c getpid.c getrandom.c hdio.c hostname.c \
097fad
+	inotify.c inotify_ioctl.c io.c io_uring.c ioctl.c ioperm.c \
097fad
+	iopl.c ioprio.c ipc.c ipc_defs.h ipc_msg.c ipc_msgctl.c \
097fad
+	ipc_sem.c ipc_shm.c ipc_shmctl.c kcmp.c kernel_dirent.h \
097fad
+	kernel_rusage.h kernel_timespec.h kernel_timeval.h \
097fad
+	kernel_timex.h kernel_types.h kernel_v4l2_types.h kexec.c \
097fad
+	keyctl.c keyctl_kdf_params.h kill_save_errno.h kvm.c \
097fad
 	largefile_wrappers.h ldt.c link.c linux/asm_stat.h \
097fad
 	linux/x32/asm_stat.h linux/x86_64/asm_stat.h list.h listen.c \
097fad
 	lookup_dcookie.c loop.c lseek.c macros.h mem.c membarrier.c \
097fad
@@ -443,7 +443,7 @@
097fad
 	libstrace_a-get_personality.$(OBJEXT) \
097fad
 	libstrace_a-get_robust_list.$(OBJEXT) \
097fad
 	libstrace_a-getcpu.$(OBJEXT) libstrace_a-getcwd.$(OBJEXT) \
097fad
-	libstrace_a-getpagesize.$(OBJEXT) \
097fad
+	libstrace_a-getpagesize.$(OBJEXT) libstrace_a-getpid.$(OBJEXT) \
097fad
 	libstrace_a-getrandom.$(OBJEXT) libstrace_a-hdio.$(OBJEXT) \
097fad
 	libstrace_a-hostname.$(OBJEXT) libstrace_a-inotify.$(OBJEXT) \
097fad
 	libstrace_a-inotify_ioctl.$(OBJEXT) libstrace_a-io.$(OBJEXT) \
097fad
@@ -769,6 +769,7 @@
097fad
 	./$(DEPDIR)/libstrace_a-getcpu.Po \
097fad
 	./$(DEPDIR)/libstrace_a-getcwd.Po \
097fad
 	./$(DEPDIR)/libstrace_a-getpagesize.Po \
097fad
+	./$(DEPDIR)/libstrace_a-getpid.Po \
097fad
 	./$(DEPDIR)/libstrace_a-getrandom.Po \
097fad
 	./$(DEPDIR)/libstrace_a-hdio.Po \
097fad
 	./$(DEPDIR)/libstrace_a-hostname.Po \
097fad
@@ -1810,13 +1811,13 @@
097fad
 	flock.c flock.h fs_x_ioctl.c fsconfig.c fsmount.c fsopen.c \
097fad
 	fspick.c fstatfs.c fstatfs64.c futex.c gcc_compat.h \
097fad
 	get_personality.c get_personality.h get_robust_list.c getcpu.c \
097fad
-	getcwd.c getpagesize.c getrandom.c hdio.c hostname.c inotify.c \
097fad
-	inotify_ioctl.c io.c io_uring.c ioctl.c ioperm.c iopl.c \
097fad
-	ioprio.c ipc.c ipc_defs.h ipc_msg.c ipc_msgctl.c ipc_sem.c \
097fad
-	ipc_shm.c ipc_shmctl.c kcmp.c kernel_dirent.h kernel_rusage.h \
097fad
-	kernel_timespec.h kernel_timeval.h kernel_timex.h \
097fad
-	kernel_types.h kernel_v4l2_types.h kexec.c keyctl.c \
097fad
-	keyctl_kdf_params.h kill_save_errno.h kvm.c \
097fad
+	getcwd.c getpagesize.c getpid.c getrandom.c hdio.c hostname.c \
097fad
+	inotify.c inotify_ioctl.c io.c io_uring.c ioctl.c ioperm.c \
097fad
+	iopl.c ioprio.c ipc.c ipc_defs.h ipc_msg.c ipc_msgctl.c \
097fad
+	ipc_sem.c ipc_shm.c ipc_shmctl.c kcmp.c kernel_dirent.h \
097fad
+	kernel_rusage.h kernel_timespec.h kernel_timeval.h \
097fad
+	kernel_timex.h kernel_types.h kernel_v4l2_types.h kexec.c \
097fad
+	keyctl.c keyctl_kdf_params.h kill_save_errno.h kvm.c \
097fad
 	largefile_wrappers.h ldt.c link.c linux/asm_stat.h \
097fad
 	linux/x32/asm_stat.h linux/x86_64/asm_stat.h list.h listen.c \
097fad
 	lookup_dcookie.c loop.c lseek.c macros.h mem.c membarrier.c \
097fad
@@ -2835,6 +2836,7 @@
097fad
 @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libstrace_a-getcpu.Po@am__quote@ # am--include-marker
097fad
 @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libstrace_a-getcwd.Po@am__quote@ # am--include-marker
097fad
 @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libstrace_a-getpagesize.Po@am__quote@ # am--include-marker
097fad
+@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libstrace_a-getpid.Po@am__quote@ # am--include-marker
097fad
 @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libstrace_a-getrandom.Po@am__quote@ # am--include-marker
097fad
 @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libstrace_a-hdio.Po@am__quote@ # am--include-marker
097fad
 @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libstrace_a-hostname.Po@am__quote@ # am--include-marker
097fad
@@ -5082,6 +5084,20 @@
097fad
 @AMDEP_TRUE@@am__fastdepCC_FALSE@	DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@
097fad
 @am__fastdepCC_FALSE@	$(AM_V_CC@am__nodep@)$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libstrace_a_CPPFLAGS) $(CPPFLAGS) $(libstrace_a_CFLAGS) $(CFLAGS) -c -o libstrace_a-getpagesize.obj `if test -f 'getpagesize.c'; then $(CYGPATH_W) 'getpagesize.c'; else $(CYGPATH_W) '$(srcdir)/getpagesize.c'; fi`
097fad
 
097fad
+libstrace_a-getpid.o: getpid.c
097fad
+@am__fastdepCC_TRUE@	$(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libstrace_a_CPPFLAGS) $(CPPFLAGS) $(libstrace_a_CFLAGS) $(CFLAGS) -MT libstrace_a-getpid.o -MD -MP -MF $(DEPDIR)/libstrace_a-getpid.Tpo -c -o libstrace_a-getpid.o `test -f 'getpid.c' || echo '$(srcdir)/'`getpid.c
097fad
+@am__fastdepCC_TRUE@	$(AM_V_at)$(am__mv) $(DEPDIR)/libstrace_a-getpid.Tpo $(DEPDIR)/libstrace_a-getpid.Po
097fad
+@AMDEP_TRUE@@am__fastdepCC_FALSE@	$(AM_V_CC)source='getpid.c' object='libstrace_a-getpid.o' libtool=no @AMDEPBACKSLASH@
097fad
+@AMDEP_TRUE@@am__fastdepCC_FALSE@	DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@
097fad
+@am__fastdepCC_FALSE@	$(AM_V_CC@am__nodep@)$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libstrace_a_CPPFLAGS) $(CPPFLAGS) $(libstrace_a_CFLAGS) $(CFLAGS) -c -o libstrace_a-getpid.o `test -f 'getpid.c' || echo '$(srcdir)/'`getpid.c
097fad
+
097fad
+libstrace_a-getpid.obj: getpid.c
097fad
+@am__fastdepCC_TRUE@	$(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libstrace_a_CPPFLAGS) $(CPPFLAGS) $(libstrace_a_CFLAGS) $(CFLAGS) -MT libstrace_a-getpid.obj -MD -MP -MF $(DEPDIR)/libstrace_a-getpid.Tpo -c -o libstrace_a-getpid.obj `if test -f 'getpid.c'; then $(CYGPATH_W) 'getpid.c'; else $(CYGPATH_W) '$(srcdir)/getpid.c'; fi`
097fad
+@am__fastdepCC_TRUE@	$(AM_V_at)$(am__mv) $(DEPDIR)/libstrace_a-getpid.Tpo $(DEPDIR)/libstrace_a-getpid.Po
097fad
+@AMDEP_TRUE@@am__fastdepCC_FALSE@	$(AM_V_CC)source='getpid.c' object='libstrace_a-getpid.obj' libtool=no @AMDEPBACKSLASH@
097fad
+@AMDEP_TRUE@@am__fastdepCC_FALSE@	DEPDIR=$(DEPDIR) $(CCDEPMODE) $(depcomp) @AMDEPBACKSLASH@
097fad
+@am__fastdepCC_FALSE@	$(AM_V_CC@am__nodep@)$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libstrace_a_CPPFLAGS) $(CPPFLAGS) $(libstrace_a_CFLAGS) $(CFLAGS) -c -o libstrace_a-getpid.obj `if test -f 'getpid.c'; then $(CYGPATH_W) 'getpid.c'; else $(CYGPATH_W) '$(srcdir)/getpid.c'; fi`
097fad
+
097fad
 libstrace_a-getrandom.o: getrandom.c
097fad
 @am__fastdepCC_TRUE@	$(AM_V_CC)$(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libstrace_a_CPPFLAGS) $(CPPFLAGS) $(libstrace_a_CFLAGS) $(CFLAGS) -MT libstrace_a-getrandom.o -MD -MP -MF $(DEPDIR)/libstrace_a-getrandom.Tpo -c -o libstrace_a-getrandom.o `test -f 'getrandom.c' || echo '$(srcdir)/'`getrandom.c
097fad
 @am__fastdepCC_TRUE@	$(AM_V_at)$(am__mv) $(DEPDIR)/libstrace_a-getrandom.Tpo $(DEPDIR)/libstrace_a-getrandom.Po
097fad
@@ -8377,6 +8393,7 @@
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-getcpu.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-getcwd.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-getpagesize.Po
097fad
+	-rm -f ./$(DEPDIR)/libstrace_a-getpid.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-getrandom.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-hdio.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-hostname.Po
097fad
@@ -8764,6 +8781,7 @@
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-getcpu.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-getcwd.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-getpagesize.Po
097fad
+	-rm -f ./$(DEPDIR)/libstrace_a-getpid.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-getrandom.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-hdio.Po
097fad
 	-rm -f ./$(DEPDIR)/libstrace_a-hostname.Po