|
 |
6b5f7a |
From 21fd7a71d28847103921036595e0dbeac125aa44 Mon Sep 17 00:00:00 2001
|
|
|
6b5f7a |
From: Mark Eggleston <markeggleston@gcc.gnu.org>
|
|
|
6b5f7a |
Date: Mon, 3 Feb 2020 10:56:36 +0000
|
|
|
6b5f7a |
Subject: [PATCH 10/10] Fill in missing array dimensions using the lower bound
|
|
|
ca6e07 |
|
|
|
ca6e07 |
Use -fdec-add-missing-indexes to enable feature. Also enabled by fdec.
|
|
|
ca6e07 |
---
|
|
|
ca6e07 |
gcc/fortran/lang.opt | 8 ++++++++
|
|
|
ca6e07 |
gcc/fortran/options.c | 1 +
|
|
|
ca6e07 |
gcc/fortran/resolve.c | 24 ++++++++++++++++++++++++
|
|
|
ca6e07 |
gcc/testsuite/gfortran.dg/array_6.f90 | 23 +++++++++++++++++++++++
|
|
|
ca6e07 |
gcc/testsuite/gfortran.dg/array_7.f90 | 23 +++++++++++++++++++++++
|
|
|
ca6e07 |
gcc/testsuite/gfortran.dg/array_8.f90 | 23 +++++++++++++++++++++++
|
|
|
ca6e07 |
6 files changed, 102 insertions(+)
|
|
|
ca6e07 |
create mode 100644 gcc/testsuite/gfortran.dg/array_6.f90
|
|
|
ca6e07 |
create mode 100644 gcc/testsuite/gfortran.dg/array_7.f90
|
|
|
ca6e07 |
create mode 100644 gcc/testsuite/gfortran.dg/array_8.f90
|
|
|
ca6e07 |
|
|
|
ca6e07 |
diff --git a/gcc/fortran/lang.opt b/gcc/fortran/lang.opt
|
|
|
6b5f7a |
index ca2c0e17350..eb58f00f1c0 100644
|
|
|
ca6e07 |
--- a/gcc/fortran/lang.opt
|
|
|
ca6e07 |
+++ b/gcc/fortran/lang.opt
|
|
|
ca6e07 |
@@ -281,6 +281,10 @@ Wmissing-include-dirs
|
|
|
ca6e07 |
Fortran
|
|
|
ca6e07 |
; Documented in C/C++
|
|
|
ca6e07 |
|
|
|
ca6e07 |
+Wmissing-index
|
|
|
ca6e07 |
+Fortran Var(warn_missing_index) Warning LangEnabledBy(Fortran,Wall)
|
|
|
ca6e07 |
+Warn that the lower bound of a missing index will be used.
|
|
|
ca6e07 |
+
|
|
|
ca6e07 |
Wuse-without-only
|
|
|
ca6e07 |
Fortran Var(warn_use_without_only) Warning
|
|
|
ca6e07 |
Warn about USE statements that have no ONLY qualifier.
|
|
|
6b5f7a |
@@ -456,6 +460,10 @@ fdec
|
|
|
ca6e07 |
Fortran Var(flag_dec)
|
|
|
ca6e07 |
Enable all DEC language extensions.
|
|
|
ca6e07 |
|
|
|
ca6e07 |
+fdec-add-missing-indexes
|
|
|
ca6e07 |
+Fortran Var(flag_dec_add_missing_indexes)
|
|
|
ca6e07 |
+Enable the addition of missing indexes using their lower bounds.
|
|
|
ca6e07 |
+
|
|
|
ca6e07 |
fdec-blank-format-item
|
|
|
ca6e07 |
Fortran Var(flag_dec_blank_format_item)
|
|
|
ca6e07 |
Enable the use of blank format items in format strings.
|
|
|
ca6e07 |
diff --git a/gcc/fortran/options.c b/gcc/fortran/options.c
|
|
|
6b5f7a |
index 9f594c6b4a3..92dd74af21d 100644
|
|
|
ca6e07 |
--- a/gcc/fortran/options.c
|
|
|
ca6e07 |
+++ b/gcc/fortran/options.c
|
|
|
6b5f7a |
@@ -84,6 +84,7 @@ set_dec_flags (int value)
|
|
|
ca6e07 |
SET_BITFLAG (flag_dec_non_logical_if, value, value);
|
|
|
ca6e07 |
SET_BITFLAG (flag_dec_promotion, value, value);
|
|
|
ca6e07 |
SET_BITFLAG (flag_dec_sequence, value, value);
|
|
|
ca6e07 |
+ SET_BITFLAG (flag_dec_add_missing_indexes, value, value);
|
|
|
ca6e07 |
}
|
|
|
ca6e07 |
|
|
|
ca6e07 |
/* Finalize DEC flags. */
|
|
|
ca6e07 |
diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
|
|
|
6b5f7a |
index 10547704455..2818d220975 100644
|
|
|
ca6e07 |
--- a/gcc/fortran/resolve.c
|
|
|
ca6e07 |
+++ b/gcc/fortran/resolve.c
|
|
|
6b5f7a |
@@ -4771,6 +4771,30 @@ compare_spec_to_ref (gfc_array_ref *ar)
|
|
|
ca6e07 |
if (ar->type == AR_FULL)
|
|
|
ca6e07 |
return true;
|
|
|
ca6e07 |
|
|
|
ca6e07 |
+ if (flag_dec_add_missing_indexes && as->rank > ar->dimen)
|
|
|
ca6e07 |
+ {
|
|
|
ca6e07 |
+ /* Add in the missing dimensions, assuming they are the lower bound
|
|
|
ca6e07 |
+ of that dimension if not specified. */
|
|
|
ca6e07 |
+ int j;
|
|
|
ca6e07 |
+ if (warn_missing_index)
|
|
|
ca6e07 |
+ {
|
|
|
ca6e07 |
+ gfc_warning (OPT_Wmissing_index, "Using the lower bound for "
|
|
|
ca6e07 |
+ "unspecified dimensions in array reference at %L",
|
|
|
ca6e07 |
+ &ar->where);
|
|
|
ca6e07 |
+ }
|
|
|
ca6e07 |
+ /* Other parts of the code iterate ar->start and ar->end from 0 to
|
|
|
ca6e07 |
+ ar->dimen, so it is safe to assume slots from ar->dimen upwards
|
|
|
ca6e07 |
+ are unused (i.e. there are no gaps; the specified indexes are
|
|
|
ca6e07 |
+ contiguous and start at zero. */
|
|
|
ca6e07 |
+ for(j = ar->dimen; j <= as->rank; j++)
|
|
|
ca6e07 |
+ {
|
|
|
ca6e07 |
+ ar->start[j] = gfc_copy_expr (as->lower[j]);
|
|
|
ca6e07 |
+ ar->end[j] = gfc_copy_expr (as->lower[j]);
|
|
|
ca6e07 |
+ ar->dimen_type[j] = DIMEN_ELEMENT;
|
|
|
ca6e07 |
+ }
|
|
|
ca6e07 |
+ ar->dimen = as->rank;
|
|
|
ca6e07 |
+ }
|
|
|
ca6e07 |
+
|
|
|
ca6e07 |
if (as->rank != ar->dimen)
|
|
|
ca6e07 |
{
|
|
|
ca6e07 |
gfc_error ("Rank mismatch in array reference at %L (%d/%d)",
|
|
|
ca6e07 |
diff --git a/gcc/testsuite/gfortran.dg/array_6.f90 b/gcc/testsuite/gfortran.dg/array_6.f90
|
|
|
ca6e07 |
new file mode 100644
|
|
|
ca6e07 |
index 00000000000..5c26e18ab3e
|
|
|
ca6e07 |
--- /dev/null
|
|
|
ca6e07 |
+++ b/gcc/testsuite/gfortran.dg/array_6.f90
|
|
|
ca6e07 |
@@ -0,0 +1,23 @@
|
|
|
ca6e07 |
+! { dg-do run }
|
|
|
ca6e07 |
+! { dg-options "-fdec -Wmissing-index" }!
|
|
|
ca6e07 |
+! Checks that under-specified arrays (referencing arrays with fewer
|
|
|
ca6e07 |
+! dimensions than the array spec) generates a warning.
|
|
|
ca6e07 |
+!
|
|
|
ca6e07 |
+! Contributed by Jim MacArthur <jim.macarthur@codethink.co.uk>
|
|
|
ca6e07 |
+! Updated by Mark Eggleston <mark.eggleston@codethink.co.uk>
|
|
|
ca6e07 |
+!
|
|
|
ca6e07 |
+
|
|
|
ca6e07 |
+program under_specified_array
|
|
|
ca6e07 |
+ integer chessboard(8,8)
|
|
|
ca6e07 |
+ integer chessboard3d(8,8,3:5)
|
|
|
ca6e07 |
+ chessboard(3,1) = 5
|
|
|
ca6e07 |
+ chessboard(3,2) = 55
|
|
|
ca6e07 |
+ chessboard3d(4,1,3) = 6
|
|
|
ca6e07 |
+ chessboard3d(4,1,4) = 66
|
|
|
ca6e07 |
+ chessboard3d(4,4,3) = 7
|
|
|
ca6e07 |
+ chessboard3d(4,4,4) = 77
|
|
|
ca6e07 |
+
|
|
|
ca6e07 |
+ if (chessboard(3).ne.5) stop 1 ! { dg-warning "Using the lower bound for unspecified dimensions in array reference" }
|
|
|
ca6e07 |
+ if (chessboard3d(4).ne.6) stop 2 ! { dg-warning "Using the lower bound for unspecified dimensions in array reference" }
|
|
|
ca6e07 |
+ if (chessboard3d(4,4).ne.7) stop 3 ! { dg-warning "Using the lower bound for unspecified dimensions in array reference" }
|
|
|
ca6e07 |
+end program
|
|
|
ca6e07 |
diff --git a/gcc/testsuite/gfortran.dg/array_7.f90 b/gcc/testsuite/gfortran.dg/array_7.f90
|
|
|
ca6e07 |
new file mode 100644
|
|
|
ca6e07 |
index 00000000000..5588a5bd02d
|
|
|
ca6e07 |
--- /dev/null
|
|
|
ca6e07 |
+++ b/gcc/testsuite/gfortran.dg/array_7.f90
|
|
|
ca6e07 |
@@ -0,0 +1,23 @@
|
|
|
ca6e07 |
+! { dg-do run }
|
|
|
ca6e07 |
+! { dg-options "-fdec-add-missing-indexes -Wmissing-index" }!
|
|
|
ca6e07 |
+! Checks that under-specified arrays (referencing arrays with fewer
|
|
|
ca6e07 |
+! dimensions than the array spec) generates a warning.
|
|
|
ca6e07 |
+!
|
|
|
ca6e07 |
+! Contributed by Jim MacArthur <jim.macarthur@codethink.co.uk>
|
|
|
ca6e07 |
+! Updated by Mark Eggleston <mark.eggleston@codethink.co.uk>
|
|
|
ca6e07 |
+!
|
|
|
ca6e07 |
+
|
|
|
ca6e07 |
+program under_specified_array
|
|
|
ca6e07 |
+ integer chessboard(8,8)
|
|
|
ca6e07 |
+ integer chessboard3d(8,8,3:5)
|
|
|
ca6e07 |
+ chessboard(3,1) = 5
|
|
|
ca6e07 |
+ chessboard(3,2) = 55
|
|
|
ca6e07 |
+ chessboard3d(4,1,3) = 6
|
|
|
ca6e07 |
+ chessboard3d(4,1,4) = 66
|
|
|
ca6e07 |
+ chessboard3d(4,4,3) = 7
|
|
|
ca6e07 |
+ chessboard3d(4,4,4) = 77
|
|
|
ca6e07 |
+
|
|
|
ca6e07 |
+ if (chessboard(3).ne.5) stop 1 ! { dg-warning "Using the lower bound for unspecified dimensions in array reference" }
|
|
|
ca6e07 |
+ if (chessboard3d(4).ne.6) stop 2 ! { dg-warning "Using the lower bound for unspecified dimensions in array reference" }
|
|
|
ca6e07 |
+ if (chessboard3d(4,4).ne.7) stop 3 ! { dg-warning "Using the lower bound for unspecified dimensions in array reference" }
|
|
|
ca6e07 |
+end program
|
|
|
ca6e07 |
diff --git a/gcc/testsuite/gfortran.dg/array_8.f90 b/gcc/testsuite/gfortran.dg/array_8.f90
|
|
|
ca6e07 |
new file mode 100644
|
|
|
ca6e07 |
index 00000000000..f0d2ef5e37d
|
|
|
ca6e07 |
--- /dev/null
|
|
|
ca6e07 |
+++ b/gcc/testsuite/gfortran.dg/array_8.f90
|
|
|
ca6e07 |
@@ -0,0 +1,23 @@
|
|
|
ca6e07 |
+! { dg-do compile }
|
|
|
ca6e07 |
+! { dg-options "-fdec -fno-dec-add-missing-indexes" }!
|
|
|
ca6e07 |
+! Checks that under-specified arrays (referencing arrays with fewer
|
|
|
ca6e07 |
+! dimensions than the array spec) generates a warning.
|
|
|
ca6e07 |
+!
|
|
|
ca6e07 |
+! Contributed by Jim MacArthur <jim.macarthur@codethink.co.uk>
|
|
|
ca6e07 |
+! Updated by Mark Eggleston <mark.eggleston@codethink.co.uk>
|
|
|
ca6e07 |
+!
|
|
|
ca6e07 |
+
|
|
|
ca6e07 |
+program under_specified_array
|
|
|
ca6e07 |
+ integer chessboard(8,8)
|
|
|
ca6e07 |
+ integer chessboard3d(8,8,3:5)
|
|
|
ca6e07 |
+ chessboard(3,1) = 5
|
|
|
ca6e07 |
+ chessboard(3,2) = 55
|
|
|
ca6e07 |
+ chessboard3d(4,1,3) = 6
|
|
|
ca6e07 |
+ chessboard3d(4,1,4) = 66
|
|
|
ca6e07 |
+ chessboard3d(4,4,3) = 7
|
|
|
ca6e07 |
+ chessboard3d(4,4,4) = 77
|
|
|
ca6e07 |
+
|
|
|
ca6e07 |
+ if (chessboard(3).ne.5) stop 1 ! { dg-error "Rank mismatch" }
|
|
|
ca6e07 |
+ if (chessboard3d(4).ne.6) stop 2 ! { dg-error "Rank mismatch" }
|
|
|
ca6e07 |
+ if (chessboard3d(4,4).ne.7) stop 3 ! { dg-error "Rank mismatch" }
|
|
|
ca6e07 |
+end program
|
|
|
ca6e07 |
--
|
|
|
ca6e07 |
2.11.0
|
|
|
ca6e07 |
|