Blame SOURCES/fontforge-20120731-b-cve-2020-5395.patch

cc3202
diff -urN fontforge-20120731-b.old/fontforge/sfd1.c fontforge-20120731-b/fontforge/sfd1.c
cc3202
--- fontforge-20120731-b.old/fontforge/sfd1.c	2012-08-02 20:39:09.000000000 +0530
cc3202
+++ fontforge-20120731-b/fontforge/sfd1.c	2020-04-08 14:15:27.262285908 +0530
cc3202
@@ -667,7 +667,7 @@
cc3202
 
cc3202
     /* Fix up some gunk from really old versions of the sfd format */
cc3202
     SFDCleanupAnchorClasses(&sf->sf);
cc3202
-    if ( sf->sf.uni_interp==ui_unset )
cc3202
+    if ( sf->sf.uni_interp==ui_unset && sf->sf.map!=NULL )
cc3202
 	sf->sf.uni_interp = interp_from_encoding(sf->sf.map->enc,ui_none);
cc3202
 
cc3202
     /* Fixup for an old bug */
cc3202
diff -urN fontforge-20120731-b.old/fontforge/sfd.c fontforge-20120731-b/fontforge/sfd.c
cc3202
--- fontforge-20120731-b.old/fontforge/sfd.c	2012-08-02 20:39:09.000000000 +0530
cc3202
+++ fontforge-20120731-b/fontforge/sfd.c	2020-04-08 14:16:37.448996390 +0530
cc3202
@@ -3333,13 +3333,16 @@
cc3202
     while ( fscanf(sfd,"%lg %lg %c", &cp.x, &cp.y, &cp.ty )==3 ) {
cc3202
 	if ( cur!=NULL ) {
cc3202
 	    if ( cur->spiro_cnt>=cur->spiro_max )
cc3202
-		cur->spiros = grealloc(cur->spiros,(cur->spiro_max+=10)*sizeof(spiro_cp));
cc3202
+		cur->spiros = realloc(cur->spiros,
cc3202
+		                      (cur->spiro_max+=10)*sizeof(spiro_cp));
cc3202
 	    cur->spiros[cur->spiro_cnt++] = cp;
cc3202
 	}
cc3202
     }
cc3202
-    if ( cur!=NULL && (cur->spiros[cur->spiro_cnt-1].ty&0x7f)!=SPIRO_END ) {
cc3202
+    if (    cur!=NULL && cur->spiro_cnt>0
cc3202
+         && (cur->spiros[cur->spiro_cnt-1].ty&0x7f)!=SPIRO_END ) {
cc3202
 	if ( cur->spiro_cnt>=cur->spiro_max )
cc3202
-	    cur->spiros = grealloc(cur->spiros,(cur->spiro_max+=1)*sizeof(spiro_cp));
cc3202
+	    cur->spiros = realloc(cur->spiros,
cc3202
+	                          (cur->spiro_max+=1)*sizeof(spiro_cp));
cc3202
 	memset(&cur->spiros[cur->spiro_cnt],0,sizeof(spiro_cp));
cc3202
 	cur->spiros[cur->spiro_cnt++].ty = SPIRO_END;
cc3202
     }
cc3202
@@ -6611,8 +6614,10 @@
cc3202
 	    sf->grid.order2 = o2;
cc3202
 	} else if ( strmatch(tok,"LayerCount:")==0 ) {
cc3202
 	    had_layer_cnt = true;
cc3202
-	    getint(sfd,&sf->layer_cnt);
cc3202
-	    if ( sf->layer_cnt>2 ) {
cc3202
+	    int layer_cnt_tmp;
cc3202
+	    getint(sfd,&layer_cnt_tmp);
cc3202
+	    if ( layer_cnt_tmp>2 ) {
cc3202
+	        sf->layer_cnt = layer_cnt_tmp;
cc3202
 		sf->layers = grealloc(sf->layers,sf->layer_cnt*sizeof(LayerInfo));
cc3202
 		memset(sf->layers+2,0,(sf->layer_cnt-2)*sizeof(LayerInfo));
cc3202
 	    }
cc3202
@@ -7227,6 +7232,10 @@
cc3202
 	}
cc3202
     }
cc3202
 
cc3202
+    // Many downstream functions assume this isn't NULL (use strlen, etc.)
cc3202
+    if ( sf->fontname==NULL)
cc3202
+	sf->fontname = copy("");
cc3202
+
cc3202
     if ( fromdir )
cc3202
 	sf = SFD_FigureDirType(sf,tok,dirname,enc,remap,had_layer_cnt);
cc3202
     else if ( sf->subfontcnt!=0 ) {