Blame SOURCES/fapolicyd-trust.patch

037a42
From c7d409cebf86b1c71192fd79ec5f5582f4f00f30 Mon Sep 17 00:00:00 2001
037a42
From: Radovan Sroka <rsroka@redhat.com>
037a42
Date: Tue, 2 Jun 2020 21:24:28 +0200
037a42
Subject: [PATCH] Ignore db errors from check_trust_database() (#70)
037a42
037a42
- mark every subject and object as not trusted
037a42
  when it is not possible to do a query
037a42
037a42
- previously, when error occurred then subject or
037a42
  object was actually considered to be trusted
037a42
037a42
Signed-off-by: Radovan Sroka <rsroka@redhat.com>
037a42
---
037a42
 src/library/event.c | 23 +++++++++++++++++------
037a42
 1 file changed, 17 insertions(+), 6 deletions(-)
037a42
037a42
diff --git a/src/library/event.c b/src/library/event.c
037a42
index 564c120..2a4083b 100644
037a42
--- a/src/library/event.c
037a42
+++ b/src/library/event.c
037a42
@@ -339,9 +339,15 @@ subject_attr_t *get_subj_attr(event_t *e, subject_type_t t)
037a42
 
037a42
 			subj.val = 0;
037a42
 			if (exe) {
037a42
-				if (exe->str && check_trust_database(exe->str,
037a42
-								     NULL, 0))
037a42
-					subj.val = 1;
037a42
+				if (exe->str) {
037a42
+					int res = check_trust_database(exe->str, NULL, 0);
037a42
+
037a42
+					// ignore -1
037a42
+					if (res == 1)
037a42
+						subj.val = 1;
037a42
+					else
037a42
+						subj.val = 0;
037a42
+				}
037a42
 			}
037a42
 			}
037a42
 			break;
037a42
@@ -422,10 +428,15 @@ object_attr_t *get_obj_attr(event_t *e, object_type_t t)
037a42
 		case OBJ_TRUST: {
037a42
 			object_attr_t *path =  get_obj_attr(e, PATH);
037a42
 
037a42
-			if (path && path->o && check_trust_database(path->o,
037a42
-							    o->info, e->fd))
037a42
-			obj.val = 1;
037a42
+			if (path && path->o) {
037a42
+				int res = check_trust_database(path->o, o->info, e->fd);
037a42
 
037a42
+				// ignore -1
037a42
+				if (res == 1)
037a42
+					obj.val = 1;
037a42
+				else
037a42
+					obj.val = 0;
037a42
+			}
037a42
 			}
037a42
 			break;
037a42
 		case FMODE: