|
 |
c96cf6 |
From ef1675823905ff09cb5e551700a124d0133648b7 Mon Sep 17 00:00:00 2001
|
|
|
c96cf6 |
From: Michal Kubecek <mkubecek@suse.cz>
|
|
|
c96cf6 |
Date: Mon, 9 Nov 2020 13:30:54 +0100
|
|
|
c96cf6 |
Subject: [PATCH 23/26] netlink: fix use after free in netlink_run_handler()
|
|
|
c96cf6 |
|
|
|
c96cf6 |
Valgrind detected use after free in netlink_run_handler(): some members of
|
|
|
c96cf6 |
struct nl_context are accessed after the netlink context is freed by
|
|
|
c96cf6 |
netlink_done(). Use local variables to store the two flags and check them
|
|
|
c96cf6 |
instead.
|
|
|
c96cf6 |
|
|
|
c96cf6 |
Fixes: 6c19c0d559c8 ("netlink: use genetlink ops information to decide about fallback")
|
|
|
c96cf6 |
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
|
|
|
c96cf6 |
(cherry picked from commit 29b38ea218bd978d1950e12cc24da98215a1eeef)
|
|
|
c96cf6 |
---
|
|
|
c96cf6 |
netlink/netlink.c | 10 +++++++---
|
|
|
c96cf6 |
1 file changed, 7 insertions(+), 3 deletions(-)
|
|
|
c96cf6 |
|
|
|
c96cf6 |
diff --git a/netlink/netlink.c b/netlink/netlink.c
|
|
|
c96cf6 |
index 86dc1efdf5ce..2a12bb8b1759 100644
|
|
|
c96cf6 |
--- a/netlink/netlink.c
|
|
|
c96cf6 |
+++ b/netlink/netlink.c
|
|
|
c96cf6 |
@@ -303,6 +303,7 @@ void netlink_run_handler(struct cmd_context *ctx, nl_func_t nlfunc,
|
|
|
c96cf6 |
bool no_fallback)
|
|
|
c96cf6 |
{
|
|
|
c96cf6 |
bool wildcard = ctx->devname && !strcmp(ctx->devname, WILDCARD_DEVNAME);
|
|
|
c96cf6 |
+ bool wildcard_unsupported, ioctl_fallback;
|
|
|
c96cf6 |
struct nl_context *nlctx;
|
|
|
c96cf6 |
const char *reason;
|
|
|
c96cf6 |
int ret;
|
|
|
c96cf6 |
@@ -324,14 +325,17 @@ void netlink_run_handler(struct cmd_context *ctx, nl_func_t nlfunc,
|
|
|
c96cf6 |
nlctx = ctx->nlctx;
|
|
|
c96cf6 |
|
|
|
c96cf6 |
ret = nlfunc(ctx);
|
|
|
c96cf6 |
+ wildcard_unsupported = nlctx->wildcard_unsupported;
|
|
|
c96cf6 |
+ ioctl_fallback = nlctx->ioctl_fallback;
|
|
|
c96cf6 |
netlink_done(ctx);
|
|
|
c96cf6 |
- if (no_fallback || ret != -EOPNOTSUPP || !nlctx->ioctl_fallback) {
|
|
|
c96cf6 |
- if (nlctx->wildcard_unsupported)
|
|
|
c96cf6 |
+
|
|
|
c96cf6 |
+ if (no_fallback || ret != -EOPNOTSUPP || !ioctl_fallback) {
|
|
|
c96cf6 |
+ if (wildcard_unsupported)
|
|
|
c96cf6 |
fprintf(stderr, "%s\n",
|
|
|
c96cf6 |
"subcommand does not support wildcard dump");
|
|
|
c96cf6 |
exit(ret >= 0 ? ret : 1);
|
|
|
c96cf6 |
}
|
|
|
c96cf6 |
- if (nlctx->wildcard_unsupported)
|
|
|
c96cf6 |
+ if (wildcard_unsupported)
|
|
|
c96cf6 |
reason = "subcommand does not support wildcard dump";
|
|
|
c96cf6 |
else
|
|
|
c96cf6 |
reason = "kernel netlink support for subcommand missing";
|
|
|
c96cf6 |
--
|
|
|
c96cf6 |
2.26.2
|
|
|
c96cf6 |
|