From 9d6316a62b6ab24dfd3cb800841df7fbbdc648ae Mon Sep 17 00:00:00 2001

From: Ido Schimmel <idosch@nvidia.com>

Date: Fri, 1 Oct 2021 18:06:26 +0300

Subject: [PATCH 11/35] sff-8636: Convert if statement to switch-case

The indentation is wrong and the statement can be more clearly

represented using a switch-case statement. Convert it.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>

---

 qsfp.c | 8 +++++---

 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/qsfp.c b/qsfp.c

index 3401db84352d..d1464cb50fdc 100644

--- a/qsfp.c

+++ b/qsfp.c

@@ -863,11 +863,13 @@ void sff8636_show_all(const __u8 *id, __u32 eeprom_len)

 	}

 	sff8636_show_identifier(id);

-	if ((id[SFF8636_ID_OFFSET] == SFF8024_ID_QSFP) ||

-		(id[SFF8636_ID_OFFSET] == SFF8024_ID_QSFP_PLUS) ||

-		(id[SFF8636_ID_OFFSET] == SFF8024_ID_QSFP28)) {

+	switch (id[SFF8636_ID_OFFSET]) {

+	case SFF8024_ID_QSFP:

+	case SFF8024_ID_QSFP_PLUS:

+	case SFF8024_ID_QSFP28:

 		sff8636_show_page_zero(id);

 		sff8636_show_dom(id, id + 3 * 0x80, eeprom_len);

+		break;

 	}

 }

-- 

2.35.1