|
 |
0ef434 |
From 2ab3543e3b3330317769adcbe4bdb2f3c0b855e9 Mon Sep 17 00:00:00 2001
|
|
|
0ef434 |
From: "Darrick J. Wong" <darrick.wong@oracle.com>
|
|
|
0ef434 |
Date: Thu, 24 Jul 2014 22:19:27 -0400
|
|
|
0ef434 |
Subject: [PATCH 14/16] e2fsck: fix off-by-one bounds check on group number
|
|
|
0ef434 |
|
|
|
0ef434 |
commit b4f724c8a90987d4785fd1accfe69c125567be39
|
|
|
0ef434 |
|
|
|
0ef434 |
Since fs->group_desc_count is the number of block groups, the number
|
|
|
0ef434 |
of the last group is always one less than this count. Fix the bounds
|
|
|
0ef434 |
check to reflect that.
|
|
|
0ef434 |
|
|
|
0ef434 |
This flaw shouldn't have any user-visible side effects, since the
|
|
|
0ef434 |
block bitmap test based on last_grp later on can handle overbig block
|
|
|
0ef434 |
numbers.
|
|
|
0ef434 |
|
|
|
0ef434 |
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
|
|
|
0ef434 |
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
|
|
|
0ef434 |
---
|
|
|
0ef434 |
e2fsck/pass1.c | 4 ++--
|
|
|
0ef434 |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
0ef434 |
|
|
|
0ef434 |
diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c
|
|
|
0ef434 |
index 71b3000a..b58a0ca7 100644
|
|
|
0ef434 |
--- a/e2fsck/pass1.c
|
|
|
0ef434 |
+++ b/e2fsck/pass1.c
|
|
|
0ef434 |
@@ -2599,8 +2599,8 @@ static void new_table_block(e2fsck_t ctx, blk64_t first_block, dgrp_t group,
|
|
|
0ef434 |
first_block = ext2fs_group_first_block2(fs,
|
|
|
0ef434 |
flexbg_size * flexbg);
|
|
|
0ef434 |
last_grp = group | (flexbg_size - 1);
|
|
|
0ef434 |
- if (last_grp > fs->group_desc_count)
|
|
|
0ef434 |
- last_grp = fs->group_desc_count;
|
|
|
0ef434 |
+ if (last_grp >= fs->group_desc_count)
|
|
|
0ef434 |
+ last_grp = fs->group_desc_count - 1;
|
|
|
0ef434 |
last_block = ext2fs_group_last_block2(fs, last_grp);
|
|
|
0ef434 |
} else
|
|
|
0ef434 |
last_block = ext2fs_group_last_block2(fs, group);
|
|
|
0ef434 |
--
|
|
|
0ef434 |
2.20.1
|
|
|
0ef434 |
|