|
 |
b91920 |
From f5302062cbc98b3b8b1002cc48e7125a48ead96c Mon Sep 17 00:00:00 2001
|
|
|
b91920 |
From: Jens Freimann <jfreimann@redhat.com>
|
|
|
b91920 |
Date: Mon, 17 Dec 2018 22:31:38 +0100
|
|
|
b91920 |
Subject: [PATCH 09/18] net/virtio-user: fail if cq used with packed vq
|
|
|
b91920 |
|
|
|
b91920 |
[ upstream commit 07dd7e250d0128bf1edfd73e9d83bde09cdb11e9 ]
|
|
|
b91920 |
|
|
|
b91920 |
Until we have support for control virtqueues let's disable it and
|
|
|
b91920 |
fail device initalization if specified as a parameter.
|
|
|
b91920 |
|
|
|
b91920 |
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
|
|
|
b91920 |
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
|
|
|
b91920 |
(cherry picked from commit 07dd7e250d0128bf1edfd73e9d83bde09cdb11e9)
|
|
|
b91920 |
Signed-off-by: Jens Freimann <jfreimann@redhat.com>
|
|
|
b91920 |
---
|
|
|
b91920 |
drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 ++++++++--
|
|
|
b91920 |
1 file changed, 8 insertions(+), 2 deletions(-)
|
|
|
b91920 |
|
|
|
b91920 |
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
|
|
|
b91920 |
index 77cec1d3c..2f75091d5 100644
|
|
|
b91920 |
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
|
|
|
b91920 |
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
|
|
|
b91920 |
@@ -467,10 +467,16 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,
|
|
|
b91920 |
if (!in_order)
|
|
|
b91920 |
dev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER);
|
|
|
b91920 |
|
|
|
b91920 |
- if (packed_vq)
|
|
|
b91920 |
+ if (packed_vq) {
|
|
|
b91920 |
+ if (cq) {
|
|
|
b91920 |
+ PMD_INIT_LOG(ERR, "control vq not supported yet with "
|
|
|
b91920 |
+ "packed virtqueues\n");
|
|
|
b91920 |
+ return -1;
|
|
|
b91920 |
+ }
|
|
|
b91920 |
dev->device_features |= (1ull << VIRTIO_F_RING_PACKED);
|
|
|
b91920 |
- else
|
|
|
b91920 |
+ } else {
|
|
|
b91920 |
dev->device_features &= ~(1ull << VIRTIO_F_RING_PACKED);
|
|
|
b91920 |
+ }
|
|
|
b91920 |
|
|
|
b91920 |
if (dev->mac_specified) {
|
|
|
b91920 |
dev->device_features |= (1ull << VIRTIO_NET_F_MAC);
|
|
|
b91920 |
--
|
|
|
b91920 |
2.21.0
|
|
|
b91920 |
|