|
 |
9fbc78 |
From fa770c25013df537c41d0929c4202b0a774a6a75 Mon Sep 17 00:00:00 2001
|
|
|
9fbc78 |
From: David Malcolm <dmalcolm@redhat.com>
|
|
|
9fbc78 |
Date: Thu, 2 Sep 2021 15:27:59 -0400
|
|
|
9fbc78 |
Subject: [PATCH 14/17] Conditionalize tests for PR libstdc++/98466 on
|
|
|
9fbc78 |
__LIBSTDCXX_SO_VERSION >= 11
|
|
|
9fbc78 |
|
|
|
9fbc78 |
The tests:
|
|
|
9fbc78 |
23_containers/deque/debug/98466.cc
|
|
|
9fbc78 |
23_containers/unordered_map/debug/98466.cc
|
|
|
9fbc78 |
were added upstream 2021-01-01 as part of:
|
|
|
9fbc78 |
libstdc++: Implement N3644 for _GLIBCXX_DEBUG iterators
|
|
|
9fbc78 |
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=05a30af3f237984b4dcf1dbbc17fdac583c46506
|
|
|
9fbc78 |
but fail when run in DTS against a system libstdc++.so
|
|
|
9fbc78 |
from an older GCC.
|
|
|
9fbc78 |
|
|
|
9fbc78 |
In particular, they use the older implementation of _M_can_compare from
|
|
|
9fbc78 |
the dynamic library:
|
|
|
9fbc78 |
|
|
|
9fbc78 |
$ eu-readelf -s 98466.exe | grep can_compare | c++filt
|
|
|
9fbc78 |
11: 0000000000000000 0 FUNC GLOBAL DEFAULT UNDEF __gnu_debug::_Safe_iterator_base::_M_can_compare(__gnu_debug::_Safe_iterator_base const&) const@GLIBCXX_3.4 (4)
|
|
|
9fbc78 |
157: 0000000000000000 0 FUNC GLOBAL DEFAULT UNDEF __gnu_debug::_Safe_iterator_base::_M_can_compare(__gnu_debug::_Safe_iterator_base const&) const@@GLIBCXX_3.4
|
|
|
9fbc78 |
---
|
|
|
9fbc78 |
.../testsuite/23_containers/deque/debug/98466.cc | 6 ++++++
|
|
|
9fbc78 |
.../23_containers/unordered_map/debug/98466.cc | 12 ++++++++++++
|
|
|
9fbc78 |
2 files changed, 18 insertions(+)
|
|
|
9fbc78 |
|
|
|
9fbc78 |
diff --git a/libstdc++-v3/testsuite/23_containers/deque/debug/98466.cc b/libstdc++-v3/testsuite/23_containers/deque/debug/98466.cc
|
|
|
9fbc78 |
index c2d793374..e92d719bf 100644
|
|
|
9fbc78 |
--- a/libstdc++-v3/testsuite/23_containers/deque/debug/98466.cc
|
|
|
9fbc78 |
+++ b/libstdc++-v3/testsuite/23_containers/deque/debug/98466.cc
|
|
|
9fbc78 |
@@ -26,11 +26,17 @@ void test01()
|
|
|
9fbc78 |
{
|
|
|
9fbc78 |
typedef typename __gnu_debug::deque<int>::iterator It;
|
|
|
9fbc78 |
It it = It();
|
|
|
9fbc78 |
+ // Fixed upstream in GCC 11
|
|
|
9fbc78 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
9fbc78 |
VERIFY( it == it );
|
|
|
9fbc78 |
+#endif
|
|
|
9fbc78 |
|
|
|
9fbc78 |
typedef typename __gnu_debug::deque<int>::const_iterator Cit;
|
|
|
9fbc78 |
Cit cit = Cit();
|
|
|
9fbc78 |
+ // Fixed upstream in GCC 11
|
|
|
9fbc78 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
9fbc78 |
VERIFY( cit == cit );
|
|
|
9fbc78 |
+#endif
|
|
|
9fbc78 |
}
|
|
|
9fbc78 |
|
|
|
9fbc78 |
int main()
|
|
|
9fbc78 |
diff --git a/libstdc++-v3/testsuite/23_containers/unordered_map/debug/98466.cc b/libstdc++-v3/testsuite/23_containers/unordered_map/debug/98466.cc
|
|
|
9fbc78 |
index cc22b9ff8..3a1b6cd32 100644
|
|
|
9fbc78 |
--- a/libstdc++-v3/testsuite/23_containers/unordered_map/debug/98466.cc
|
|
|
9fbc78 |
+++ b/libstdc++-v3/testsuite/23_containers/unordered_map/debug/98466.cc
|
|
|
9fbc78 |
@@ -25,16 +25,28 @@
|
|
|
9fbc78 |
void test01()
|
|
|
9fbc78 |
{
|
|
|
9fbc78 |
__gnu_debug::unordered_map<int, int>::iterator it{};
|
|
|
9fbc78 |
+ // Fixed upstream in GCC 11
|
|
|
9fbc78 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
9fbc78 |
VERIFY( it == it );
|
|
|
9fbc78 |
+#endif
|
|
|
9fbc78 |
|
|
|
9fbc78 |
__gnu_debug::unordered_map<int, int>::const_iterator cit{};
|
|
|
9fbc78 |
+ // Fixed upstream in GCC 11
|
|
|
9fbc78 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
9fbc78 |
VERIFY( cit == cit );
|
|
|
9fbc78 |
+#endif
|
|
|
9fbc78 |
|
|
|
9fbc78 |
__gnu_debug::unordered_map<int, int>::local_iterator lit{};
|
|
|
9fbc78 |
+ // Fixed upstream in GCC 11
|
|
|
9fbc78 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
9fbc78 |
VERIFY( lit == lit );
|
|
|
9fbc78 |
+#endif
|
|
|
9fbc78 |
|
|
|
9fbc78 |
__gnu_debug::unordered_map<int, int>::const_local_iterator clit{};
|
|
|
9fbc78 |
+ // Fixed upstream in GCC 11
|
|
|
9fbc78 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
9fbc78 |
VERIFY( clit == clit );
|
|
|
9fbc78 |
+#endif
|
|
|
9fbc78 |
}
|
|
|
9fbc78 |
|
|
|
9fbc78 |
int main()
|
|
|
9fbc78 |
--
|
|
|
9fbc78 |
2.31.1
|
|
|
9fbc78 |
|