diff --git a/.devtoolset-11-annobin.metadata b/.devtoolset-11-annobin.metadata new file mode 100644 index 0000000..e6cacbb --- /dev/null +++ b/.devtoolset-11-annobin.metadata @@ -0,0 +1 @@ +f0d71fa93ca2f7f8a32e7afcbd5c7bd8e5f93247 SOURCES/annobin-9.82.tar.xz diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..13e8289 --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +SOURCES/annobin-9.82.tar.xz diff --git a/SOURCES/annocheck-not-build-with-plugin.patch b/SOURCES/annocheck-not-build-with-plugin.patch new file mode 100644 index 0000000..fb58258 --- /dev/null +++ b/SOURCES/annocheck-not-build-with-plugin.patch @@ -0,0 +1,21 @@ +diff -rup annobin.orig/annocheck/Makefile.am annobin-9.79/annocheck/Makefile.am +--- annobin.orig/annocheck/Makefile.am 2021-06-30 11:19:38.433482007 +0100 ++++ annobin-9.79/annocheck/Makefile.am 2021-06-30 11:20:52.090009873 +0100 +@@ -9,4 +9,4 @@ bin_PROGRAMS = annocheck + annocheck_SOURCES = annocheck.c timing.c size.c notes.c hardened.c built-by.c annocheck.h ../annobin-global.h + annocheck_LDADD = -lelf -ldw $(RPMLIBS) -liberty $(LIBDEBUGINFOD) + annocheck_LDFLAGS = -Wl,-z,now +-annocheck_CFLAGS = -O2 -ansi -g -Wall -Werror -fpie -D_FORTIFY_SOURCE=2 -fplugin=annobin -fstack-protector-strong ++annocheck_CFLAGS = -O2 -ansi -g -Wall -Werror -fpie -D_FORTIFY_SOURCE=2 -fstack-protector-strong +diff -rup annobin.orig/annocheck/Makefile.in annobin-9.79/annocheck/Makefile.in +--- annobin.orig/annocheck/Makefile.in 2021-06-30 11:19:38.433482007 +0100 ++++ annobin-9.79/annocheck/Makefile.in 2021-06-30 11:20:59.770960639 +0100 +@@ -334,7 +334,7 @@ AUTOMAKE_OPTIONS = no-dependencies + annocheck_SOURCES = annocheck.c timing.c size.c notes.c hardened.c built-by.c annocheck.h ../annobin-global.h + annocheck_LDADD = -lelf -ldw $(RPMLIBS) -liberty $(LIBDEBUGINFOD) + annocheck_LDFLAGS = -Wl,-z,now +-annocheck_CFLAGS = -O2 -ansi -g -Wall -Werror -fpie -D_FORTIFY_SOURCE=2 -fplugin=annobin -fstack-protector-strong ++annocheck_CFLAGS = -O2 -ansi -g -Wall -Werror -fpie -D_FORTIFY_SOURCE=2 -fstack-protector-strong + all: all-am + + .SUFFIXES: diff --git a/SPECS/annobin.spec b/SPECS/annobin.spec new file mode 100644 index 0000000..546c150 --- /dev/null +++ b/SPECS/annobin.spec @@ -0,0 +1,1103 @@ + +%define __python /opt/rh/gcc-toolset-10/root/usr/bin/python3 +%{?scl:%scl_package annobin} + +Name: %{?scl_prefix}annobin +Summary: Annotate and examine compiled binary files +Version: 9.82 +Release: 1%{?dist} +License: GPLv3+ +# Maintainer: nickc@redhat.com +# Web Page: https://sourceware.org/annobin/ +# Watermark Protocol: https://fedoraproject.org/wiki/Toolchain/Watermark + +#--------------------------------------------------------------------------------- + +# Use "--without tests" to disable the testsuite. +%bcond_without tests + +# Use "--without annocheck" to disable the installation of the annocheck program. +%bcond_without annocheck + +# Use "--with debuginfod" to force support for debuginfod to be compiled into +# the annocheck program. By default the configure script will check for +# availablilty at build time, but this might not match the run time situation. +# FIXME: Add a --without debuginfod option to forcefully disable the configure +# time check for debuginfod support. +%bcond_with debuginfod + +# Use "--with clangplugin" to enable the building of the annobin plugin for Clang. +%bcond_with clangplugin + +# Use "--without gccplugin" to disable the building of the annobin plugin for GCC. +%bcond_without gccplugin + +# Use "--with llvmplugin" to enable the building of the annobin plugin for LLVM. +%bcond_with llvmplugin + +# Set this to zero to disable the requirement for a specific version of gcc. +# This should only be needed if there is some kind of problem with the version +# checking logic or when building on RHEL-7 or earlier. +%global with_hard_gcc_version_requirement 1 + +%bcond_with plugin_rebuild +# Allow the building of annobin without using annobin itself. +# This is because if we are bootstrapping a new build environment we can have +# a new version of gcc installed, but without a new of annobin installed. +# (i.e. we are building the new version of annobin to go with the new version +# of gcc). If the *old* annobin plugin is used whilst building this new +# version, the old plugin will complain that version of gcc for which it +# was built is different from the version of gcc that is now being used, and +# then it will abort. +# +# The default was to use plugin during rebuilds (cf BZ 1630550) but this has +# been changed because of the need to be able to rebuild annobin when a change +# to gcc breaks the version installed into the buildroot. +%if %{without plugin_rebuild} +%undefine _annotated_build +%endif + +%{!?llvm_version:%global llvm_version 11.1.0} +%{!?llvm_plugin_dir:%global llvm_plugin_dir %{_libdir}/llvm/%{llvm_version}} +%{!?clang_plugin_dir:%global clang_plugin_dir %{_libdir}/clang/%{llvm_version}} + +#--------------------------------------------------------------------------------- + +# Source: https://nickc.fedorapeople.org/annobin-%%{version}.tar.xz +Source: annobin-%{version}.tar.xz +# For the latest sources use: git clone git://sourceware.org/git/annobin.git + +# Insert patches here, if needed. +Patch01: annocheck-not-build-with-plugin.patch +# Remember to add %%patchNN -p1 directives after the %%setup command. + +# For RHEL-7 we do not build for the AArch64 target. +%if 0%{?rhel} == 7 +ExcludeArch: aarch64 +%endif + +#--------------------------------------------------------------------------------- + +%{?scl:Requires:%scl_runtime} +%{?scl:BuildRequires:%scl_runtime} +%{?scl:BuildRequires:scl-utils-build} +# We need the devtoolset-11 version of gcc to build annobin, as otherwise the versions will not match. +%{?scl:Requires:%scl_require_package %{scl} gcc} + +BuildRequires: %{?scl_prefix}gcc + +%define gcc_for_annobin %{?_scl_root}/usr/bin/gcc +%define gxx_for_annobin %{?_scl_root}/usr/bin/g++ + +%if %{with gccplugin} +Requires: annobin-plugin-gcc + +# [Stolen from gcc-python-plugin] +# GCC will only load plugins that were built against exactly that build of GCC +# We thus need to embed the exact GCC version as a requirement within the +# metadata. +# +# Define "gcc_vr", a variable to hold the VERSION-RELEASE string for the gcc +# we are being built against. +# +# Unfortunately, we can't simply run: +# rpm -q --qf="%%{version}-%%{release}" +# to determine this, as there's no guarantee of a sane rpm database within +# the chroots created by our build system +# +# So we instead query the version from gcc's output. +# +# gcc.spec has: +# Version: %%{gcc_version} +# Release: %%{gcc_release}%%{?dist} +# ...snip... +# echo 'Red Hat %%{version}-%%{gcc_release}' > gcc/DEV-PHASE +# +# So, given this output: +# +# $ gcc --version +# gcc (GCC) 4.6.1 20110908 (Red Hat 4.6.1-9) +# Copyright (C) 2011 Free Software Foundation, Inc. +# This is free software; see the source for copying conditions. There is NO +# warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. +# +# we can scrape out the "4.6.1" from the version line. +# +# The following implements the above: + +%global gcc_vr %(%gcc_for_annobin --version | head -n 1 | sed -e 's|.*(Red\ Hat\ ||g' -e 's|)$||g') + +# We need the major version of gcc. +%global gcc_major %(echo "%{gcc_vr}" | cut -f1 -d".") +%global gcc_next %(v="%{gcc_major}"; echo $((++v))) + +# Needed when building the srpm. +%if 0%{?gcc_major} == 0 +%global gcc_major 0 +%endif + +# This is a gcc plugin, hence gcc is required. +%if %{with_hard_gcc_version_requirement} +# BZ 1607430 - There is an exact requirement on the major version of gcc. +Requires: %{?scl_prefix}gcc >= %{gcc_major}, %{?scl_prefix}gcc < %{gcc_next} +%else +Requires: %{?scl_prefix}gcc +%endif + +BuildRequires: %{?scl_prefix}gcc-plugin-devel %{?scl_prefix}gcc-c++ + +%endif + +%if %{with llvmplugin} +Requires: annobin-plugin-llvm +BuildRequires: clang clang-devel llvm llvm-devel compiler-rt +%endif + +%if %{with clangplugin} +Requires: annobin-plugin-clang +BuildRequires: clang clang-devel llvm llvm-devel compiler-rt +%endif + +# The documentation uses pod2man... +BuildRequires: perl-interpreter perl-podlators gawk + +#--------------------------------------------------------------------------- + +%description +Provides a plugin for GCC that records extra information in the files +that it compiles. + +Note - the plugin is automatically enabled in gcc builds via flags +provided by the redhat-rpm-macros package. + +%if %{with clangplugin} +Also provides a plugin for Clang which performs a similar function. +%endif + +%if %{with llvmplugin} +Also provides a plugin for LLVM which performs a similar function. +%endif + +#--------------------------------------------------------------------------- + +# Now that we have sub-packages for all of the plugins and for annocheck, +# there are no executables left to go into the "annobin" rpm. But top-level +# packages cannot have "BuildArch: noarch" if sub-packages do have +# architecture requirements, and rpmlint generates an error if an +# architecture specific rpm does not contain any binaries. So instead all of +# the documentation has been moved into an architecture neutral sub-package, +# and there no longer is a top level annobin rpm at all. + +%package docs +Summary: Documentation and shell scripts for use with annobin +BuildArch: noarch +# annobin renamed to annobin-doc in 9.66-1 +Provides: %{name} = %{version}-%{release} +Obsoletes: %{name} < 9.66-1 + +%description docs +Provides the documentation files and example shell scripts for use with annobin. + +#---------------------------------------------------------------------------- +%if %{with tests} + +%package tests +Summary: Test scripts and binaries for checking the behaviour and output of the annobin plugin +Requires: %{name}-docs = %{version}-%{release} + +%description tests +Provides a means to test the generation of annotated binaries and the parsing +of the resulting files. + +%if %{with debuginfod} +BuildRequires: elfutils-debuginfod-client-devel +%endif + +%endif + +#---------------------------------------------------------------------------- +%if %{with annocheck} + +%package annocheck +Summary: A tool for checking the security hardening status of binaries + +BuildRequires: %{?scl_prefix}gcc elfutils elfutils-devel elfutils-libelf-devel rpm-devel %{?scl_prefix}binutils-devel +%if %{with debuginfod} +BuildRequires: elfutils-debuginfod-client-devel make +%endif + +Requires: %{name}-docs = %{version}-%{release} + +%description annocheck +Installs the annocheck program which uses the notes generated by annobin to +check that the specified files were compiled with the correct security +hardening options. + +%endif + +#---------------------------------------------------------------------------- +%if %{with gccplugin} + +%package plugin-gcc +Summary: annobin gcc plugin + +Requires: %{name}-docs = %{version}-%{release} +Conflicts: annobin <= 9.60-1 + +%description plugin-gcc +Installs an annobin plugin that can be used by gcc. + +%endif + +#--------------------------------------------------------------------------------- +%if %{with llvmplugin} + +%package plugin-llvm +Summary: annobin llvm plugin + +Requires: %{name}-docs = %{version}-%{release} +Conflicts: annobin <= 9.60-1 + +%description plugin-llvm +Installs an annobin plugin that can be used by llvm tools. + +%endif + +#--------------------------------------------------------------------------------- +%if %{with clangplugin} + +%package plugin-clang +Summary: annobin clang plugin + +Requires: %{name}-docs = %{version}-%{release} +Conflicts: annobin <= 9.60-1 + +%description plugin-clang +Installs an annobin plugin that can be used by clang. + +%endif +#--------------------------------------------------------------------------------- + +%global ANNOBIN_GCC_PLUGIN_DIR %(%gcc_for_annobin --print-file-name=plugin) + +#--------------------------------------------------------------------------------- + +%prep +if [ -z "%{gcc_vr}" ]; then + echo "*** Missing gcc_vr spec file macro, cannot continue." >&2 + exit 1 +fi + +echo "Requires: (%{?scl_prefix}gcc >= %{gcc_major} and %{?scl_prefix}gcc < %{gcc_next})" + +# Cannot use autosetup as it untar's the sources into annobin- +# but then tries to change directory into -annobin-. +# %%autosetup -p1 +%setup -q -n annobin-%{version} +%patch01 -p1 + +# The plugin has to be configured with the same arcane configure +# scripts used by gcc. Hence we must not allow the Fedora build +# system to regenerate any of the configure files. +touch aclocal.m4 gcc-plugin/config.h.in +touch configure */configure Makefile.in */Makefile.in +# Similarly we do not want to rebuild the documentation. +touch doc/annobin.info + +#--------------------------------------------------------------------------------- + +%build + +CONFIG_ARGS="--quiet" + +%if %{with debuginfod} +CONFIG_ARGS="$CONFIG_ARGS --with-debuginfod" +%else +# Note - we explicitly disable debuginfod support if it was not configured. +# This is because by default annobin's configue script will assume --with-debuginfod=auto +# and then run a build time test to see if debugingfod is available. It +# may well be, but the build time environment may not match the run time +# environment, and the rpm will not have a Requirement on the debuginfod +# client. +CONFIG_ARGS="$CONFIG_ARGS --without-debuginfod" +%endif + +%if %{with clangplugin} +CONFIG_ARGS="$CONFIG_ARGS --with-clang" +%endif + +%if %{without gccplugin} +CONFIG_ARGS="$CONFIG_ARGS --without-gcc-plugin" +%else +CONFIG_ARGS="$CONFIG_ARGS --with-gcc-plugin-dir=%{ANNOBIN_GCC_PLUGIN_DIR}" +%endif + +%if %{with llvmplugin} +CONFIG_ARGS="$CONFIG_ARGS --with-llvm" +%endif + +%if %{without tests} +CONFIG_ARGS="$CONFIG_ARGS --without-test" +%endif + +%if %{without annocheck} +CONFIG_ARGS="$CONFIG_ARGS --without-annocheck" +%endif + +# Add hardening options supported by gcc-10 but not in RHEL-7 rpm config macros. +# EXTRA_ARGS="-fstack-clash-protection -D_GLIBCXX_ASSERTIONS" +# %%ifarch %{ix86} x86_64 +# EXTRA_ARGS="$EXTRA_ARGS -fcf-protection=full" +# %%endif +# +# export CFLAGS="$RPM_OPT_FLAGS $EXTRA_ARGS" +# export CXXFLAGS="$RPM_OPT_FLAGS $EXTRA_ARGS" + +export CFLAGS="$CFLAGS $RPM_OPT_FLAGS -I%{?_scl_root}/usr/include" +export CXXFLAGS="$CXXFLAGS $RPM_OPT_FLAGS -I%{?_scl_root}/usr/include" +export LDFLAGS="$LD_FLAGS $RPM_LD_FLAGS -L%{?_scl_root}/usr/lib64 -L%{?_scl_root}/usr/lib" + +%ifarch %{ix86} x86_64 +# FIXME: There should be a better way to do this. +export CLANG_TARGET_OPTIONS="-fcf-protection" +%endif + +%configure CC=%gcc_for_annobin CXX=%gxx_for_annobin ${CONFIG_ARGS} || cat config.log + +%make_build + +%if %{with plugin_rebuild} +# Rebuild the plugin(s), this time using the plugin itself! This +# ensures that the plugin works, and that it contains annotations +# of its own. + +%if %{with gccplugin} +cp gcc-plugin/.libs/annobin.so.0.0.0 %{_tmppath}/tmp_annobin.so +make -C gcc-plugin clean +BUILD_FLAGS="-fplugin=%{_tmppath}/tmp_annobin.so" + +# Disable the standard annobin plugin so that we do get conflicts. +# Note: the "-fplugin=annobin" is here, despite the fact that it will also +# be automatically added to the gcc command line via +# "-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1" because of a bug in gcc's +# plugin command line options handling. GCC will issue an error saying that +# there is no plugin called "annobin" matching the -fplugin-arg-annobin-disable +# option, despite the fact that there patently is. +BUILD_FLAGS="$BUILD_FLAGS -fplugin=annobin -fplugin-arg-annobin-disable" + +# If building on RHEL7, enable the next option as the .attach_to_group +# assembler pseudo op is not available in the assembler. +BUILD_FLAGS="$BUILD_FLAGS -fplugin-arg-tmp_annobin-no-attach" + +make -C gcc-plugin CXXFLAGS="%{optflags} $BUILD_FLAGS" +rm %{_tmppath}/tmp_annobin.so +%endif + +%if %{with clangplugin} +cp clang-plugin/annobin-for-clang.so %{_tmppath}/tmp_annobin.so +make -C clang-plugin all CXXFLAGS="%{optflags} $BUILD_FLAGS" +%endif + +%if %{with llvmplugin} +cp llvm-plugin/annobin-for-llvm.so %{_tmppath}/tmp_annobin.so +make -C llvm-plugin all CXXFLAGS="%{optflags} $BUILD_FLAGS" +%endif + +%endif + +#--------------------------------------------------------------------------------- + +%install +# PLUGIN_INSTALL_DIR is used by the Clang and LLVM makefiles... +%make_install PLUGIN_INSTALL_DIR=%{buildroot}/%{llvm_plugin_dir} + +%if %{with clangplugin} +# Move clang plugin to a seperate directory. +mkdir -p %{buildroot}/%{clang_plugin_dir} +mv %{buildroot}/%{llvm_plugin_dir}/annobin-for-clang.so %{buildroot}/%{clang_plugin_dir} +%endif + +rm -f %{buildroot}%{_infodir}/dir + +#--------------------------------------------------------------------------------- + +%if %{with tests} +%check +# On RHEL7 the assembler does not support all of the annobin tests. +# With scl the tests are run with the wrong version of gcc. Hence +# we allow the tests to fail. +make check GCC=%gcc_for_annobin || : +if [ -f tests/test-suite.log ]; then + cat tests/test-suite.log +fi + +%if %{with clangplugin} +# FIXME: RUN CLANG tests +%endif + +%if %{with llvmplugin} +# FIXME: RUN LLVM tests +%endif + +%endif + +#--------------------------------------------------------------------------------- + +%files docs +%license COPYING3 LICENSE +%exclude %{_datadir}/doc/annobin-plugin/COPYING3 +%exclude %{_datadir}/doc/annobin-plugin/LICENSE +%doc %{_datadir}/doc/annobin-plugin/annotation.proposal.txt +%{_infodir}/annobin.info* +%{_mandir}/man1/annobin.1* +%{_mandir}/man1/built-by.1* +%{_mandir}/man1/check-abi.1* +%{_mandir}/man1/hardened.1* +%{_mandir}/man1/run-on-binaries-in.1* + +%if %{with llvmplugin} +%files plugin-llvm +%{llvm_plugin_dir}/annobin-for-llvm.so +%endif + +%if %{with clangplugin} +%files plugin-clang +%{clang_plugin_dir}/annobin-for-clang.so +%endif + +%if %{with gccplugin} +%files plugin-gcc +%{ANNOBIN_GCC_PLUGIN_DIR} +%endif + +%if %{with annocheck} +%files annocheck +%{_bindir}/annocheck +%{_mandir}/man1/annocheck.1* +%endif + +#--------------------------------------------------------------------------------- + +%changelog +* Tue Jul 20 2021 Nick Clifton - 9.82-1 +- Annocheck: Add another test exceptions. +- Annocheck: Add some more test exceptions. +- Tests: Skip glibc-notes test if the assembler does not support --generate-missing-build-notes. (#1978573) +- Tests: Skip objcopy test if objcopy does not support --merge-notes. + +* Wed Jun 30 2021 Nick Clifton - 9.79-1 +- Annocheck: Fix spelling mistake in -mstack-realign failure message. (#1977349) +- gcc-plugin: Do not record global versions of stack protection settings in LTO mode, if not set. (#1958954) +- Annocheck: Remove limit on number of input files. + +* Mon Jun 21 2021 Nick Clifton - 9.77-1 +- annocheck: Conditionalize test of DF_PIE_1 flag. +- clang/llvm plugins: Build with correct security options. +- Annocheck: Better detection of GO compiler version. +- Annocheck: Better support for symbolic links. +- Annocheck: In verbose mode, report the reason for skipping specific tests. (#1969584) +- annocheck: Improve detection of shared libraries. (#1958954) + +* Mon May 17 2021 Nick Clifton - 9.72-1 +- Rebase to 9.72: (#1954564) +- annocheck: Accept 0 as a valid number for gcc minor versions and release numbers. +- gcc-plugin: Add support for ARM and RISCV targets. +- timing: do not initialise the clock if the timing tool is disabled. +- gcc-plugin: Replace ICE messsages with verbose messages. +- Fix the testsuite so that it can be run in parallel. +- Annocheck: WARN if the annobin plugin was built for a newer version of the compiler than the one on which it was run. (#1950657) +- Obsolete annobin < 9.66-1 (bug #1949570) +- Annocheck: Improve detection of missing GNU-stack support. +- Correct a package rename (bug #1949570) +- Require docs subpackage by the other ones because of a license +- Build-requiring perl-interpreter is enough +- Fix bz1949570 +- Fix anomolies reported by covscan. +- Move documentation into a sub-package. +- gcc-plugin: Use a fixed filename when running in LTO mode. +- Annocheck: Fix detection of special function names. (#1934189) +- Annocheck: FAIL the deliberate use of -fno-stack-protector, but add some exceptions for glibc. (#1923439) +- Annocheck: Add colour to some messages. Skip the deliberate use of -fno-stack-protector. (#1923439) +- Annocheck: Fix some problems with tests for missing notes. +- Split plugins into separate sub-packages +- Add some GO tests to annocheck. +- Add a future fail for the presence of RPATH in the dynamic tags. +- Add the ability to disable the warning message about -D_FORTIFY_SOURCE being missing. +- Workaround for elflint problems with PPC compiled files. (#1880634) +- Fix bogus AArch64 test failures. +- Improved testing by annocheck. Add fixed format message mode. +- Fix inconsistency reporting -fcf-protection and -fstack-clash-protection results. +- Add support for -D_FORTIFY_SOURCE=3. +- annocheck: When a binary is produced both by GAS and GCC, select GAS as the real producer. (#1906171) +- annocheck: Improve test for LTO compiled binaries that do not have -Wall annotations. (#1906171) +- annocheck: Mark a missining -D_FORTIFY_SOURCE as a FAIL. +- annocheck: Fix notes analyzer to accept empty PPC64 notes. +- gcc plugin: Tweak generation of end symbols for PPC64 when LTO is active. (#1898075) +- gcc plugin: Add support for GCC 11's cl_vars array. +- Annocheck: Support enabling/disabling future fails. +- GCC plugin: Always record global notes for the .text.startup, + .text.exit, .text.hot and .text.cold sections. +- Clang plugin: Add -lLLVM to the build command line. +- Annocheck: Improve reporting of missing -D_FORTIFY_SOURCE option. (#1898075) +- Annocheck: Improve reporting of missing LTO option. +- Add detecting of gimple compiled binaries. +- Add --without-gcc-plugin option. +- Annocheck: Fix bug parsing DW_AT_producer. +- Add test of .note.gnu.property section for PowerPC. +- Add test of objcopy's ability to merge notes. +- Record the -flto setting and produce a soft warning if it is absent. +- Suppress warnings about _D_GLIBCXX_ASSERTIONS if the source code is known to be something other than C++. +- Correct the directory chosen for 32-bit LLVM and Clang plugins. (#1884951) +- Allow the use of the SHF_LINK_ORDER section flag to discard unused notes. (Experimental). +- Enable the build and installation of the LLVM and Clang plugins. (Experimental). +- gcc-plugin: Fix test for empty PowerPC sections. (#1880634) +- annocheck: Add tests for the AArch64 BTI and PAC security features. (#1862478) +- gcc plugin: Use a 4 byte offset for PowerPC start symbols, so that they do not break disassemblies. +- gcc plugin: Correct the detection of 32-bit x86 builds. (#1876197) +- gcc plugin: Detect any attempt to access the global_options array. +- gcc plugin: Do not complain about missing pre-processor options when examining a preprocessed input file. (#1862718) +- Use more robust checks for AArch64 options. +- Detect CLANG compiled assembler that is missing IBT support. +- Improved target pointer size discovery. +- Add support for installing clang and llvm plugins. +- Temporary suppression of aarch64 pointer size check. (#1860549) + +* Mon Aug 10 2020 Nick Clifton - 9.23-3 +- Improve results when running annobin rpms through annocheck. (#1866825) + +* Thu Aug 06 2020 Martin Cermak - 9.23-2 +- Fix rhbz1866774 + +* Mon Jul 13 2020 Nick Clifton - 9.23-1 +- INITIAL CREATION OF DTS-10 ANNOBIN. (#1852725) +- Annocheck: Do not skip tests of the short-enums notes. (#1743635) +- Add (optional) llvm plugin. + 9.21-3 +- Fix the computations of ANNOBIN_GCC_PLUGIN_DIR and ANNOBIN_CLANG_PLUGIN_DIR. + 9.21-1 +- Fix stack clash protection problem. (#1803173) + 9.21-1 +- Annobin: Fall back on using the flags if the option cannot be found in cl_options. (#1817659) + 9.20-1 +- Annocheck: Detect Fortran compiled programs. (#1824393) + 9.19-1 +- Annobin: If option name mismatch occurs, seach for the real option. (#1817452) + 9.18-1 +- Annocheck: Fix a division by zero error when parsing GO binaries. (#1818863) + 9.16-1 +- Annobin: Fix access to the -flto and -fsanitize flags. + 9.14-1 +- Annobin: Use offsets stored in gcc's cl_option structure to access the global_options array, thus removing the need to check for changes in the size of this structure. + 9.13-1 +- Rename gcc plugin directory to gcc-plugin. +- Stop annocheck from complaining about missing options when the binary has been built in a mixed environment. + 9.12-1 +- Improve builtby tool. +- Stop annocheck complaining about missing notes when the binary is not compiled by either gcc or clang. +- Skip the check of the ENTRY instruction for binaries not compiled by gcc or clang. (#1809656) + 9.11-1 +- Fix infinite loop hangup in annocheck. +- Disable debuginfod support by default. +- Improve parsing of .comment section. + 9.10-1 +- Fix clang plugin to use hidden symbols. + 9.09-1 +- Add ability to build clang plugin (disabled by default). + 9.08-1 +- Annocheck: Fix error printing out the version number. + 9.07-1 +- Annobin: Add checks of the exact location of the examined switches. + 9.06-1 +- Annobin: Note when stack clash notes are generated. +- Annocheck: Handle multiple builder IDs in the .comment section. + 9.05-1 +- Add configure option to suppress building annocheck. + 9.04-1 +- Fix debuginfod test. + 9.03-2 +- Correct the build requirement for building with debuginfod support. + 9.03-1 +- Add debuginfod support. + 9.01-1 +- Add clang plugin (experimental). + 8.92-1 +- Have annocheck ignore notes with an end address of 0. + 8.91-1 +- Improve checking of gcc versions. + 8.90-1 +- Do not skip positive results. + 8.88-1 +- Generate a WARN result for code compiled with instrumentation enabled. (#1753918) + 8.87-1 +- Replace address checks with dladdr1. + 8.86-1 +- Use libabigail like checking to ensure variable address consistency. + 8.85-1 +- Skip generation of global notes for hot/cold sections. + 8.84-1 +- Generate FAIL results if -Wall or -Wformat-security are missing. + 8.83-1 +- If notes cannot be found in the executable look for them in the debuginfo file, if available. +- Generate a FAIL if notes are missing from the executable/debuginfo file. +- Record and report the setting of the AArcht64 specific -mbranch-protection option. + 8.81-1 +- Improve detection of GO binaries. +- Add gcc version information to annobin notes. +- Do not complain about missing FORTIFY_SOURCE and GLIBCXX_ASSERTIONS in LTO compilations. + +* Wed Aug 21 2019 Nick Clifton - 8.79-2 +- INITIAL CREATION OF DTS-9 ANNOBIN. + +* Thu Aug 08 2019 Nick Clifton - 8.79-2 +- Import the missing tests/ sub-directory. + +* Thu Aug 08 2019 Nick Clifton - 8.79-1 +- Allow the compiler used to run tests to be specified on the command line. + +* Tue Aug 06 2019 Nick Clifton - 8.78-1 +- Fix a memory allocation error in the annobin plugin. (#1737306) + +* Tue Jul 23 2019 Nick Clifton - 8.77-4 +- Change the requirement of gcc-toolset-9 to gcc-toolset-9-gcc. (#1732767) + +* Tue Jul 23 2019 Nick Clifton - 8.77-2 +- Version bump to allow rebuilding with scl_prefix. + +* Tue Jul 23 2019 Nick Clifton - 8.77-1 +- gcc-toolset-9: INITIAL IMPORT OF ANNOBIN FROM RAWHIDE. (#1730483) + +* Mon Jun 24 2019 Nick Clifton - 8.77-1 +- Another attempt at fixing the detection and reporting of missing -D_FORTIFY_SOURCE options. (#1703500) + +* Mon Jun 10 2019 Igor Gnatenko - 8.76-4 +- Rebuild for RPM 4.15 + +* Mon Jun 10 2019 Igor Gnatenko - 8.76-3 +- Rebuild for RPM 4.15 + +* Thu Jun 06 2019 Panu Matilainen - 8.76-2 +- Really enable annocheck sub-package + +* Tue Apr 30 2019 Nick Clifton - 8.76-1 +- Report a missing -D_FORTIFY_SOUCRE option if -D_GLIBCXX_ASSERTIONS was detected. (#1703499) +- Do not report problems with -fstack-protection if the binary was not built by gcc or clang. (#1703788) + +* Fri Apr 26 2019 Nick Clifton - 8.74-1 +- Add tests of clang command line options recorded in the DW_AT_producer attribute. + +* Wed Apr 24 2019 Nick Clifton - 8.73-1 +- Fix test for an executable stack segment. (#1700924) + +* Thu Apr 18 2019 Nick Clifton - 8.72-1 +- Rebuild annobin with the latest rawhide gcc sources. (#1700923) + +* Thu Feb 28 2019 Nick Clifton - 8.71-1 +- Annobin: Suppress more calls to free() which are triggering memory checker errors. (#1684148) + +* Fri Feb 01 2019 Nick Clifton - 8.70-1 +- Add section flag matching ability to section size tool. + +* Thu Jan 31 2019 Fedora Release Engineering - 8.69-7 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + +* Tue Jan 29 2019 Björn Esser - 8.69-6 +- Use 'with' for rich dependency on gcc + +* Tue Jan 29 2019 Björn Esser - 8.69-5 +- Really fix rhbz#1607430. + +* Mon Jan 28 2019 Björn Esser - 8.69-4 +- Rebuilt with annotations enabled + +* Mon Jan 28 2019 Björn Esser - 8.69-3 +- Fix rpm query for gcc version. + +* Mon Jan 28 2019 Nick Clifton - 8.69-2 +- Add an exact requirement on the major version of gcc. (#1607430) + +* Thu Jan 24 2019 Nick Clifton - 8.69-1 +- Annobin: Add support for .text.startup and .text.exit sections generated by gcc 9. +- Annocheck: Add a note displaying tool. + +* Wed Jan 23 2019 Nick Clifton - 8.68-1 +- Annocheck: Skip checks for -D_FORTIFY_SOURCE and -D_GLIBCXX_ASSERTIONS if there is no compiler generated code in the binary. + +* Mon Jan 21 2019 Björn Esser - 8.67-3 +- Rebuilt with annotations enabled + +* Mon Jan 21 2019 Björn Esser - 8.67-2 +- Rebuilt for GCC 9 + +* Thu Jan 17 2019 Nick Clifton - 8.67-1 +- Annocheck: Only skip specific checks for specific symbols. (#1666823) +- Annobin: Record the setting of the -fomit-frame-pointer option. + +* Wed Jan 02 2019 Nick Clifton - 8.66-1 +- Annocheck: Do not ignore -Og when checking to see if an optimization level has been set. (#1624162) + +* Tue Dec 11 2018 Nick Clifton - 8.65-1 +- Annobin: Fix handling of multiple .text.unlikely sections. + +* Fri Nov 30 2018 Nick Clifton - 8.64-1 +- Annocheck: Skip gaps in PPC64 executables covered by start_bcax_ symbols. (#1630564) + +* Mon Nov 26 2018 Nick Clifton - 8.63-1 +- Annocheck: Disable ENDBR test for shared libraries. (#1652925) + +* Mon Nov 26 2018 Nick Clifton - 8.62-1 +- Annocheck: Add test for ENDBR instruction at entry address of x86/x86_64 executables. (#1652925) + +* Tue Nov 20 2018 David Cantrell - 8.61-2 +- Adjust how the gcc_vr macro is set. + +* Mon Nov 19 2018 Nick Clifton - 8.61-1 +- Fix building with gcc version 4. + +* Tue Nov 13 2018 Nick Clifton - 8.60-1 +- Skip -Wl,-z,now and -Wl,-z,relro checks for non-gcc produced binaries. (#1624421) + +* Mon Nov 05 2018 Nick Clifton - 8.59-1 +- Ensure GNU Property notes are 8-byte aligned in x86_64 binaries. (#1645817) + +* Thu Oct 18 2018 Nick Clifton - 8.58-1 +- Skip PPC64 linker stubs created in the middle of text sections (again). (#1630640) + +* Thu Oct 18 2018 Nick Clifton - 8.57-1 +- Suppress free of invalid pointer. (#1638371) + +* Thu Oct 18 2018 Nick Clifton - 8.56-1 +- Skip PPC64 linker stubs created in the middle of text sections. (#1630640) + +* Tue Oct 16 2018 Nick Clifton - 8.55-1 +- Reset the (PPC64) section start symbol to 0 if its section is empty. (#1638251) + +* Thu Oct 11 2018 Nick Clifton - 8.53-1 +- Also skip virtual thinks created by G++. (#1630619) + +* Wed Oct 10 2018 Nick Clifton - 8.52-1 +- Use uppercase for all fail/mayb/pass results. (#1637706) + +* Wed Oct 10 2018 Nick Clifton - 8.51-1 +- Generate notes for unlikely sections. (#1630620) + +* Mon Oct 08 2018 Nick Clifton - 8.50-1 +- Fix edge case computing section names for end symbols. (#1637039) + +* Mon Oct 08 2018 Nick Clifton - 8.49-1 +- Skip dynamic checks for binaries without a dynamic segment. (#1636606) + +* Fri Oct 05 2018 Nick Clifton - 8.48-1 +- Delay generating attach_to_group directives until the end of the compilation. (#1636265) + +* Mon Oct 01 2018 Nick Clifton - 8.47-1 +- Fix bug introduced in previous delta which would trigger a seg-fault when scanning for gaps. + +* Mon Oct 01 2018 Nick Clifton - 8.46-1 +- Annobin: Fix section name selection for startup sections. +- Annocheck: Improve gap skipping heuristics. (#1630574) + +* Mon Oct 01 2018 Nick Clifton - 8.45-1 +- Fix function section support (again). (#1630574) + +* Fri Sep 28 2018 Nick Clifton - 8.44-1 +- Skip compiler option checks for non-GNU producers. (#1633749) + +* Wed Sep 26 2018 Nick Clifton - 8.43-1 +- Fix function section support (again). (#1630574) + +* Tue Sep 25 2018 Nick Clifton - 8.42-1 +- Ignore ppc64le notes where start = end + 2. (#1632259) + +* Tue Sep 25 2018 Nick Clifton - 8.41-1 +- Make annocheck ignore symbols suffixed with ".end". (#1639618) + +* Mon Sep 24 2018 Nick Clifton - 8.40-1 +- Reinstate building annobin with annobin enabled. (#1630550) + +* Fri Sep 21 2018 Nick Clifton - 8.39-1 +- Tweak tests. + +* Fri Sep 21 2018 Nick Clifton - 8.38-1 +- Generate notes and groups for .text.hot and .text.unlikely sections. +- When -ffunction-sections is active, put notes for startup sections into .text.startup.foo rather than .text.foo. +- Similarly put exit section notes into .text.exit.foo. (#1630574) +- Change annocheck's maybe result for GNU Property note being missing into a PASS if it is not needed and a FAIL if it is needed. + +* Wed Sep 19 2018 Nick Clifton - 8.37-1 +- Make the --skip-* options skip all messages about the specified test. + +* Tue Sep 18 2018 Nick Clifton - 8.36-1 +- Improve error message when an ET_EXEC binary is detected. + +* Mon Sep 17 2018 Nick Clifton - 8.35-1 +- Skip failures for PIC vs PIE. (#1629698) + +* Mon Sep 17 2018 Nick Clifton - 8.34-1 +- Ensure 4 byte alignment of note sub-sections. (#1629671) + +* Wed Sep 12 2018 Nick Clifton - 8.33-1 +- Add timing tool to report on speed of the checks. +- Add check for conflicting use of the -fshort-enum option. +- Add check of the GNU Property notes. +- Skip check for -O2 if compiled with -Og. (#1624162) + +* Mon Sep 03 2018 Nick Clifton - 8.32-1 +- Add test for ET_EXEC binaries. (#1625627) +- Document --report-unknown option. + +* Thu Aug 30 2018 Nick Clifton - 8.31-1 +- Fix bug in hardened tool which would skip gcc compiled files if the notes were too small. +- Fix bugs in section-size tool. +- Fix bug in built-by tool. + +* Wed Aug 29 2018 Nick Clifton - 8.30-1 +- Generate notes for comdat sections. (#1619267) + +* Thu Aug 23 2018 Nick Clifton - 8.29-1 +- Add more names to the gap skip list. (#1619267) + +* Thu Aug 23 2018 Nick Clifton - 8.28-1 +- Skip gaps covered by _x86.get_pc_thunk and _savegpr symbols. (#1619267) +- Merge ranges where one is wholly covered by another. + +* Wed Aug 22 2018 Nick Clifton - 8.27-1 +- Skip gaps at the end of functions. (#1619267) + +* Tue Aug 21 2018 Nick Clifton - 8.26-1 +- Fix thinko in ppc64 gap detection code. (#1619267) + +* Mon Aug 20 2018 Nick Clifton - 8.25-1 +- Skip gaps at the end of the .text section in ppc64 binaries. (#1619267) + +* Wed Aug 15 2018 Nick Clifton - 8.24-1 +- Skip checks in stack_chk_local_fail.c +- Treat gaps as FAIL results rather than MAYBE. + +* Wed Aug 08 2018 Nick Clifton - 8.23-1 +- Skip checks in __stack_chk_local_fail. + +* Wed Aug 08 2018 Nick Clifton - 8.22-1 +- Reduce version check to gcc major version number only. Skip compiler option checks if binary not built with gcc. (#1603089) + +* Tue Aug 07 2018 Nick Clifton - 8.21-1 +- Fix bug in annobin plugin. Add --section-size=NAME option to annocheck. + +* Thu Aug 2 2018 Peter Robinson 8.20-2 +- rebuild for new gcc + +* Thu Aug 02 2018 Nick Clifton - 8.20-1 +- Correct name of man page for run-on-binaries-in script. (#1611155) + +* Wed Jul 25 2018 Nick Clifton - 8.19-1 +- Allow $ORIGIN to be at the start of entries in DT_RPATH and DT_RUNPATH. + +* Mon Jul 23 2018 Nick Clifton - 8.18-1 +- Add support for big endian targets. + +* Mon Jul 23 2018 Nick Clifton - 8.17-1 +- Count passes and failures on a per-component basis and report gaps. + +* Fri Jul 20 2018 Nick Clifton - 8.16-1 +- Use our own copy of the targetm.asm_out.function_section() function. (#159861 comment#17) + +* Fri Jul 20 2018 Nick Clifton - 8.15-1 +- Generate grouped note section name all the time. (#159861 comment#16) + +* Thu Jul 19 2018 Nick Clifton - 8.14-1 +- Fix section conflict problem. (#1603071) + +* Wed Jul 18 2018 Nick Clifton - 8.13-1 +- Fix for building with gcc version 4. +- Fix symbol placement in functions with local assembler. + +* Tue Jul 17 2018 Nick Clifton - 8.12-1 +- Fix assertions in range checking code. Add detection of -U options. + +* Tue Jul 17 2018 Nick Clifton - 8.11-1 +- Handle function sections properly. Handle .text.startup and .text.unlikely sections. Improve gap detection and reporting. (#1601055) + +* Thu Jul 12 2018 Fedora Release Engineering - 8.10-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild + +* Thu Jul 12 2018 Nick Clifton - 8.10-1 +- Fix construction of absolute versions of --dwarf-dir and --debug-rpm options. + +* Tue Jul 10 2018 Nick Clifton - 8.9-1 +- Fix buffer overrun when very long symbol names are encountered. + +* Tue Jul 10 2018 Nick Clifton - 8.8-1 +- Do not force the generation of function notes when -ffunction-sections is active. (#1598961) + +* Mon Jul 09 2018 Nick Clifton - 8.7-1 +- Skip the .annobin_ prfix when reporting symbols. (#1599315) + +* Mon Jul 09 2018 Nick Clifton - 8.6-1 +- Use the assembler (c++ mangled) version of function names when switching sections. (#1598579) + +* Mon Jul 09 2018 Nick Clifton - 8.5-1 +- Do not call function_section. (#1598961) + +* Fri Jul 06 2018 Nick Clifton - 8.4-1 +- Ignore cross-section gaps. (#1598551) + +* Thu Jul 05 2018 Nick Clifton - 8.3-1 +- Do not skip empty range notes in object files. (#1598361) + +* Mon Jul 02 2018 Nick Clifton - 8.2-1 +- Create the start symbol at the start of the function and the end symbol at the end. (#1596823) + +* Mon Jul 02 2018 Nick Clifton - 8.1-1 +- Fix --debug-rpm when used inside a directory. + +* Thu Jun 28 2018 Nick Clifton - 8.0-1 +- Use a prefix for all annobin generated symbols, and make them hidden. +- Only generate weak symbol definitions for linkonce sections. + +* Wed Jun 27 2018 Nick Clifton - 7.1-1 +- Skip some checks for relocatable object files, and dynamic objects. +- Stop bogus complaints about stackrealignment not being enabled. + +* Mon Jun 25 2018 Nick Clifton - 7.0-1 +- Add -debug-rpm= option to annocheck. +- Only use a 2 byte offset for the initial symbol on PowerPC. + +* Fri Jun 22 2018 Nick Clifton - 6.6-1 +- Use --dwarf-path when looking for build-id based debuginfo files. + +* Fri Jun 22 2018 Nick Clifton - 6.5-1 +- Fix premature closing of dwarf handle. + +* Fri Jun 22 2018 Nick Clifton - 6.4-1 +- Fix scoping bug computing the name of a separate debuginfo file. + +* Tue Jun 19 2018 Nick Clifton - 6.3-1 +- Fix file descriptor leak. + +* Tue Jun 19 2018 Nick Clifton - 6.2-1 +- Add command line options to annocheck to disable individual tests. + +* Fri Jun 08 2018 Nick Clifton - 6.1-1 +- Remove C99-ism from annocheck sources. + +* Wed Jun 06 2018 Nick Clifton - 6.0-1 +- Add the annocheck program. + +* Fri Jun 01 2018 Nick Clifton - 5.11-1 +- Do not use the SHF_GNU_BUILD_NOTE section flag. + +* Thu May 31 2018 Nick Clifton - 5.10-1 +- Remove .sh extension from shell scripts. + +* Wed May 30 2018 Nick Clifton - 5.9-1 +- Record the setting of the -mstackrealign option for i686 binaries. + +* Mon May 14 2018 Nick Clifton - 5.8-1 +- Hide the annobin start of file symbol. + +* Tue May 08 2018 Nick Clifton - 5.7-1 +- Fix script bug in hardended.sh. (Thanks to: Stefan Sørensen ) + +* Thu May 03 2018 Nick Clifton - 5.6-3 +- Version number bump so that the plugin can be rebuilt with the latest version of GCC. + +* Mon Apr 30 2018 Nick Clifton - 5.6-2 +- Rebuild the plugin with the newly created plugin enabled. (#1573082) + +* Mon Apr 30 2018 Nick Clifton - 5.6-1 +- Skip the isa_flags check in the ABI test because the crt[in].o files are compiled with different flags from the test files. + +* Fri Apr 20 2018 Nick Clifton - 5.3-1 +- Add manual pages for annobin and the scripts. + +* Tue Apr 03 2018 Nick Clifton - 5.2-1 +- Do not record a stack protection setting of -1. (#1563141) + +* Tue Mar 20 2018 Nick Clifton - 5.1-1 +- Do not complain about a dwarf_version value of -1. (#1557511) + +* Thu Mar 15 2018 Nick Clifton - 5.0-1 +- Bias file start symbols by 2 in order to avoid them confused with function symbols. (#1554332) +- Version jump is to sync the version number with the annobin plugins internal version number. + +* Mon Mar 12 2018 Nick Clifton - 3.6-1 +- Add --ignore-gaps option to check-abi.sh script. +- Use this option in the abi-test check. +- Tweak hardening test to skip pic and stack protection checks. + +* Tue Mar 06 2018 Nick Clifton - 3.5-1 +- Handle functions with specific assembler names. (#1552018) + +* Fri Feb 23 2018 Nick Clifton - 3.4-2 +- Add an explicit requirement on the version of gcc used to built the plugin. (#1547260) + +* Fri Feb 09 2018 Nick Clifton - 3.4-1 +- Change type and size of symbols to STT_NOTYPE/0 so that they do not confuse GDB. (#1539664) +- Add run-on-binaries-in.sh script to allow the other scripts to be run over a repository. + +* Wed Feb 07 2018 Fedora Release Engineering - 3.3-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild + +* Tue Jan 30 2018 Nick Clifton - 3.3-1 +- Rebase on 3.3 release, which adds support for recording -mcet and -fcf-protection. + +* Mon Jan 29 2018 Florian Weimer - 3.2-3 +- Rebuild for GCC 8 + +* Fri Jan 26 2018 Nick Clifton - 3.2-2 +- Fix the installation of the annobin.info file. + +* Fri Jan 26 2018 Nick Clifton - 3.2-1 +- Rebase on 3.2 release, which now contains documentation! + +* Fri Jan 26 2018 Richard W.M. Jones - 3.1-3 +- Rebuild against GCC 7.3.1. + +* Tue Jan 16 2018 Nick Clifton - 3.1-2 +- Add --with-gcc-plugin-dir option to the configure command line. + +* Thu Jan 04 2018 Nick Clifton - 3.1-1 +- Rebase on version 3.1 sources. + +* Mon Dec 11 2017 Nick Clifton - 2.5.1-5 +- Do not generate notes when there is no output file. (#1523875) + +* Fri Dec 08 2017 Nick Clifton - 2.5.1-4 +- Invent an input filename when reading from a pipe. (#1523401) + +* Thu Nov 30 2017 Florian Weimer - 2.5.1-3 +- Use DECL_ASSEMBLER_NAME for symbol references (#1519165) + +* Tue Oct 03 2017 Igor Gnatenko - 2.5.1-2 +- Cleanups in spec + +* Tue Sep 26 2017 Nick Clifton - 2.5.1-1 +- Touch the auto-generated files in order to stop them from being regenerated. + +* Tue Sep 26 2017 Nick Clifton - 2.5-2 +- Stop the plugin complaining about compiler datestamp mismatches. + +* Thu Sep 21 2017 Nick Clifton - 2.4-1 +- Tweak tests so that they will run on older machines. + +* Thu Sep 21 2017 Nick Clifton - 2.3-1 +- Add annobin-tests subpackage containing some preliminary tests. +- Remove link-time test for unsupported targets. + +* Wed Aug 02 2017 Fedora Release Engineering - 2.0-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild + +* Mon Jul 31 2017 Florian Weimer - 2.0-2 +- Rebuild with binutils fix for ppc64le (#1475636) + +* Wed Jun 28 2017 Nick Clifton - 2.0-1 +- Fixes for problems reported by the package submission review: + * Add %%license entry to %%file section. + * Update License and BuildRequires tags. + * Add Requires tag. + * Remove %%clean. + * Add %%check. + * Clean up the %%changelog. +- Update to use version 2 of the specification and sources. + +* Thu May 11 2017 Nick Clifton - 1.0-1 +- Initial submission.