|
 |
85793c |
From 48676b9f1aac63f8a30ed8061b6e719929b82c98 Mon Sep 17 00:00:00 2001
|
|
|
85793c |
From: Ming-Hung Tsai <mtsai@redhat.com>
|
|
|
85793c |
Date: Wed, 28 Apr 2021 10:34:16 +0800
|
|
|
85793c |
Subject: [PATCH 01/10] [all] Fix resource leaks
|
|
|
85793c |
|
|
|
85793c |
---
|
|
|
85793c |
base/file_utils.cc | 4 +++-
|
|
|
85793c |
thin-provisioning/cache_stream.cc | 2 +-
|
|
|
85793c |
2 files changed, 4 insertions(+), 2 deletions(-)
|
|
|
85793c |
|
|
|
85793c |
diff --git a/base/file_utils.cc b/base/file_utils.cc
|
|
|
85793c |
index e4f3722..8253660 100644
|
|
|
85793c |
--- a/base/file_utils.cc
|
|
|
85793c |
+++ b/base/file_utils.cc
|
|
|
85793c |
@@ -155,8 +155,10 @@ file_utils::zero_superblock(std::string const &path)
|
|
|
85793c |
throw runtime_error("out of memory");
|
|
|
85793c |
|
|
|
85793c |
memset(buffer, 0, SUPERBLOCK_SIZE);
|
|
|
85793c |
- if (::write(fd.fd_, buffer, SUPERBLOCK_SIZE) != SUPERBLOCK_SIZE)
|
|
|
85793c |
+ if (::write(fd.fd_, buffer, SUPERBLOCK_SIZE) != SUPERBLOCK_SIZE) {
|
|
|
85793c |
+ free(buffer);
|
|
|
85793c |
throw runtime_error("couldn't zero superblock");
|
|
|
85793c |
+ }
|
|
|
85793c |
}
|
|
|
85793c |
|
|
|
85793c |
//----------------------------------------------------------------
|
|
|
85793c |
diff --git a/thin-provisioning/cache_stream.cc b/thin-provisioning/cache_stream.cc
|
|
|
85793c |
index 002b6ba..73b01b4 100644
|
|
|
85793c |
--- a/thin-provisioning/cache_stream.cc
|
|
|
85793c |
+++ b/thin-provisioning/cache_stream.cc
|
|
|
85793c |
@@ -62,7 +62,7 @@ chunk const &
|
|
|
85793c |
cache_stream::get()
|
|
|
85793c |
{
|
|
|
85793c |
chunk_wrapper *w = new chunk_wrapper(*this);
|
|
|
85793c |
- return w->c_;
|
|
|
85793c |
+ return w->c_; // wrapper will get freed by the put method
|
|
|
85793c |
}
|
|
|
85793c |
|
|
|
85793c |
void
|
|
|
85793c |
--
|
|
|
85793c |
1.8.3.1
|
|
|
85793c |
|