|
 |
e71b65 |
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
e71b65 |
From: Benjamin Marzinski <bmarzins@redhat.com>
|
|
|
e71b65 |
Date: Fri, 7 Oct 2022 12:35:41 -0500
|
|
|
e71b65 |
Subject: [PATCH] multipath tests: tests for reconcile_features_with_queue_mode
|
|
|
e71b65 |
|
|
|
e71b65 |
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
|
|
|
e71b65 |
Reviewed-by: Martin Wilck <mwilck@suse.com>
|
|
|
e71b65 |
---
|
|
|
e71b65 |
tests/Makefile | 2 +
|
|
|
e71b65 |
tests/features.c | 232 ++++++++++++++++++++++++++++++++++++++++++++++-
|
|
|
e71b65 |
2 files changed, 233 insertions(+), 1 deletion(-)
|
|
|
e71b65 |
|
|
|
e71b65 |
diff --git a/tests/Makefile b/tests/Makefile
|
|
|
e71b65 |
index 972a5e04..27e3ffa9 100644
|
|
|
e71b65 |
--- a/tests/Makefile
|
|
|
e71b65 |
+++ b/tests/Makefile
|
|
|
e71b65 |
@@ -33,6 +33,7 @@ ifneq ($(DIO_TEST_DEV),)
|
|
|
e71b65 |
directio-test_FLAGS := -DDIO_TEST_DEV=\"$(DIO_TEST_DEV)\"
|
|
|
e71b65 |
endif
|
|
|
e71b65 |
mpathvalid-test_FLAGS := -I$(mpathvaliddir)
|
|
|
e71b65 |
+features-test_FLAGS := -I$(multipathdir)/nvme
|
|
|
e71b65 |
|
|
|
e71b65 |
# test-specific linker flags
|
|
|
e71b65 |
# XYZ-test_TESTDEPS: test libraries containing __wrap_xyz functions
|
|
|
e71b65 |
@@ -64,6 +65,7 @@ ifneq ($(DIO_TEST_DEV),)
|
|
|
e71b65 |
directio-test_LIBDEPS := -laio
|
|
|
e71b65 |
endif
|
|
|
e71b65 |
strbuf-test_OBJDEPS := ../libmultipath/strbuf.o
|
|
|
e71b65 |
+features-test_LIBDEPS := -ludev -lpthread
|
|
|
e71b65 |
|
|
|
e71b65 |
%.o: %.c
|
|
|
e71b65 |
$(CC) $(CFLAGS) $($*-test_FLAGS) -c -o $@ $<
|
|
|
e71b65 |
diff --git a/tests/features.c b/tests/features.c
|
|
|
e71b65 |
index 4d8f0860..31f978fd 100644
|
|
|
e71b65 |
--- a/tests/features.c
|
|
|
e71b65 |
+++ b/tests/features.c
|
|
|
e71b65 |
@@ -1,9 +1,10 @@
|
|
|
e71b65 |
+#define _GNU_SOURCE
|
|
|
e71b65 |
#include <stddef.h>
|
|
|
e71b65 |
#include <stdarg.h>
|
|
|
e71b65 |
#include <setjmp.h>
|
|
|
e71b65 |
#include <cmocka.h>
|
|
|
e71b65 |
|
|
|
e71b65 |
-#include "structs.h"
|
|
|
e71b65 |
+#include "../libmultipath/propsel.c"
|
|
|
e71b65 |
#include "globals.c"
|
|
|
e71b65 |
|
|
|
e71b65 |
static void test_af_null_features_ptr(void **state)
|
|
|
e71b65 |
@@ -307,6 +308,234 @@ static int test_remove_features(void)
|
|
|
e71b65 |
return cmocka_run_group_tests(tests, NULL, NULL);
|
|
|
e71b65 |
}
|
|
|
e71b65 |
|
|
|
e71b65 |
+static void test_cf_null_features(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ struct multipath mp = {
|
|
|
e71b65 |
+ .alias = "test",
|
|
|
e71b65 |
+ };
|
|
|
e71b65 |
+ reconcile_features_with_queue_mode(&mp);
|
|
|
e71b65 |
+ assert_null(mp.features);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void cf_helper(const char *features_start, const char *features_end,
|
|
|
e71b65 |
+ int queue_mode_start, int queue_mode_end)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ struct multipath mp = {
|
|
|
e71b65 |
+ .alias = "test",
|
|
|
e71b65 |
+ .features = strdup(features_start),
|
|
|
e71b65 |
+ .queue_mode = queue_mode_start,
|
|
|
e71b65 |
+ };
|
|
|
e71b65 |
+ char *orig = mp.features;
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+ assert_non_null(orig);
|
|
|
e71b65 |
+ reconcile_features_with_queue_mode(&mp);
|
|
|
e71b65 |
+ if (!features_end)
|
|
|
e71b65 |
+ assert_ptr_equal(orig, mp.features);
|
|
|
e71b65 |
+ else
|
|
|
e71b65 |
+ assert_string_equal(mp.features, features_end);
|
|
|
e71b65 |
+ free(mp.features);
|
|
|
e71b65 |
+ assert_int_equal(mp.queue_mode, queue_mode_end);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_unset1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("0", NULL, QUEUE_MODE_UNDEF, QUEUE_MODE_UNDEF);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_unset2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("1 queue_mode", NULL, QUEUE_MODE_UNDEF, QUEUE_MODE_UNDEF);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_unset3(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("queue_mode", NULL, QUEUE_MODE_UNDEF, QUEUE_MODE_UNDEF);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_unset4(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_model bio", NULL, QUEUE_MODE_UNDEF,
|
|
|
e71b65 |
+ QUEUE_MODE_UNDEF);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_unset5(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("1 queue_if_no_path", NULL, QUEUE_MODE_UNDEF,
|
|
|
e71b65 |
+ QUEUE_MODE_UNDEF);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_invalid_unset1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_mode biop", "0", QUEUE_MODE_UNDEF, QUEUE_MODE_UNDEF);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_invalid_unset2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("3 queue_mode rqs queue_if_no_path", "1 queue_if_no_path",
|
|
|
e71b65 |
+ QUEUE_MODE_UNDEF, QUEUE_MODE_UNDEF);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_rq_unset1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_mode rq", NULL, QUEUE_MODE_UNDEF, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_rq_unset2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_mode mq", NULL, QUEUE_MODE_UNDEF, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_bio_unset(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_mode bio", NULL, QUEUE_MODE_UNDEF, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_bio1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("1 queue_if_no_path", "3 queue_if_no_path queue_mode bio",
|
|
|
e71b65 |
+ QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_bio2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("0", "2 queue_mode bio", QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_bio3(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 pg_init_retries 50", "4 pg_init_retries 50 queue_mode bio",
|
|
|
e71b65 |
+ QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_invalid_bio1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_mode bad", "2 queue_mode bio",
|
|
|
e71b65 |
+ QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_invalid_bio2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("3 queue_if_no_path queue_mode\tbad", "3 queue_if_no_path queue_mode bio",
|
|
|
e71b65 |
+ QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_bio_bio1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_mode bio", NULL, QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_bio_bio2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("3 queue_if_no_path queue_mode bio", NULL, QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_bio_bio3(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("3 queue_mode\nbio queue_if_no_path", NULL, QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_bio_rq1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2\nqueue_mode\tbio", "0", QUEUE_MODE_RQ, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_bio_rq2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("3 queue_if_no_path\nqueue_mode bio", "1 queue_if_no_path",
|
|
|
e71b65 |
+ QUEUE_MODE_RQ, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_bio_rq3(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("4 queue_mode bio pg_init_retries 20", "2 pg_init_retries 20",
|
|
|
e71b65 |
+ QUEUE_MODE_RQ, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_rq1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("0", NULL, QUEUE_MODE_RQ, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_unset_rq2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 pg_init_retries 15", NULL, QUEUE_MODE_RQ, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_invalid_rq1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_mode bionic", "0", QUEUE_MODE_RQ, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_invalid_rq2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("3 queue_mode b\nqueue_if_no_path", "1 queue_if_no_path",
|
|
|
e71b65 |
+ QUEUE_MODE_RQ, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_rq_rq1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_mode rq", NULL, QUEUE_MODE_RQ, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_rq_rq2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("3 queue_mode\t \trq\nqueue_if_no_path", NULL, QUEUE_MODE_RQ, QUEUE_MODE_RQ);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_rq_bio1(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("2 queue_mode rq", "2 queue_mode bio", QUEUE_MODE_BIO,
|
|
|
e71b65 |
+ QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_rq_bio2(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("3 queue_if_no_path\nqueue_mode rq", "3 queue_if_no_path queue_mode bio", QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static void test_cf_rq_bio3(void **state)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ cf_helper("3 queue_mode rq\nqueue_if_no_path", "3 queue_if_no_path queue_mode bio", QUEUE_MODE_BIO, QUEUE_MODE_BIO);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
+static int test_reconcile_features(void)
|
|
|
e71b65 |
+{
|
|
|
e71b65 |
+ const struct CMUnitTest tests[] = {
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_null_features),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_unset1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_unset2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_unset3),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_unset4),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_unset5),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_invalid_unset1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_invalid_unset2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_rq_unset1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_rq_unset2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_bio_unset),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_bio1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_bio2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_bio3),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_invalid_bio1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_invalid_bio2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_bio_bio1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_bio_bio2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_bio_bio3),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_bio_rq1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_bio_rq2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_bio_rq3),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_rq1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_unset_rq2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_invalid_rq1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_invalid_rq2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_rq_rq1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_rq_rq2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_rq_bio1),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_rq_bio2),
|
|
|
e71b65 |
+ cmocka_unit_test(test_cf_rq_bio3),
|
|
|
e71b65 |
+ };
|
|
|
e71b65 |
+ return cmocka_run_group_tests(tests, NULL, NULL);
|
|
|
e71b65 |
+}
|
|
|
e71b65 |
+
|
|
|
e71b65 |
int main(void)
|
|
|
e71b65 |
{
|
|
|
e71b65 |
int ret = 0;
|
|
|
e71b65 |
@@ -314,6 +543,7 @@ int main(void)
|
|
|
e71b65 |
init_test_verbosity(-1);
|
|
|
e71b65 |
ret += test_add_features();
|
|
|
e71b65 |
ret += test_remove_features();
|
|
|
e71b65 |
+ ret += test_reconcile_features();
|
|
|
e71b65 |
|
|
|
e71b65 |
return ret;
|
|
|
e71b65 |
}
|