Blame SOURCES/cups-browsed-memory-leaks.patch

4229be
diff --git a/cupsfilters/ppdgenerator.c b/cupsfilters/ppdgenerator.c
4229be
index 3bc4d8a..44d9313 100644
4229be
--- a/cupsfilters/ppdgenerator.c
4229be
+++ b/cupsfilters/ppdgenerator.c
4229be
@@ -752,12 +752,17 @@ load_opt_strings_catalog(const char *location, cups_array_t *options)
4229be
 		     2: "..." = "..."
4229be
 		    10: EOF, save last entry */
4229be
   int digit;
4229be
+  int found_in_catalog = 0;
4229be
 
4229be
   if (location == NULL || (strncasecmp(location, "http:", 5) &&
4229be
 			   strncasecmp(location, "https:", 6))) {
4229be
     if (location == NULL ||
4229be
 	(stat(location, &statbuf) == 0 && S_ISDIR(statbuf.st_mode))) /* directory? */
4229be
+    {
4229be
       filename = _findCUPSMessageCatalog(location);
4229be
+      if (filename)
4229be
+        found_in_catalog = 1;
4229be
+    }
4229be
     else
4229be
       filename = location;
4229be
   } else {
4229be
@@ -943,6 +948,8 @@ load_opt_strings_catalog(const char *location, cups_array_t *options)
4229be
     free(opt_name);
4229be
   if (filename == tmpfile)
4229be
     unlink(filename);
4229be
+  if (found_in_catalog)
4229be
+    free(filename);
4229be
 }
4229be
 
4229be
 
4229be
@@ -1417,10 +1424,16 @@ ppdCreateFromIPP(char   *buffer,	/* I - Filename buffer */
4229be
       } else {
4229be
 	if ((current_res = resolutionArrayNew()) != NULL) {
4229be
 	  if ((current_def = resolutionNew(lowdpi, lowdpi)) != NULL)
4229be
+          {
4229be
 	    cupsArrayAdd(current_res, current_def);
4229be
+            free_resolution(current_def, NULL);
4229be
+          }
4229be
 	  if (hidpi != lowdpi &&
4229be
 	      (current_def = resolutionNew(hidpi, hidpi)) != NULL)
4229be
+          {
4229be
 	    cupsArrayAdd(current_res, current_def);
4229be
+            free_resolution(current_def, NULL);
4229be
+          }
4229be
 	  current_def = NULL;
4229be
 	  if (cupsArrayCount(current_res) > 0 &&
4229be
 	      joinResolutionArrays(&common_res, &current_res, &common_def,
4229be
@@ -1506,7 +1519,10 @@ ppdCreateFromIPP(char   *buffer,	/* I - Filename buffer */
4229be
   if (common_res == NULL) {
4229be
     if ((common_res = resolutionArrayNew()) != NULL) {
4229be
       if ((current_def = resolutionNew(300, 300)) != NULL)
4229be
+      {
4229be
 	cupsArrayAdd(common_res, current_def);
4229be
+        free_resolution(current_def, NULL);
4229be
+      }
4229be
       current_def = NULL;
4229be
     } else
4229be
       goto bad_ppd;
4229be
diff --git a/utils/cups-browsed.c b/utils/cups-browsed.c
4229be
index 54ae2ac..507977c 100644
4229be
--- a/utils/cups-browsed.c
4229be
+++ b/utils/cups-browsed.c
4229be
@@ -2555,7 +2555,7 @@ record_printer_options(const char *printer) {
4229be
   const char *key;
4229be
   char buf[65536], *c;
4229be
   const char *ppdname = NULL;
4229be
-  ppd_file_t *ppd;
4229be
+  ppd_file_t *ppd = NULL;
4229be
   ppd_option_t *ppd_opt;
4229be
   cups_option_t *option;
4229be
   int i;
4229be
@@ -2825,7 +2825,8 @@ on_printer_state_changed (CupsNotifier *object,
4229be
   char *ptr, buf[1024];
4229be
   remote_printer_t *p, *q;
4229be
   http_t *http = NULL;
4229be
-  ipp_t *request, *response;
4229be
+  ipp_t *request = NULL;
4229be
+  ipp_t *response = NULL;
4229be
   ipp_attribute_t *attr;
4229be
   const char *pname = NULL;
4229be
   char *remote_cups_queue;
4229be
@@ -3107,6 +3108,10 @@ on_printer_state_changed (CupsNotifier *object,
4229be
 		  break;
4229be
 		}
4229be
 	      }
4229be
+              if (response) {
4229be
+                ippDelete(response);
4229be
+                response = NULL;
4229be
+              }
4229be
 	      if (pstate == IPP_PRINTER_IDLE && paccept) {
4229be
 		q->last_printer = i;
4229be
 		break;
4229be
@@ -3863,7 +3868,7 @@ create_remote_printer_entry (const char *queue_name,
4229be
 	debug_printf("Default page size: %s\n",
4229be
 		     default_page_size);
4229be
 	p->num_options = cupsAddOption("media-default",
4229be
-				       strdup(default_page_size),
4229be
+				       default_page_size,
4229be
 				       p->num_options, &(p->options));
4229be
       } else {
4229be
 	attr = ippFindAttribute(response,
4229be
@@ -3874,7 +3879,7 @@ create_remote_printer_entry (const char *queue_name,
4229be
 	  debug_printf("Default page size: %s\n",
4229be
 		       default_page_size);
4229be
 	  p->num_options = cupsAddOption("media-default",
4229be
-					 strdup(default_page_size),
4229be
+					 default_page_size,
4229be
 					 p->num_options, &(p->options));
4229be
 	} else
4229be
 	  debug_printf("No default page size found!\n");
4229be
@@ -3889,7 +3894,7 @@ create_remote_printer_entry (const char *queue_name,
4229be
 	bottom = 1270;
4229be
       snprintf(buffer, sizeof(buffer), "%d", bottom);
4229be
       p->num_options = cupsAddOption("media-bottom-margin-default",
4229be
-				     strdup(buffer),
4229be
+				     buffer,
4229be
 				     p->num_options, &(p->options));
4229be
 
4229be
       if ((attr = ippFindAttribute(response, "media-left-margin-supported", IPP_TAG_INTEGER)) != NULL) {
4229be
@@ -3900,7 +3905,7 @@ create_remote_printer_entry (const char *queue_name,
4229be
 	left = 635;
4229be
       snprintf(buffer, sizeof(buffer), "%d", left);
4229be
       p->num_options = cupsAddOption("media-left-margin-default",
4229be
-				     strdup(buffer),
4229be
+				     buffer,
4229be
 				     p->num_options, &(p->options));
4229be
 
4229be
       if ((attr = ippFindAttribute(response, "media-right-margin-supported", IPP_TAG_INTEGER)) != NULL) {
4229be
@@ -3911,7 +3916,7 @@ create_remote_printer_entry (const char *queue_name,
4229be
 	right = 635;
4229be
       snprintf(buffer, sizeof(buffer), "%d", right);
4229be
       p->num_options = cupsAddOption("media-right-margin-default",
4229be
-				     strdup(buffer),
4229be
+				     buffer,
4229be
 				     p->num_options, &(p->options));
4229be
 
4229be
       if ((attr = ippFindAttribute(response, "media-top-margin-supported", IPP_TAG_INTEGER)) != NULL) {
4229be
@@ -3922,7 +3927,7 @@ create_remote_printer_entry (const char *queue_name,
4229be
 	top = 1270;
4229be
       snprintf(buffer, sizeof(buffer), "%d", top);
4229be
       p->num_options = cupsAddOption("media-top-margin-default",
4229be
-				     strdup(buffer),
4229be
+				     buffer,
4229be
 				     p->num_options, &(p->options));
4229be
 
4229be
       debug_printf("Margins: Left: %d, Right: %d, Top: %d, Bottom: %d\n",
4229be
@@ -3943,7 +3948,7 @@ create_remote_printer_entry (const char *queue_name,
4229be
 	debug_printf("Best color space: %s\n",
4229be
 		     best_color_space);
4229be
 	p->num_options = cupsAddOption("print-color-mode-default",
4229be
-				       strdup(best_color_space),
4229be
+				       best_color_space,
4229be
 				       p->num_options, &(p->options));
4229be
       } else {
4229be
 	debug_printf("No info about supported color spaces found!\n");
4229be
@@ -3956,7 +3961,7 @@ create_remote_printer_entry (const char *queue_name,
4229be
 	p->num_options = cupsAddOption("sides-default", "two-sided-long-edge",
4229be
 				       p->num_options, &(p->options));
4229be
 	
4229be
-      p->num_options = cupsAddOption("output-format-default", strdup(pdl),
4229be
+      p->num_options = cupsAddOption("output-format-default", pdl,
4229be
 				     p->num_options, &(p->options));
4229be
       p->num_options = cupsAddOption("make-and-model-default",
4229be
 				     remove_bad_chars(make_model, 0),
4229be
@@ -4119,7 +4124,7 @@ gboolean update_cups_queues(gpointer unused) {
4229be
   char *disabled_str, *ptr, *prefix;
4229be
   const char *loadedppd = NULL;
4229be
   int pass_through_ppd;
4229be
-  ppd_file_t *ppd;
4229be
+  ppd_file_t *ppd = NULL;
4229be
   ppd_choice_t *choice;
4229be
   cups_file_t *in, *out;
4229be
   char keyword[1024], *keyptr;
4229be
@@ -4588,6 +4593,7 @@ gboolean update_cups_queues(gpointer unused) {
4229be
 	  p->timeout = current_time + TIMEOUT_RETRY;
4229be
 	  p->no_autosave = 0;
4229be
 	  ppdClose(ppd);
4229be
+          ppd = NULL;
4229be
 	  unlink(loadedppd);
4229be
 	  break;
4229be
 	}
4229be
@@ -4597,6 +4603,7 @@ gboolean update_cups_queues(gpointer unused) {
4229be
 	  p->no_autosave = 0;
4229be
 	  cupsFileClose(out);
4229be
 	  ppdClose(ppd);
4229be
+          ppd = NULL;
4229be
 	  unlink(loadedppd);
4229be
 	  break;
4229be
 	}
4229be
@@ -4710,6 +4717,7 @@ gboolean update_cups_queues(gpointer unused) {
4229be
 	cupsFileClose(in);
4229be
 	cupsFileClose(out);
4229be
 	ppdClose(ppd);
4229be
+        ppd = NULL;
4229be
 	unlink(loadedppd);
4229be
 	loadedppd = NULL;
4229be
 	if (p->ppd)
4229be
@@ -4748,8 +4756,8 @@ gboolean update_cups_queues(gpointer unused) {
4229be
       /* Default option settings from printer entry */
4229be
       for (i = 0; i < p->num_options; i ++)
4229be
 	if (strcasecmp(p->options[i].name, "printer-is-shared"))
4229be
-	  num_options = cupsAddOption(strdup(p->options[i].name),
4229be
-				      strdup(p->options[i].value),
4229be
+	  num_options = cupsAddOption(p->options[i].name,
4229be
+				      p->options[i].value,
4229be
 				      num_options, &options);
4229be
       /* Encode option list into IPP attributes */
4229be
       cupsEncodeOptions2(request, num_options, options, IPP_TAG_OPERATION);
4229be
@@ -8342,6 +8350,9 @@ fail:
4229be
 
4229be
   if (local_printers_context) {
4229be
     browse_poll_cancel_subscription (local_printers_context);
4229be
+#ifdef HAVE_CUPS_2_0
4229be
+    free(local_printers_context->server);
4229be
+#endif
4229be
     g_list_free_full (local_printers_context->printers,
4229be
 		      browsepoll_printer_free);
4229be
     free (local_printers_context);