|
 |
888cb5 |
From db8f53df0be1daeda3159c1413549ff40696c710 Mon Sep 17 00:00:00 2001
|
|
|
888cb5 |
From: David Malcolm <dmalcolm@redhat.com>
|
|
|
888cb5 |
Date: Thu, 2 Sep 2021 17:02:33 -0400
|
|
|
888cb5 |
Subject: [PATCH 16/17] Conditionalize test for hashtable bucket sizes on
|
|
|
888cb5 |
__LIBSTDCXX_SO_VERSION >= 11
|
|
|
888cb5 |
|
|
|
888cb5 |
These tests were added upstream 2020-01-20 as part of:
|
|
|
888cb5 |
libstdc++: Do not over-size hashtable buckets on range insertion
|
|
|
888cb5 |
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=6dcf042368012e2d7ce1626ee5d378bf3ad0ccfc
|
|
|
888cb5 |
|
|
|
888cb5 |
but fail when run in DTS against a system libstdc++.so from an older GCC.
|
|
|
888cb5 |
|
|
|
888cb5 |
In particular, _M_insert_unique_node from the header is using the older
|
|
|
888cb5 |
implementation of
|
|
|
888cb5 |
std::__detail::_Prime_rehash_policy::_M_need_rehash
|
|
|
888cb5 |
from the dynamic library.
|
|
|
888cb5 |
|
|
|
888cb5 |
23: 0000000000000000 0 FUNC GLOBAL DEFAULT UNDEF std::__detail::_Prime_rehash_policy::_M_need_rehash(unsigned long, unsigned long, unsigned long) const@GLIBCXX_3.4.18 (5)
|
|
|
888cb5 |
412: 0000000000000000 0 FUNC GLOBAL DEFAULT UNDEF std::__detail::_Prime_rehash_policy::_M_need_rehash(unsigned long, unsigned long, unsigned long) const@@GLIBCXX_3.4.18
|
|
|
888cb5 |
---
|
|
|
888cb5 |
.../23_containers/unordered_set/cons/bucket_hint.cc | 10 ++++++++++
|
|
|
888cb5 |
.../23_containers/unordered_set/modifiers/insert.cc | 9 +++++++++
|
|
|
888cb5 |
2 files changed, 19 insertions(+)
|
|
|
888cb5 |
|
|
|
888cb5 |
diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/cons/bucket_hint.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/cons/bucket_hint.cc
|
|
|
888cb5 |
index a3b014a3a..af231e54e 100644
|
|
|
888cb5 |
--- a/libstdc++-v3/testsuite/23_containers/unordered_set/cons/bucket_hint.cc
|
|
|
888cb5 |
+++ b/libstdc++-v3/testsuite/23_containers/unordered_set/cons/bucket_hint.cc
|
|
|
888cb5 |
@@ -29,7 +29,11 @@ void test01()
|
|
|
888cb5 |
a.reserve(2);
|
|
|
888cb5 |
|
|
|
888cb5 |
std::unordered_set<int> b({ 0, 1, 0, 1, 0, 1, 0, 1 }, a.bucket_count());
|
|
|
888cb5 |
+
|
|
|
888cb5 |
+ // Fixed upstream in GCC 11
|
|
|
888cb5 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
888cb5 |
VERIFY( b.bucket_count() == a.bucket_count() );
|
|
|
888cb5 |
+#endif
|
|
|
888cb5 |
}
|
|
|
888cb5 |
|
|
|
888cb5 |
void test02()
|
|
|
888cb5 |
@@ -40,7 +44,10 @@ void test02()
|
|
|
888cb5 |
std::vector<int> v { 0, 1, 0, 1, 0, 1, 0, 1, 0, 1 };
|
|
|
888cb5 |
|
|
|
888cb5 |
std::unordered_set<int> b(v.begin(), v.end(), a.bucket_count());
|
|
|
888cb5 |
+ // Fixed upstream in GCC 11
|
|
|
888cb5 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
888cb5 |
VERIFY( b.bucket_count() == a.bucket_count() );
|
|
|
888cb5 |
+#endif
|
|
|
888cb5 |
}
|
|
|
888cb5 |
|
|
|
888cb5 |
void test03()
|
|
|
888cb5 |
@@ -51,7 +58,10 @@ void test03()
|
|
|
888cb5 |
std::forward_list<int> fl { 0, 1, 0, 1, 0, 1, 0, 1, 0, 1 };
|
|
|
888cb5 |
|
|
|
888cb5 |
std::unordered_set<int> b(fl.begin(), fl.end(), a.bucket_count());
|
|
|
888cb5 |
+ // Fixed upstream in GCC 11
|
|
|
888cb5 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
888cb5 |
VERIFY( b.bucket_count() == a.bucket_count() );
|
|
|
888cb5 |
+#endif
|
|
|
888cb5 |
}
|
|
|
888cb5 |
|
|
|
888cb5 |
int main()
|
|
|
888cb5 |
diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/modifiers/insert.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/modifiers/insert.cc
|
|
|
888cb5 |
index 015c2f872..aae8298ae 100644
|
|
|
888cb5 |
--- a/libstdc++-v3/testsuite/23_containers/unordered_set/modifiers/insert.cc
|
|
|
888cb5 |
+++ b/libstdc++-v3/testsuite/23_containers/unordered_set/modifiers/insert.cc
|
|
|
888cb5 |
@@ -30,7 +30,10 @@ void test01()
|
|
|
888cb5 |
|
|
|
888cb5 |
auto bkt_count = a.bucket_count();
|
|
|
888cb5 |
a.insert({ 0, 1, 0, 1, 0, 1, 0, 1 });
|
|
|
888cb5 |
+ // Fixed upstream in GCC 11
|
|
|
888cb5 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
888cb5 |
VERIFY( a.bucket_count() == bkt_count );
|
|
|
888cb5 |
+#endif
|
|
|
888cb5 |
}
|
|
|
888cb5 |
|
|
|
888cb5 |
void test02()
|
|
|
888cb5 |
@@ -42,7 +45,10 @@ void test02()
|
|
|
888cb5 |
|
|
|
888cb5 |
auto bkt_count = a.bucket_count();
|
|
|
888cb5 |
a.insert(v.begin(), v.end());
|
|
|
888cb5 |
+ // Fixed upstream in GCC 11
|
|
|
888cb5 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
888cb5 |
VERIFY( a.bucket_count() == bkt_count );
|
|
|
888cb5 |
+#endif
|
|
|
888cb5 |
}
|
|
|
888cb5 |
|
|
|
888cb5 |
void test03()
|
|
|
888cb5 |
@@ -54,7 +60,10 @@ void test03()
|
|
|
888cb5 |
|
|
|
888cb5 |
auto bkt_count = a.bucket_count();
|
|
|
888cb5 |
a.insert(fl.begin(), fl.end());
|
|
|
888cb5 |
+ // Fixed upstream in GCC 11
|
|
|
888cb5 |
+#if __LIBSTDCXX_SO_VERSION >= 11
|
|
|
888cb5 |
VERIFY( a.bucket_count() == bkt_count );
|
|
|
888cb5 |
+#endif
|
|
|
888cb5 |
}
|
|
|
888cb5 |
|
|
|
888cb5 |
int main()
|
|
|
888cb5 |
--
|
|
|
888cb5 |
2.31.1
|
|
|
888cb5 |
|