Blame SOURCES/gcc10-foffload-default.patch

689ae3
2019-01-17  Jakub Jelinek  <jakub@redhat.com>
689ae3
689ae3
	* gcc.c (offload_targets_default): New variable.
689ae3
	(process_command): Set it if -foffload is defaulted.
689ae3
	(driver::maybe_putenv_OFFLOAD_TARGETS): Add OFFLOAD_TARGET_DEFAULT=1
689ae3
	into environment if -foffload has been defaulted.
689ae3
	* lto-wrapper.c (OFFLOAD_TARGET_DEFAULT_ENV): Define.
689ae3
	(compile_offload_image): If OFFLOAD_TARGET_DEFAULT
689ae3
	is in the environment, don't fail if corresponding mkoffload
689ae3
	can't be found.
689ae3
	(compile_images_for_offload_targets): Likewise.  Free and clear
689ae3
	offload_names if no valid offload is found.
689ae3
libgomp/
689ae3
	* target.c (gomp_load_plugin_for_device): If a plugin can't be
689ae3
	dlopened, assume it has no devices silently.
689ae3
689ae3
--- gcc/gcc.c.jj	2017-01-17 10:28:40.000000000 +0100
689ae3
+++ gcc/gcc.c	2017-01-20 16:26:29.649962902 +0100
689ae3
@@ -290,6 +290,10 @@ static const char *spec_host_machine = D
689ae3
 
689ae3
 static char *offload_targets = NULL;
689ae3
 
689ae3
+/* Set to true if -foffload has not been used and offload_targets
689ae3
+   is set to the configured in default.  */
689ae3
+static bool offload_targets_default;
689ae3
+
689ae3
 /* Nonzero if cross-compiling.
689ae3
    When -b is used, the value comes from the `specs' file.  */
689ae3
 
689ae3
@@ -4457,7 +4461,10 @@ process_command (unsigned int decoded_op
689ae3
   /* If the user didn't specify any, default to all configured offload
689ae3
      targets.  */
689ae3
   if (ENABLE_OFFLOADING && offload_targets == NULL)
689ae3
-    handle_foffload_option (OFFLOAD_TARGETS);
689ae3
+    {
689ae3
+      handle_foffload_option (OFFLOAD_TARGETS);
689ae3
+      offload_targets_default = true;
689ae3
+    }
689ae3
 
689ae3
   if (output_file
689ae3
       && strcmp (output_file, "-") != 0
689ae3
@@ -7693,6 +7700,8 @@ driver::maybe_putenv_OFFLOAD_TARGETS ()
689ae3
       obstack_grow (&collect_obstack, offload_targets,
689ae3
 		    strlen (offload_targets) + 1);
689ae3
       xputenv (XOBFINISH (&collect_obstack, char *));
689ae3
+      if (offload_targets_default)
689ae3
+	  xputenv ("OFFLOAD_TARGET_DEFAULT=1");
689ae3
     }
689ae3
 
689ae3
   free (offload_targets);
689ae3
--- gcc/lto-wrapper.c.jj	2017-01-01 12:45:34.000000000 +0100
689ae3
+++ gcc/lto-wrapper.c	2017-01-20 16:34:18.294016997 +0100
689ae3
@@ -52,6 +52,7 @@ along with GCC; see the file COPYING3.
689ae3
 /* Environment variable, used for passing the names of offload targets from GCC
689ae3
    driver to lto-wrapper.  */
689ae3
 #define OFFLOAD_TARGET_NAMES_ENV	"OFFLOAD_TARGET_NAMES"
689ae3
+#define OFFLOAD_TARGET_DEFAULT_ENV	"OFFLOAD_TARGET_DEFAULT"
689ae3
 
689ae3
 enum lto_mode_d {
689ae3
   LTO_MODE_NONE,			/* Not doing LTO.  */
689ae3
@@ -822,6 +823,12 @@ compile_offload_image (const char *targe
689ae3
 	break;
689ae3
       }
689ae3
 
689ae3
+  if (!compiler && getenv (OFFLOAD_TARGET_DEFAULT_ENV))
689ae3
+    {
689ae3
+      free_array_of_ptrs ((void **) paths, n_paths);
689ae3
+      return NULL;
689ae3
+    }
689ae3
+
689ae3
   if (!compiler)
689ae3
     fatal_error (input_location,
689ae3
 		 "could not find %s in %s (consider using %<-B%>)",
689ae3
@@ -885,6 +892,7 @@ compile_images_for_offload_targets (unsi
689ae3
   unsigned num_targets = parse_env_var (target_names, &names, NULL);
689ae3
 
689ae3
   int next_name_entry = 0;
689ae3
+  bool hsa_seen = false;
689ae3
   const char *compiler_path = getenv ("COMPILER_PATH");
689ae3
   if (!compiler_path)
689ae3
     goto out;
689ae3
@@ -897,18 +905,26 @@ compile_images_for_offload_targets (unsi
689ae3
       /* HSA does not use LTO-like streaming and a different compiler, skip
689ae3
 	 it. */
689ae3
       if (strcmp (names[i], "hsa") == 0)
689ae3
-	continue;
689ae3
+	{
689ae3
+	  hsa_seen = true;
689ae3
+	  continue;
689ae3
+	}
689ae3
 
689ae3
       offload_names[next_name_entry]
689ae3
 	= compile_offload_image (names[i], compiler_path, in_argc, in_argv,
689ae3
 				 compiler_opts, compiler_opt_count,
689ae3
 				 linker_opts, linker_opt_count);
689ae3
       if (!offload_names[next_name_entry])
689ae3
-	fatal_error (input_location,
689ae3
-		     "problem with building target image for %s", names[i]);
689ae3
+	continue;
689ae3
       next_name_entry++;
689ae3
     }
689ae3
 
689ae3
+  if (next_name_entry == 0 && !hsa_seen)
689ae3
+    {
689ae3
+      free (offload_names);
689ae3
+      offload_names = NULL;
689ae3
+    }
689ae3
+
689ae3
  out:
689ae3
   free_array_of_ptrs ((void **) names, num_targets);
689ae3
 }
689ae3
--- libgomp/target.c.jj	2017-01-01 12:45:52.000000000 +0100
689ae3
+++ libgomp/target.c	2017-01-20 20:12:13.756710875 +0100
689ae3
@@ -2356,7 +2356,7 @@ gomp_load_plugin_for_device (struct gomp
689ae3
 
689ae3
   void *plugin_handle = dlopen (plugin_name, RTLD_LAZY);
689ae3
   if (!plugin_handle)
689ae3
-    goto dl_fail;
689ae3
+    return 0;
689ae3
 
689ae3
   /* Check if all required functions are available in the plugin and store
689ae3
      their handlers.  None of the symbols can legitimately be NULL,