--- binutils.orig/bfd/archive.c	2019-10-04 15:26:08.544327573 +0100

+++ binutils-2.30/bfd/archive.c	2019-10-04 16:58:45.088039134 +0100

@@ -734,6 +734,9 @@ _bfd_get_elt_at_filepos (bfd *archive, f

   /* Copy is_linker_input.  */

   n_bfd->is_linker_input = archive->is_linker_input;

+  /* Coverity does not realise that _bfd_add_bfd_to_archive_cache actually

+     stores the newly created bfd and so flags a resource leak.  */

+  /* coverity[noescape: FALSE] */

   if (_bfd_add_bfd_to_archive_cache (archive, filepos, n_bfd))

     return n_bfd;

diff -rup binutils.orig/bfd/coffcode.h binutils-2.30/bfd/coffcode.h

--- binutils.orig/bfd/coffcode.h	2019-10-07 15:49:39.425618524 +0100

+++ binutils-2.30/bfd/coffcode.h	2019-10-07 15:53:18.335157361 +0100

@@ -3737,6 +3737,9 @@ coff_write_object_contents (bfd * abfd)

       internal_f.f_nscns++;

+      /* Coverity flags this strncpy as possibly creating a string

+	 that is not NUL terminated.  This is in fact OK.  */

+      /* coverity[buffer_size_warning: FALSE] */

       strncpy (section.s_name, current->name, SCNNMLEN);

 #ifdef COFF_LONG_SECTION_NAMES

@@ -3775,6 +3778,9 @@ coff_write_object_contents (bfd * abfd)

 		 buffer, just in case.  */

 	      sprintf (s_name_buf, "/%lu", (unsigned long) string_size);

 	      /* Then strncpy takes care of any padding for us.  */

+	      /* Coverity flags this strncpy as possibly creating a string

+		 that is not NUL terminated.  This is in fact OK.  */

+	      /* coverity[buffer_size_warning: FALSE] */

 	      strncpy (section.s_name, s_name_buf, SCNNMLEN);

 	      string_size += len + 1;

 	      long_section_names = TRUE;

diff -rup binutils.orig/bfd/coffgen.c binutils-2.30/bfd/coffgen.c

--- binutils.orig/bfd/coffgen.c	2019-10-07 15:49:37.845629069 +0100

+++ binutils-2.30/bfd/coffgen.c	2019-10-07 15:53:46.443969714 +0100

@@ -923,6 +923,9 @@ coff_fix_symbol_name (bfd *abfd,

     {

       if (name_length <= SYMNMLEN && !bfd_coff_force_symnames_in_strings (abfd))

 	/* This name will fit into the symbol neatly.  */

+	/* Coverity flags this strncpy as possibly creating a string

+	   that is not NUL terminated.  This is in fact OK.  */

+	/* coverity[buffer_size_warning: FALSE] */

 	strncpy (native->u.syment._n._n_name, symbol->name, SYMNMLEN);

       else if (!bfd_coff_symname_in_debug (abfd, &native->u.syment))

diff -rup binutils.orig/bfd/cofflink.c binutils-2.30/bfd/cofflink.c

--- binutils.orig/bfd/cofflink.c	2019-10-07 15:49:37.565630938 +0100

+++ binutils-2.30/bfd/cofflink.c	2019-10-07 15:54:21.177736099 +0100

@@ -2633,6 +2633,9 @@ _bfd_coff_write_global_sym (struct bfd_h

     }

   if (strlen (h->root.root.string) <= SYMNMLEN)

+    /* Coverity flags this strncpy as possibly creating a string

+       that is not NUL terminated.  This is in fact OK.  */

+    /* coverity[buffer_size_warning: FALSE] */

     strncpy (isym._n._n_name, h->root.root.string, SYMNMLEN);

   else

     {

diff -rup binutils.orig/bfd/elf64-x86-64.c binutils-2.30/bfd/elf64-x86-64.c

--- binutils.orig/bfd/elf64-x86-64.c	2019-10-07 15:49:38.144627073 +0100

+++ binutils-2.30/bfd/elf64-x86-64.c	2019-10-07 15:56:53.559674302 +0100

@@ -463,7 +463,13 @@ elf_x86_64_write_core_note (bfd *abfd, c

 	{

 	  prpsinfo32_t data;

 	  memset (&data, 0, sizeof (data));

+	  /* Coverity flags this strncpy as possibly creating a string

+	     that is not NUL terminated.  This is in fact OK.  */

+	  /* coverity[buffer_size_warning: FALSE] */

 	  strncpy (data.pr_fname, fname, sizeof (data.pr_fname));

+	  /* Coverity flags this strncpy as possibly creating a string

+	     that is not NUL terminated.  This is in fact OK.  */

+	  /* coverity[buffer_size_warning: FALSE] */

 	  strncpy (data.pr_psargs, psargs, sizeof (data.pr_psargs));

 	  return elfcore_write_note (abfd, buf, bufsiz, "CORE", note_type,

 				     &data, sizeof (data));

@@ -472,7 +478,13 @@ elf_x86_64_write_core_note (bfd *abfd, c

 	{

 	  prpsinfo64_t data;

 	  memset (&data, 0, sizeof (data));

+	  /* Coverity flags this strncpy as possibly creating a string

+	     that is not NUL terminated.  This is in fact OK.  */

+	  /* coverity[buffer_size_warning: FALSE] */

 	  strncpy (data.pr_fname, fname, sizeof (data.pr_fname));

+	  /* Coverity flags this strncpy as possibly creating a string

+	     that is not NUL terminated.  This is in fact OK.  */

+	  /* coverity[buffer_size_warning: FALSE] */

 	  strncpy (data.pr_psargs, psargs, sizeof (data.pr_psargs));

 	  return elfcore_write_note (abfd, buf, bufsiz, "CORE", note_type,

 				     &data, sizeof (data));

diff -rup binutils.orig/bfd/elf.c binutils-2.30/bfd/elf.c

--- binutils.orig/bfd/elf.c	2019-10-07 15:49:37.616630597 +0100

+++ binutils-2.30/bfd/elf.c	2019-10-07 15:56:16.776930603 +0100

@@ -10549,7 +10549,13 @@ elfcore_write_prpsinfo (bfd  *abfd,

 #endif

       memset (&data, 0, sizeof (data));

+      /* Coverity flags this strncpy as possibly creating a string

+	 that is not NUL terminated.  This is in fact OK.  */

+      /* coverity[buffer_size_warning: FALSE] */

       strncpy (data.pr_fname, fname, sizeof (data.pr_fname));

+      /* Coverity flags this strncpy as possibly creating a string

+	 that is not NUL terminated.  This is in fact OK.  */

+      /* coverity[buffer_size_warning: FALSE] */

       strncpy (data.pr_psargs, psargs, sizeof (data.pr_psargs));

       return elfcore_write_note (abfd, buf, bufsiz,

 				 "CORE", note_type, &data, sizeof (data));

@@ -10566,7 +10572,13 @@ elfcore_write_prpsinfo (bfd  *abfd,

 #endif

       memset (&data, 0, sizeof (data));

+      /* Coverity flags this strncpy as possibly creating a string

+	 that is not NUL terminated.  This is in fact OK.  */

+      /* coverity[buffer_size_warning: FALSE] */

       strncpy (data.pr_fname, fname, sizeof (data.pr_fname));

+      /* Coverity flags this strncpy as possibly creating a string

+	 that is not NUL terminated.  This is in fact OK.  */

+      /* coverity[buffer_size_warning: FALSE] */

       strncpy (data.pr_psargs, psargs, sizeof (data.pr_psargs));

       return elfcore_write_note (abfd, buf, bufsiz,

 				 "CORE", note_type, &data, sizeof (data));

diff -rup binutils.orig/bfd/elf-linux-core.h binutils-2.30/bfd/elf-linux-core.h

--- binutils.orig/bfd/elf-linux-core.h	2019-10-07 15:49:37.744629743 +0100

+++ binutils-2.30/bfd/elf-linux-core.h	2019-10-07 15:55:43.976159158 +0100

@@ -69,7 +69,13 @@ swap_linux_prpsinfo32_ugid32_out

   bfd_put_32 (obfd, from->pr_ppid, to->pr_ppid);

   bfd_put_32 (obfd, from->pr_pgrp, to->pr_pgrp);

   bfd_put_32 (obfd, from->pr_sid, to->pr_sid);

+  /* Coverity flags this strncpy as possibly creating a string

+     that is not NUL terminated.  This is in fact OK.  */

+  /* coverity[buffer_size_warning: FALSE] */

   strncpy (to->pr_fname, from->pr_fname, sizeof (to->pr_fname));

+  /* Coverity flags this strncpy as possibly creating a string

+     that is not NUL terminated.  This is in fact OK.  */

+  /* coverity[buffer_size_warning: FALSE] */

   strncpy (to->pr_psargs, from->pr_psargs, sizeof (to->pr_psargs));

 }

@@ -121,7 +127,13 @@ swap_linux_prpsinfo32_ugid16_out

   bfd_put_32 (obfd, from->pr_ppid, to->pr_ppid);

   bfd_put_32 (obfd, from->pr_pgrp, to->pr_pgrp);

   bfd_put_32 (obfd, from->pr_sid, to->pr_sid);

+  /* Coverity flags this strncpy as possibly creating a string

+     that is not NUL terminated.  This is in fact OK.  */

+  /* coverity[buffer_size_warning: FALSE] */

   strncpy (to->pr_fname, from->pr_fname, sizeof (to->pr_fname));

+  /* Coverity flags this strncpy as possibly creating a string

+     that is not NUL terminated.  This is in fact OK.  */

+  /* coverity[buffer_size_warning: FALSE] */

   strncpy (to->pr_psargs, from->pr_psargs, sizeof (to->pr_psargs));

 }

@@ -174,7 +186,13 @@ swap_linux_prpsinfo64_ugid32_out

   bfd_put_32 (obfd, from->pr_ppid, to->pr_ppid);

   bfd_put_32 (obfd, from->pr_pgrp, to->pr_pgrp);

   bfd_put_32 (obfd, from->pr_sid, to->pr_sid);

+  /* Coverity flags this strncpy as possibly creating a string

+     that is not NUL terminated.  This is in fact OK.  */

+  /* coverity[buffer_size_warning: FALSE] */

   strncpy (to->pr_fname, from->pr_fname, sizeof (to->pr_fname));

+  /* Coverity flags this strncpy as possibly creating a string

+     that is not NUL terminated.  This is in fact OK.  */

+  /* coverity[buffer_size_warning: FALSE] */

   strncpy (to->pr_psargs, from->pr_psargs, sizeof (to->pr_psargs));

 }

@@ -227,7 +245,13 @@ swap_linux_prpsinfo64_ugid16_out

   bfd_put_32 (obfd, from->pr_ppid, to->pr_ppid);

   bfd_put_32 (obfd, from->pr_pgrp, to->pr_pgrp);

   bfd_put_32 (obfd, from->pr_sid, to->pr_sid);

+  /* Coverity flags this strncpy as possibly creating a string

+     that is not NUL terminated.  This is in fact OK.  */

+  /* coverity[buffer_size_warning: FALSE] */

   strncpy (to->pr_fname, from->pr_fname, sizeof (to->pr_fname));

+  /* Coverity flags this strncpy as possibly creating a string

+     that is not NUL terminated.  This is in fact OK.  */

+  /* coverity[buffer_size_warning: FALSE] */

   strncpy (to->pr_psargs, from->pr_psargs, sizeof (to->pr_psargs));

 }

diff -rup binutils.orig/bfd/peXXigen.c binutils-2.30/bfd/peXXigen.c

--- binutils.orig/bfd/peXXigen.c	2019-10-07 15:49:37.695630070 +0100

+++ binutils-2.30/bfd/peXXigen.c	2019-10-07 16:02:02.117524278 +0100

@@ -385,7 +385,7 @@ _bfd_XXi_swap_aux_out (bfd *  abfd,

 	  H_PUT_32 (abfd, in->x_file.x_n.x_offset, ext->x_file.x_n.x_offset);

 	}

       else

-	memcpy (ext->x_file.x_fname, in->x_file.x_fname, FILNMLEN);

+	memcpy (ext->x_file.x_fname, in->x_file.x_fname, E_FILNMLEN);

       return AUXESZ;

diff -rup binutils.orig/ld/pe-dll.c binutils-2.30/ld/pe-dll.c

--- binutils.orig/ld/pe-dll.c	2019-10-07 15:48:49.851949423 +0100

+++ binutils-2.30/ld/pe-dll.c	2019-10-07 16:04:09.055639773 +0100

@@ -2929,7 +2929,7 @@ pe_find_cdecl_alias_match (struct bfd_li

 	  if (pe_details->underscored)

 	    lname[0] = '_';

 	  else

-	    strcpy (lname, lname + 1);

+	    memmove (lname, lname + 1, strlen (lname) + 1);

 	  key.key = lname;

 	  kv = bsearch (&key, udef_table, undef_count,

 			sizeof (struct key_value), undef_sort_cmp);

diff -rup binutils.orig/libiberty/sha1.c binutils-2.30/libiberty/sha1.c

--- binutils.orig/libiberty/sha1.c	2019-10-07 15:49:37.016634602 +0100

+++ binutils-2.30/libiberty/sha1.c	2019-10-07 16:04:41.788411691 +0100

@@ -258,7 +258,7 @@ sha1_process_bytes (const void *buffer,

 	{

 	  sha1_process_block (ctx->buffer, 64, ctx);

 	  left_over -= 64;

-	  memcpy (ctx->buffer, &ctx->buffer[16], left_over);

+	  memmove (ctx->buffer, &ctx->buffer[16], left_over);

 	}

       ctx->buflen = left_over;

     }

diff -rup binutils.orig/bfd/cofflink.c binutils-2.30/bfd/cofflink.c

--- binutils.orig/bfd/cofflink.c	2019-10-07 17:01:58.787679337 +0100

+++ binutils-2.30/bfd/cofflink.c	2019-10-07 17:02:20.641529805 +0100

@@ -1406,6 +1406,8 @@ mark_relocs (struct coff_final_link_info

       for (; irel < irelend; irel++)

 	if ((unsigned long) irel->r_symndx < obj_raw_syment_count (input_bfd))

 	  flaginfo->sym_indices[irel->r_symndx] = -1;

+      /* There is a potential resource leak here, but it is not important.  */

+      /* coverity[leaked_storage: FALSE] */

     }

 }

diff -rup binutils.orig/bfd/doc/chew.c binutils-2.30/bfd/doc/chew.c

--- binutils.orig/bfd/doc/chew.c	2019-10-07 17:01:58.796679276 +0100

+++ binutils-2.30/bfd/doc/chew.c	2019-10-07 17:04:21.265720634 +0100

@@ -1264,6 +1264,7 @@ free_words (void)

 	    if (ptr->code[i] == push_text

 		&& ptr->code[i + 1])

 	      {

+		/* coverity[fnptr_free: FALSE] */

 		free (ptr->code[i + 1] - 1);

 		++ i;

 	      }

@@ -1387,6 +1388,7 @@ compile (string)

 	  ptr = newentry (word);

 	  string = nextword (string, &word);

+	  /* coverity[use_after_free: FALSE] */

 	  while (word[0] != ';')

 	    {

 	      switch (word[0])

diff -rup binutils.orig/bfd/elflink.c binutils-2.30/bfd/elflink.c

--- binutils.orig/bfd/elflink.c	2019-10-07 17:01:58.779679392 +0100

+++ binutils-2.30/bfd/elflink.c	2019-10-07 17:04:57.025483171 +0100

@@ -10579,6 +10579,8 @@ elf_link_input_bfd (struct elf_final_lin

 			   "that references a non-existent global symbol"),

 			 input_bfd, rel->r_info, o);

 		      bfd_set_error (bfd_error_bad_value);

+		      /* There is a potential resource leak here, but it is not important.  */

+		      /* coverity[leaked_storage: FALSE] */

 		      return FALSE;

 		    }

diff -rup binutils.orig/bfd/peXXigen.c binutils-2.30/bfd/peXXigen.c

--- binutils.orig/bfd/peXXigen.c	2019-10-07 17:01:58.784679358 +0100

+++ binutils-2.30/bfd/peXXigen.c	2019-10-07 17:07:22.047520136 +0100

@@ -385,7 +385,9 @@ _bfd_XXi_swap_aux_out (bfd *  abfd,

 	  H_PUT_32 (abfd, in->x_file.x_n.x_offset, ext->x_file.x_n.x_offset);

 	}

       else

-	memcpy (ext->x_file.x_fname, in->x_file.x_fname, E_FILNMLEN);

+	/* Coverity gets confused about the size of these buffers.  */

+	/* coverity[buffer_size: FALSE] */

+	memcpy (ext->x_file.x_fname, in->x_file.x_fname, FILNMLEN);

       return AUXESZ;

@@ -4343,6 +4345,8 @@ rsrc_process_section (bfd * abfd,

   /* FIXME: Free the resource tree, if we have one.  */

   free (datastart);

   free (rsrc_sizes);

+  /* There is a potential resource leak here, but it is not important.  */

+  /* coverity[leaked_storage: FALSE] */

 }

 /* Handle the .idata section and other things that need symbol table

diff -rup binutils.orig/bfd/plugin.c binutils-2.30/bfd/plugin.c

--- binutils.orig/bfd/plugin.c	2019-10-07 17:01:58.780679385 +0100

+++ binutils-2.30/bfd/plugin.c	2019-10-07 17:07:45.871361935 +0100

@@ -403,9 +403,13 @@ try_load_plugin (const char *pname, bfd

   abfd->plugin_format = bfd_plugin_yes;

+  /* There is a potential resource leak here, but it is not important.  */

+  /* coverity[leaked_storage: FALSE] */

   return 1;

  err:

+  /* There is a potential resource leak here, but it is not important.  */

+  /* coverity[leaked_storage: FALSE] */

   return 0;

 }

diff -rup binutils.orig/bfd/stabs.c binutils-2.30/bfd/stabs.c

--- binutils.orig/bfd/stabs.c	2019-10-07 17:01:58.778679399 +0100

+++ binutils-2.30/bfd/stabs.c	2019-10-07 17:08:14.655170795 +0100

@@ -377,6 +377,8 @@ _bfd_link_section_stabs (bfd *abfd,

 	  amt = sizeof *ne;

 	  ne = (struct stab_excl_list *) bfd_alloc (abfd, amt);

 	  if (ne == NULL)

+	    /* There is a potential resource leak here, but it is not important.  */

+	    /* coverity[leaked_storage: FALSE] */

 	    goto error_return;

 	  ne->offset = sym - stabbuf;

 	  ne->val = sum_chars;

diff -rup binutils.orig/binutils/ar.c binutils-2.30/binutils/ar.c

--- binutils.orig/binutils/ar.c	2019-10-07 17:01:57.998684736 +0100

+++ binutils-2.30/binutils/ar.c	2019-10-07 17:10:18.109350993 +0100

@@ -228,6 +228,8 @@ map_over_members (bfd *arch, void (*func

 	      filename = normalize (filename, arch);

 	    }

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  if (filename != NULL

 	      && !FILENAME_CMP (normalize (*files, arch), filename))

 	    {

@@ -237,6 +239,8 @@ map_over_members (bfd *arch, void (*func

 		{

 		  /* Counting, and didn't match on count; go on to the

                      next one.  */

+		  /* There is a potential resource leak here, but it is not important.  */

+		  /* coverity[leaked_storage: FALSE] */

 		  continue;

 		}

@@ -250,6 +254,8 @@ map_over_members (bfd *arch, void (*func

 		 to the ar command.  */

 	      break;

 	    }

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	}

       if (!found)

@@ -1268,6 +1274,8 @@ delete_members (bfd *arch, char **files_

       current_ptr_ptr = &(arch->archive_next);

       while (*current_ptr_ptr)

 	{

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  if (FILENAME_CMP (normalize (*files_to_delete, arch),

 			    (*current_ptr_ptr)->filename) == 0)

 	    {

@@ -1323,6 +1331,8 @@ move_members (bfd *arch, char **files_to

       while (*current_ptr_ptr)

 	{

 	  bfd *current_ptr = *current_ptr_ptr;

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  if (FILENAME_CMP (normalize (*files_to_move, arch),

 			    current_ptr->filename) == 0)

 	    {

@@ -1375,6 +1385,8 @@ replace_members (bfd *arch, char **files

 	      /* For compatibility with existing ar programs, we

 		 permit the same file to be added multiple times.  */

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      if (FILENAME_CMP (normalize (*files_to_move, arch),

 				normalize (current->filename, arch)) == 0

 		  && current->arelt_data != NULL)

diff -rup binutils.orig/binutils/arparse.c binutils-2.30/binutils/arparse.c

--- binutils.orig/binutils/arparse.c	2019-10-07 17:01:58.003684702 +0100

+++ binutils-2.30/binutils/arparse.c	2019-10-07 17:10:55.998099392 +0100

@@ -1193,6 +1193,8 @@ yyparse (void)

 #  undef YYSTACK_RELOCATE

         if (yyss1 != yyssa)

           YYSTACK_FREE (yyss1);

+	/* There is a potential resource leak here, but it is not important.  */

+	/* coverity[leaked_storage: FALSE] */

       }

 # endif

 #endif /* no yyoverflow */

diff -rup binutils.orig/binutils/arsup.c binutils-2.30/binutils/arsup.c

--- binutils.orig/binutils/arsup.c	2019-10-07 17:01:58.006684681 +0100

+++ binutils-2.30/binutils/arsup.c	2019-10-07 17:11:21.789928112 +0100

@@ -209,6 +209,8 @@ ar_open (char *name, int t)

       obfd->has_armap = 1;

       obfd->is_thin_archive = 0;

     }

+  /* There is a potential resource leak here, but it is not important.  */

+  /* coverity[leaked_storage: FALSE] */

 }

 static void

diff -rup binutils.orig/binutils/dwarf.c binutils-2.30/binutils/dwarf.c

--- binutils.orig/binutils/dwarf.c	2019-10-07 17:01:57.958685010 +0100

+++ binutils-2.30/binutils/dwarf.c	2019-10-07 17:13:31.950063779 +0100

@@ -4098,6 +4098,8 @@ display_debug_lines_decoded (struct dwar

 	      if (data == end)

 		{

 		  warn (_("Corrupt file name list\n"));

+		  /* There is a potential resource leak here, but it is not important.  */

+		  /* coverity[leaked_storage: FALSE] */

 		  break;

 		}

@@ -4234,6 +4236,8 @@ display_debug_lines_decoded (struct dwar

 		    {

 		      warn (_("file table ends unexpectedly\n"));

 		      n_files = 0;

+		      /* There is a potential resource leak here, but it is not important.  */

+		      /* coverity[leaked_storage: FALSE] */

 		      break;

 		    }

@@ -7231,6 +7235,8 @@ read_cie (unsigned char *start, unsigned

   if (start == end)

     {

       warn (_("No terminator for augmentation name\n"));

+      /* There is a potential resource leak here, but it is not important.  */

+      /* coverity[leaked_storage: FALSE] */

       return start;

     }

@@ -7243,6 +7249,8 @@ read_cie (unsigned char *start, unsigned

       if (fc->ptr_size < 1 || fc->ptr_size > 8)

 	{

 	  warn (_("Invalid pointer size (%d) in CIE data\n"), fc->ptr_size);

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return end;

 	}

@@ -7251,6 +7259,8 @@ read_cie (unsigned char *start, unsigned

       if (fc->segment_size > 8 || fc->segment_size + fc->ptr_size > 8)

 	{

 	  warn (_("Invalid segment size (%d) in CIE data\n"), fc->segment_size);

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return end;

 	}

@@ -8305,6 +8315,8 @@ display_debug_frames (struct dwarf_secti

   printf ("\n");

+  /* There is a potential resource leak here, but it is not important.  */

+  /* coverity[leaked_storage: FALSE] */

   return 1;

 }

@@ -9733,6 +9745,8 @@ load_separate_debug_info (const char *

   if (debugfile == NULL)

     {

       warn (_("Out of memory"));

+      /* There is a potential resource leak here, but it is not important.  */

+      /* coverity[leaked_storage: FALSE] */

       return NULL;

     }

diff -rup binutils.orig/binutils/elfedit.c binutils-2.30/binutils/elfedit.c

--- binutils.orig/binutils/elfedit.c	2019-10-07 17:01:58.000684722 +0100

+++ binutils-2.30/binutils/elfedit.c	2019-10-07 17:13:51.916931183 +0100

@@ -468,6 +468,8 @@ process_archive (const char * file_name,

         }

       free (qualified_name);

+      /* There is a potential resource leak here, but it is not important.  */

+      /* coverity[leaked_storage: FALSE] */

     }

  out:

diff -rup binutils.orig/binutils/ieee.c binutils-2.30/binutils/ieee.c

--- binutils.orig/binutils/ieee.c	2019-10-07 17:01:57.963684975 +0100

+++ binutils-2.30/binutils/ieee.c	2019-10-07 17:18:54.442922250 +0100

@@ -1503,6 +1503,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	    bfd_boolean present;

 	    if (! ieee_read_optional_id (info, pp, &name, &namlen, &present))

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    if (! present)

 	      break;

@@ -1516,6 +1518,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	    names[c] = savestring (name, namlen);

 	    if (names[c] == NULL)

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    ++c;

 	  }

@@ -1554,12 +1558,16 @@ parse_ieee_ty (struct ieee_info *info, c

 	    bfd_vma bitpos, bitsize;

 	    if (! ieee_read_optional_id (info, pp, &name, &namlen, &present))

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    if (! present)

 	      break;

 	    if (! ieee_read_type_index (info, pp, &ftype)

 		|| ! ieee_read_number (info, pp, &bitpos)

 		|| ! ieee_read_number (info, pp, &bitsize))

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    if (c + 1 >= alloc)

@@ -1573,6 +1581,8 @@ parse_ieee_ty (struct ieee_info *info, c

 					  ftype, bitpos, bitsize,

 					  DEBUG_VISIBILITY_PUBLIC);

 	    if (fields[c] == NULL)

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    ++c;

 	  }

@@ -1604,10 +1614,14 @@ parse_ieee_ty (struct ieee_info *info, c

 	    bfd_vma val;

 	    if (! ieee_read_optional_id (info, pp, &name, &namlen, &present))

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    if (! present)

 	      break;

 	    if (! ieee_read_number (info, pp, &val))

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    /* If the length of the name is zero, then the value is

@@ -1627,6 +1641,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	    names[c] = savestring (name, namlen);

 	    if (names[c] == NULL)

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    vals[c] = (bfd_signed_vma) val;

 	    ++c;

@@ -1646,6 +1662,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	debug_type t;

 	if (! ieee_read_type_index (info, pp, &t))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	type = debug_make_pointer_type (dhandle, t);

       }

@@ -1660,6 +1678,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	    || ! ieee_read_number (info, pp, &high)

 	    || ! ieee_read_number (info, pp, &signedp)

 	    || ! ieee_read_number (info, pp, &size))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	type = debug_make_range_type (dhandle,

@@ -1679,6 +1699,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	unsigned int c;

 	if (! ieee_read_number (info, pp, &size))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	alloc = 10;

@@ -1695,11 +1717,15 @@ parse_ieee_ty (struct ieee_info *info, c

 	    bfd_vma bitsize;

 	    if (! ieee_read_optional_id (info, pp, &name, &namlen, &present))

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    if (! present)

 	      break;

 	    if (! ieee_read_number (info, pp, &tindx)

 		|| ! ieee_read_number (info, pp, &offset))

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    if (tindx < 256)

@@ -1733,6 +1759,8 @@ parse_ieee_ty (struct ieee_info *info, c

 					  ftype, offset, bitsize,

 					  DEBUG_VISIBILITY_PUBLIC);

 	    if (fields[c] == NULL)

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	    ++c;

 	  }

@@ -1747,6 +1775,8 @@ parse_ieee_ty (struct ieee_info *info, c

     case 'T':

       /* Typedef.  */

       if (! ieee_read_type_index (info, pp, &type))

+	/* There is a potential resource leak here, but it is not important.  */

+	/* coverity[leaked_storage: FALSE] */

 	return FALSE;

       typdef = TRUE;

       break;

@@ -1766,6 +1796,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	if (! ieee_read_number (info, pp, &attr)

 	    || ! ieee_read_type_index (info, pp, &rtype)

 	    || ! ieee_read_number (info, pp, &nargs))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	do

 	  {

@@ -1773,6 +1805,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	    unsigned long namlen;

 	    if (! ieee_read_optional_id (info, pp, &name, &namlen, &present))

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	  }

 	while (present);

@@ -1810,6 +1844,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	if (! ieee_read_type_index (info, pp, &etype)

 	    || ! ieee_read_number (info, pp, &high))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	type = debug_make_array_type (dhandle, etype,

@@ -1829,6 +1865,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	/* FIXME: I don't know what the name means.  */

 	if (! ieee_read_id (info, pp, &name, &namlen))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	type = debug_make_complex_type (dhandle, tc == 'c' ? 4 : 8);

@@ -1838,6 +1876,8 @@ parse_ieee_ty (struct ieee_info *info, c

     case 'f':

       /* Pascal file name.  FIXME.  */

       ieee_error (info, ty_code_start, _("Pascal file name not supported"));

+      /* There is a potential resource leak here, but it is not important.  */

+      /* coverity[leaked_storage: FALSE] */

       return FALSE;

     case 'g':

@@ -1849,12 +1889,16 @@ parse_ieee_ty (struct ieee_info *info, c

 	if (! ieee_read_number (info, pp, &signedp)

 	    || ! ieee_read_number (info, pp, &bitsize))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	/* I think the documentation says that there is a type index,

            but some actual files do not have one.  */

 	hold = *pp;

 	if (! ieee_read_optional_number (info, pp, &dummy, &present))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	if (! present)

 	  {

@@ -1866,6 +1910,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	  {

 	    *pp = hold;

 	    if (! ieee_read_type_index (info, pp, &type))

+	      /* There is a potential resource leak here, but it is not important.  */

+	      /* coverity[leaked_storage: FALSE] */

 	      return FALSE;

 	  }

 	type_bitsize = bitsize;

@@ -1880,12 +1926,16 @@ parse_ieee_ty (struct ieee_info *info, c

 	if (! ieee_read_number (info, pp, &kind)

 	    || ! ieee_read_type_index (info, pp, &t))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	switch (kind)

 	  {

 	  default:

 	    ieee_error (info, ty_start, _("unsupported qualifier"));

+	    /* There is a potential resource leak here, but it is not important.  */

+	    /* coverity[leaked_storage: FALSE] */

 	    return FALSE;

 	  case 1:

@@ -1907,6 +1957,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	if (! ieee_read_number (info, pp, &size)

 	    || ! ieee_read_type_index (info, pp, &etype))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	/* FIXME: We ignore the size.  */

@@ -1934,6 +1986,8 @@ parse_ieee_ty (struct ieee_info *info, c

 	    || ! ieee_read_number (info, pp, &push_mask)

 	    || ! ieee_read_type_index (info, pp, &rtype)

 	    || ! ieee_read_number (info, pp, &nargs))

+	  /* There is a potential resource leak here, but it is not important.  */

+	  /* coverity[leaked_storage: FALSE] */

 	  return FALSE;

 	if (nargs == (bfd_vma) -1)

 	  {

@@ -1948,6 +2002,8 @@ parse_ieee_ty (struct ieee_info *info, c

 			 xmalloc ((nargs + 1) * sizeof *arg_types));

 	    for (i = 0; i < nargs; i++)

 	      if (! ieee_read_type_index (info, pp, arg_types + i))

+		/* There is a potential resource leak here, but it is not important.  */

+		/* coverity[leaked_storage: FALSE] */

 		return FALSE;

 	    /* If the last type is pointer to void, this is really a