|
 |
ece282 |
From b4f85d66280affcb52e998661f782c2ab4f806a7 Mon Sep 17 00:00:00 2001
|
|
|
ece282 |
From: Ray Strode <rstrode@redhat.com>
|
|
|
ece282 |
Date: Thu, 9 May 2019 14:58:34 -0400
|
|
|
ece282 |
Subject: [PATCH] data: don't send change updates for login-history
|
|
|
ece282 |
|
|
|
ece282 |
The login-history property of user objects can be quite large.
|
|
|
ece282 |
If wtmp is changed frequently, that can lead to memory fragmentation
|
|
|
ece282 |
in clients.
|
|
|
ece282 |
|
|
|
ece282 |
Furthermore, most clients never check login-history, so it's
|
|
|
ece282 |
wasted memory and wasted cpu.
|
|
|
ece282 |
|
|
|
ece282 |
This commit disables change notification for that property. If
|
|
|
ece282 |
a client really needs to get updates, they can manually refresh
|
|
|
ece282 |
their cache when appropriate.
|
|
|
ece282 |
---
|
|
|
ece282 |
data/org.freedesktop.Accounts.User.xml | 1 +
|
|
|
ece282 |
1 file changed, 1 insertion(+)
|
|
|
ece282 |
|
|
|
ece282 |
diff --git a/data/org.freedesktop.Accounts.User.xml b/data/org.freedesktop.Accounts.User.xml
|
|
|
ece282 |
index 8d3fe1c..3b839a3 100644
|
|
|
ece282 |
--- a/data/org.freedesktop.Accounts.User.xml
|
|
|
ece282 |
+++ b/data/org.freedesktop.Accounts.User.xml
|
|
|
ece282 |
@@ -785,60 +785,61 @@
|
|
|
ece282 |
<doc:doc>
|
|
|
ece282 |
<doc:description>
|
|
|
ece282 |
<doc:para>
|
|
|
ece282 |
The users location.
|
|
|
ece282 |
</doc:para>
|
|
|
ece282 |
</doc:description>
|
|
|
ece282 |
</doc:doc>
|
|
|
ece282 |
</property>
|
|
|
ece282 |
|
|
|
ece282 |
<property name="LoginFrequency" type="t" access="read">
|
|
|
ece282 |
<doc:doc>
|
|
|
ece282 |
<doc:description>
|
|
|
ece282 |
<doc:para>
|
|
|
ece282 |
How often the user has logged in.
|
|
|
ece282 |
</doc:para>
|
|
|
ece282 |
</doc:description>
|
|
|
ece282 |
</doc:doc>
|
|
|
ece282 |
</property>
|
|
|
ece282 |
|
|
|
ece282 |
<property name="LoginTime" type="x" access="read">
|
|
|
ece282 |
<doc:doc>
|
|
|
ece282 |
<doc:description>
|
|
|
ece282 |
<doc:para>
|
|
|
ece282 |
The last login time.
|
|
|
ece282 |
</doc:para>
|
|
|
ece282 |
</doc:description>
|
|
|
ece282 |
</doc:doc>
|
|
|
ece282 |
</property>
|
|
|
ece282 |
|
|
|
ece282 |
<property name="LoginHistory" type="a(xxa{sv})" access="read">
|
|
|
ece282 |
+ <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="false"/>
|
|
|
ece282 |
<doc:doc>
|
|
|
ece282 |
<doc:description>
|
|
|
ece282 |
<doc:para>
|
|
|
ece282 |
The login history for this user.
|
|
|
ece282 |
Each entry in the array represents a login session. The first two
|
|
|
ece282 |
members are the login time and logout time, as timestamps (seconds since the epoch). If the session is still running, the logout time
|
|
|
ece282 |
is 0.
|
|
|
ece282 |
</doc:para>
|
|
|
ece282 |
<doc:para>
|
|
|
ece282 |
The a{sv} member is a dictionary containing additional information
|
|
|
ece282 |
about the session. Possible members include 'type' (with values like ':0', 'tty0', 'pts/0' etc).
|
|
|
ece282 |
</doc:para>
|
|
|
ece282 |
</doc:description>
|
|
|
ece282 |
</doc:doc>
|
|
|
ece282 |
</property>
|
|
|
ece282 |
|
|
|
ece282 |
<property name="IconFile" type="s" access="read">
|
|
|
ece282 |
<doc:doc>
|
|
|
ece282 |
<doc:description>
|
|
|
ece282 |
<doc:para>
|
|
|
ece282 |
The filename of a png file containing the users icon.
|
|
|
ece282 |
</doc:para>
|
|
|
ece282 |
</doc:description>
|
|
|
ece282 |
</doc:doc>
|
|
|
ece282 |
</property>
|
|
|
ece282 |
|
|
|
ece282 |
<property name="Saved" type="b" access="read">
|
|
|
ece282 |
<doc:doc>
|
|
|
ece282 |
<doc:description>
|
|
|
ece282 |
<doc:para>
|
|
|
ece282 |
--
|
|
|
ece282 |
2.21.0
|
|
|
ece282 |
|