Blame SOURCES/0001-data-don-t-send-change-updates-for-login-history.patch

75ac18
From b4f85d66280affcb52e998661f782c2ab4f806a7 Mon Sep 17 00:00:00 2001
75ac18
From: Ray Strode <rstrode@redhat.com>
75ac18
Date: Thu, 9 May 2019 14:58:34 -0400
75ac18
Subject: [PATCH] data: don't send change updates for login-history
75ac18
75ac18
The login-history property of user objects can be quite large.
75ac18
If wtmp is changed frequently, that can lead to memory fragmentation
75ac18
in clients.
75ac18
75ac18
Furthermore, most clients never check login-history, so it's
75ac18
wasted memory and wasted cpu.
75ac18
75ac18
This commit disables change notification for that property.  If
75ac18
a client really needs to get updates, they can manually refresh
75ac18
their cache when appropriate.
75ac18
---
75ac18
 data/org.freedesktop.Accounts.User.xml | 1 +
75ac18
 1 file changed, 1 insertion(+)
75ac18
75ac18
diff --git a/data/org.freedesktop.Accounts.User.xml b/data/org.freedesktop.Accounts.User.xml
75ac18
index 8d3fe1c..3b839a3 100644
75ac18
--- a/data/org.freedesktop.Accounts.User.xml
75ac18
+++ b/data/org.freedesktop.Accounts.User.xml
75ac18
@@ -785,60 +785,61 @@
75ac18
     <doc:doc>
75ac18
       <doc:description>
75ac18
         <doc:para>
75ac18
           The users location.
75ac18
         </doc:para>
75ac18
       </doc:description>
75ac18
     </doc:doc>
75ac18
   </property>
75ac18
 
75ac18
   <property name="LoginFrequency" type="t" access="read">
75ac18
     <doc:doc>
75ac18
       <doc:description>
75ac18
         <doc:para>
75ac18
           How often the user has logged in.
75ac18
         </doc:para>
75ac18
       </doc:description>
75ac18
     </doc:doc>
75ac18
   </property>
75ac18
 
75ac18
   <property name="LoginTime" type="x" access="read">
75ac18
     <doc:doc>
75ac18
       <doc:description>
75ac18
         <doc:para>
75ac18
           The last login time.
75ac18
         </doc:para>
75ac18
       </doc:description>
75ac18
     </doc:doc>
75ac18
   </property>
75ac18
 
75ac18
   <property name="LoginHistory" type="a(xxa{sv})" access="read">
75ac18
+    <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="false"/>
75ac18
     <doc:doc>
75ac18
       <doc:description>
75ac18
         <doc:para>
75ac18
           The login history for this user.
75ac18
           Each entry in the array represents a login session. The first two
75ac18
           members are the login time and logout time, as timestamps (seconds since the epoch). If the session is still running, the logout time
75ac18
           is 0.
75ac18
         </doc:para>
75ac18
         <doc:para>
75ac18
           The a{sv} member is a dictionary containing additional information
75ac18
           about the session. Possible members include 'type' (with values like ':0', 'tty0', 'pts/0' etc).
75ac18
         </doc:para>
75ac18
       </doc:description>
75ac18
     </doc:doc>
75ac18
   </property>
75ac18
 
75ac18
   <property name="IconFile" type="s" access="read">
75ac18
     <doc:doc>
75ac18
       <doc:description>
75ac18
         <doc:para>
75ac18
            The filename of a png file containing the users icon.
75ac18
         </doc:para>
75ac18
       </doc:description>
75ac18
     </doc:doc>
75ac18
   </property>
75ac18
 
75ac18
   <property name="Saved" type="b" access="read">
75ac18
     <doc:doc>
75ac18
       <doc:description>
75ac18
         <doc:para>
75ac18
-- 
75ac18
2.21.0
75ac18