|
 |
71f808 |
From d984ddf1a64ce9fae36395b423cf6e52afc9a07a Mon Sep 17 00:00:00 2001
|
|
|
71f808 |
From: "Benjamin A. Beasley" <code@musicinmybrain.net>
|
|
|
71f808 |
Date: Wed, 16 Mar 2022 14:33:41 -0400
|
|
|
71f808 |
Subject: [PATCH] Disable SysinfoTest.NominalCPUFrequency
|
|
|
71f808 |
|
|
|
71f808 |
SysinfoTest.NominalCPUFrequency in absl_sysinfo_test fails occasionally
|
|
|
71f808 |
on aarch64, but see:
|
|
|
71f808 |
|
|
|
71f808 |
NominalCPUFrequency Test from SysInfoTest Suite Fails on M1 Mac
|
|
|
71f808 |
https://github.com/abseil/abseil-cpp/issues/1053#issuecomment-961432444
|
|
|
71f808 |
|
|
|
71f808 |
in which an upstream author opines:
|
|
|
71f808 |
|
|
|
71f808 |
If the only problem you are trying to solve is a failing test, this is safe
|
|
|
71f808 |
to ignore since this code is never called. I should consider stripping this
|
|
|
71f808 |
test out of the open source release. NominalCPUFrequency is only called in
|
|
|
71f808 |
code private to Google and we do have tests on the platforms we use it on.
|
|
|
71f808 |
|
|
|
71f808 |
We therefore disable it on all architectures, since any future failures
|
|
|
71f808 |
will also not be meaningful.
|
|
|
71f808 |
|
|
|
71f808 |
Note also that this test is removed upstream in commit
|
|
|
71f808 |
732b5580f089101ce4b8cdff55bb6461c59a6720 (internal commit
|
|
|
71f808 |
7e8da4f14afd25d11713eee6b743ba31605332bf).
|
|
|
71f808 |
---
|
|
|
71f808 |
absl/base/internal/sysinfo_test.cc | 2 +-
|
|
|
71f808 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
71f808 |
|
|
|
71f808 |
diff --git a/absl/base/internal/sysinfo_test.cc b/absl/base/internal/sysinfo_test.cc
|
|
|
71f808 |
index 5f9e45f..1a944f0 100644
|
|
|
71f808 |
--- a/absl/base/internal/sysinfo_test.cc
|
|
|
71f808 |
+++ b/absl/base/internal/sysinfo_test.cc
|
|
|
71f808 |
@@ -44,7 +44,7 @@ TEST(SysinfoTest, NumCPUs) {
|
|
|
71f808 |
// frequency, while others do not. Since we can't predict a priori what a given
|
|
|
71f808 |
// machine is going to do, just disable this test on POWER on Linux.
|
|
|
71f808 |
#if !(defined(__linux) && (defined(__ppc64__) || defined(__PPC64__)))
|
|
|
71f808 |
-TEST(SysinfoTest, NominalCPUFrequency) {
|
|
|
71f808 |
+TEST(SysinfoTest, DISABLED_NominalCPUFrequency) {
|
|
|
71f808 |
// Linux only exposes the CPU frequency on certain architectures, and
|
|
|
71f808 |
// Emscripten doesn't expose it at all.
|
|
|
71f808 |
#if defined(__linux__) && \
|
|
|
71f808 |
--
|
|
|
71f808 |
2.35.1
|
|
|
71f808 |
|