7c1a18
From c9c13747e575fe2ce398cec200284d0318aaece3 Mon Sep 17 00:00:00 2001
7c1a18
From: Michael Catanzaro <mcatanzaro@gnome.org>
7c1a18
Date: Wed, 29 Apr 2020 13:44:41 -0500
7c1a18
Subject: [PATCH] Revert "Shutdown the daemon on idle by default"
7c1a18
7c1a18
This reverts commit 0c84d71509e851db20445c747529bd7d3724f081.
7c1a18
7c1a18
This broke the end session dialog in GNOME Shell.
7c1a18
7c1a18
I thought I had that fixed by changing GNOME Shell to autostart
7c1a18
PackageKit when it is not already running:
7c1a18
7c1a18
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1104
7c1a18
7c1a18
But turns out, there are more problems. The update fails if the user has
7c1a18
used dnf since PackageKit last quit, a scenario I did not test. It also
7c1a18
results in GNOME Software getting confused about what software is
7c1a18
installed and what software is not. The issues are discussed here:
7c1a18
7c1a18
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1227#note_784327
7c1a18
7c1a18
It's still desirable to shut down automatically, but it requires more
7c1a18
planning. And shutting down GNOME Software itself is frankly more
7c1a18
important, since it uses a lot more RAM than packagekitd.
7c1a18
---
7c1a18
 src/pk-main.c | 2 --
7c1a18
 1 file changed, 2 deletions(-)
7c1a18
7c1a18
diff --git a/src/pk-main.c b/src/pk-main.c
7c1a18
index 7a0bbd199..5791c5fef 100644
7c1a18
--- a/src/pk-main.c
7c1a18
+++ b/src/pk-main.c
7c1a18
@@ -178,8 +178,6 @@ main (int argc, char *argv[])
7c1a18
 
7c1a18
 	/* after how long do we timeout? */
7c1a18
 	exit_idle_time = g_key_file_get_integer (conf, "Daemon", "ShutdownTimeout", NULL);
7c1a18
-	if (exit_idle_time == 0)
7c1a18
-		exit_idle_time = 300;
7c1a18
 	g_debug ("daemon shutdown set to %i seconds", exit_idle_time);
7c1a18
 
7c1a18
 	/* override the backend name */