From 44b6f98bc687f3ec3ae2c40b8086f1bd4936b827 Mon Sep 17 00:00:00 2001 From: Mark Reynolds Date: Mon, 20 May 2019 15:06:54 -0400 Subject: [PATCH] Ticket 50396 - Crash in PAM plugin when user does not exist Description: pam passthru & addn plugin causes crash in bind when user does not exist. Need to make sure we don't dereference NULL pointer. https://pagure.io/389-ds-base/issue/50396 Reviewed by: mreynolds & tbordaz (cherry picked from commit 0935b8af6c8925c7a79a0a22103142ef5f7c5960) --- ldap/servers/plugins/pam_passthru/pam_ptpreop.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ldap/servers/plugins/pam_passthru/pam_ptpreop.c b/ldap/servers/plugins/pam_passthru/pam_ptpreop.c index de9448b90..b62c3c6b6 100644 --- a/ldap/servers/plugins/pam_passthru/pam_ptpreop.c +++ b/ldap/servers/plugins/pam_passthru/pam_ptpreop.c @@ -436,8 +436,9 @@ pam_passthru_bindpreop(Slapi_PBlock *pb) * We only handle simple bind requests that include non-NULL binddn and * credentials. Let the Directory Server itself handle everything else. */ - if ((method != LDAP_AUTH_SIMPLE) || (*normbinddn == '\0') || - (creds->bv_len == 0)) { + if (method != LDAP_AUTH_SIMPLE || normbinddn == NULL || + *normbinddn == '\0' || creds->bv_len == 0) + { slapi_log_err(SLAPI_LOG_PLUGIN, PAM_PASSTHRU_PLUGIN_SUBSYSTEM, "pam_passthru_bindpreop - Not handled (not simple bind or NULL dn/credentials)\n"); return retcode; -- 2.17.2