|
 |
61f723 |
From e52c519a8553dd8abee5740714054ebbdd59e51a Mon Sep 17 00:00:00 2001
|
|
|
61f723 |
From: William Brown <firstyear@redhat.com>
|
|
|
61f723 |
Date: Tue, 23 May 2017 11:03:24 +1000
|
|
|
61f723 |
Subject: [PATCH] Ticket 49267 - autosize split of 0 results in dbcache of 0
|
|
|
61f723 |
|
|
|
61f723 |
Bug Description: autosize split of 0 results in a dbcache of 0. This was
|
|
|
61f723 |
due to a missing bounds check on the value for 0. In theory this could
|
|
|
61f723 |
still be problematic if the value was say 1% ... But hopefully we don't
|
|
|
61f723 |
see that :)
|
|
|
61f723 |
|
|
|
61f723 |
Fix Description: Add the bounds check.
|
|
|
61f723 |
|
|
|
61f723 |
https://pagure.io/389-ds-base/issue/49267
|
|
|
61f723 |
|
|
|
61f723 |
Author: wibrown
|
|
|
61f723 |
|
|
|
61f723 |
Review by: mreynolds (Thanks!)
|
|
|
61f723 |
|
|
|
61f723 |
(cherry picked from commit 22d4865ea20acb6e6c11aed10d09241b09bb711c)
|
|
|
61f723 |
---
|
|
|
61f723 |
ldap/servers/slapd/back-ldbm/start.c | 14 +++++++++++++-
|
|
|
61f723 |
1 file changed, 13 insertions(+), 1 deletion(-)
|
|
|
61f723 |
|
|
|
61f723 |
diff --git a/ldap/servers/slapd/back-ldbm/start.c b/ldap/servers/slapd/back-ldbm/start.c
|
|
|
61f723 |
index a207bd8..1834a19 100644
|
|
|
61f723 |
--- a/ldap/servers/slapd/back-ldbm/start.c
|
|
|
61f723 |
+++ b/ldap/servers/slapd/back-ldbm/start.c
|
|
|
61f723 |
@@ -101,7 +101,11 @@ ldbm_back_start_autotune(struct ldbminfo *li) {
|
|
|
61f723 |
/* This doesn't control the availability of the feature, so we can take the
|
|
|
61f723 |
* default from ldbm_config.c
|
|
|
61f723 |
*/
|
|
|
61f723 |
- autosize_db_percentage_split = li->li_cache_autosize_split;
|
|
|
61f723 |
+ if (li->li_cache_autosize_split == 0) {
|
|
|
61f723 |
+ autosize_db_percentage_split = 40;
|
|
|
61f723 |
+ } else {
|
|
|
61f723 |
+ autosize_db_percentage_split = li->li_cache_autosize_split;
|
|
|
61f723 |
+ }
|
|
|
61f723 |
|
|
|
61f723 |
|
|
|
61f723 |
/* Check the values are sane. */
|
|
|
61f723 |
@@ -131,10 +135,18 @@ ldbm_back_start_autotune(struct ldbminfo *li) {
|
|
|
61f723 |
db_size = (autosize_db_percentage_split * zone_size) / 100;
|
|
|
61f723 |
|
|
|
61f723 |
/* Cap the DB size at 512MB, as this doesn't help perf much more (lkrispen's advice) */
|
|
|
61f723 |
+ /* NOTE: Do we need a minimum DB size? */
|
|
|
61f723 |
if (db_size > (512 * MEGABYTE)) {
|
|
|
61f723 |
db_size = (512 * MEGABYTE);
|
|
|
61f723 |
}
|
|
|
61f723 |
|
|
|
61f723 |
+ /* NOTE: Because of how we workout entry_size, even if
|
|
|
61f723 |
+ * have autosize split to say ... 90% for dbcache, because
|
|
|
61f723 |
+ * we cap db_size, we use zone_size - db_size, meaning that entry
|
|
|
61f723 |
+ * cache still gets the remaining memory *even* though we didn't use it all.
|
|
|
61f723 |
+ * If we didn't do this, entry_cache would only get 10% of of the avail, even
|
|
|
61f723 |
+ * if db_size was caped at say 5% down from 90.
|
|
|
61f723 |
+ */
|
|
|
61f723 |
if (backend_count > 0 ) {
|
|
|
61f723 |
/* Number of entry cache pages per backend. */
|
|
|
61f723 |
entry_size = (zone_size - db_size) / backend_count;
|
|
|
61f723 |
--
|
|
|
61f723 |
2.9.4
|
|
|
61f723 |
|