zrhoffman / rpms / 389-ds-base

Forked from rpms/389-ds-base 3 years ago
Clone

Blame SOURCES/0041-Ticket-47969-Fix-coverity-issue.patch

f92ce9
From 64010b34bb2ca9c62c6cfff70ce406bcaacef8b0 Mon Sep 17 00:00:00 2001
f92ce9
From: Mark Reynolds <mreynolds@redhat.com>
f92ce9
Date: Mon, 8 Dec 2014 09:57:50 -0500
f92ce9
Subject: [PATCH 41/53] Ticket 47969 - Fix coverity issue
f92ce9
f92ce9
Description: Fix coverity issue 12948 & 12949 (NULL pointer dereference)
f92ce9
f92ce9
https://fedorahosted.org/389/ticket/47969
f92ce9
f92ce9
Reviewed by: mreynolds
f92ce9
f92ce9
(cherry picked from commit 1553b665bfecbbccd54c439442d9a22c5d35d4a1)
f92ce9
(cherry picked from commit af163d345b4524c121296626cb2e9da26d6d061e)
f92ce9
---
f92ce9
 ldap/servers/plugins/cos/cos_cache.c | 4 ++--
f92ce9
 1 file changed, 2 insertions(+), 2 deletions(-)
f92ce9
f92ce9
diff --git a/ldap/servers/plugins/cos/cos_cache.c b/ldap/servers/plugins/cos/cos_cache.c
f92ce9
index fd163f9..a74389d 100644
f92ce9
--- a/ldap/servers/plugins/cos/cos_cache.c
f92ce9
+++ b/ldap/servers/plugins/cos/cos_cache.c
f92ce9
@@ -1863,9 +1863,9 @@ static void cos_cache_del_schema(cosCache *pCache)
f92ce9
 				cos_cache_del_attrval_list(&(pCache->ppAttrIndex[attr_index]->pObjectclasses));
f92ce9
 			}
f92ce9
 		}
f92ce9
+		/* Finally, remove the first attribute's objectclass list */
f92ce9
+		cos_cache_del_attrval_list(&(pCache->ppAttrIndex[0]->pObjectclasses));
f92ce9
 	}
f92ce9
-	/* Finally, remove the first attribute's objectclass list */
f92ce9
-	cos_cache_del_attrval_list(&(pCache->ppAttrIndex[0]->pObjectclasses));
f92ce9
 
f92ce9
 	LDAPDebug( LDAP_DEBUG_TRACE, "<-- cos_cache_del_schema\n",0,0,0);
f92ce9
 }
f92ce9
-- 
f92ce9
1.9.3
f92ce9