From ccb23fcac26e2a3712e2f25af6499a1d3b7e2882 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Fri, 10 Sep 2021 11:42:03 +0200 Subject: [PATCH 1/4] qxl: fix pre-save logic MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RH-Author: Gerd Hoffmann RH-MergeRequest: 39: qxl: fix pre-save logic RH-Commit: [1/1] 126b1a352c63805bd23f5eb704515090eedc04e7 RH-Bugzilla: 2002907 RH-Acked-by: Philippe Mathieu-Daudé RH-Acked-by: Dr. David Alan Gilbert RH-Acked-by: Marc-André Lureau Oops. Logic is backwards. Fixes: 39b8a183e2f3 ("qxl: remove assert in qxl_pre_save.") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/610 Resolves: https://bugzilla.redhat.com//show_bug.cgi?id=2002907 Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé Reviewed-by: Marc-André Lureau Message-Id: <20210910094203.3582378-1-kraxel@redhat.com> (cherry picked from commit eb94846280df3f1e2a91b6179fc05f9890b7e384) --- hw/display/qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 43482d4364..29c80b4289 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -2252,7 +2252,7 @@ static int qxl_pre_save(void *opaque) } else { d->last_release_offset = (uint8_t *)d->last_release - ram_start; } - if (d->last_release_offset < d->vga.vram_size) { + if (d->last_release_offset >= d->vga.vram_size) { return 1; } -- 2.18.2