|
 |
016a62 |
From 1406157e5944e023b07a644d5a8377db708134e8 Mon Sep 17 00:00:00 2001
|
|
|
016a62 |
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
|
|
|
016a62 |
Date: Wed, 15 Jan 2020 12:07:42 +0100
|
|
|
016a62 |
Subject: [PATCH 4/7] xhci: recheck slot status
|
|
|
016a62 |
MIME-Version: 1.0
|
|
|
016a62 |
Content-Type: text/plain; charset=UTF-8
|
|
|
016a62 |
Content-Transfer-Encoding: 8bit
|
|
|
016a62 |
|
|
|
016a62 |
RH-Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
016a62 |
Message-id: <20200115120742.19583-3-dgilbert@redhat.com>
|
|
|
016a62 |
Patchwork-id: 93353
|
|
|
016a62 |
O-Subject: [RHEL-8.2.0 qemu-kvm PATCH 2/2] xhci: recheck slot status
|
|
|
016a62 |
Bugzilla: 1752320
|
|
|
016a62 |
RH-Acked-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
|
016a62 |
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
|
016a62 |
RH-Acked-by: Peter Xu <peterx@redhat.com>
|
|
|
016a62 |
|
|
|
016a62 |
From: Gerd Hoffmann <kraxel@redhat.com>
|
|
|
016a62 |
|
|
|
016a62 |
Factor out slot status check into a helper function. Add an additional
|
|
|
016a62 |
check after completing transfers. This is needed in case a guest
|
|
|
016a62 |
queues multiple transfers in a row and a device unplug happens while
|
|
|
016a62 |
qemu processes them.
|
|
|
016a62 |
|
|
|
016a62 |
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1786413
|
|
|
016a62 |
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
|
016a62 |
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
|
016a62 |
Message-id: 20200107083606.12393-1-kraxel@redhat.com
|
|
|
016a62 |
(cherry picked from commit 236846a019c4f7aa3111026fc9a1fe09684c8978)
|
|
|
016a62 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
016a62 |
---
|
|
|
016a62 |
hw/usb/hcd-xhci.c | 15 ++++++++++++---
|
|
|
016a62 |
1 file changed, 12 insertions(+), 3 deletions(-)
|
|
|
016a62 |
|
|
|
016a62 |
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
|
|
|
016a62 |
index 45fcce3..e63a603 100644
|
|
|
016a62 |
--- a/hw/usb/hcd-xhci.c
|
|
|
016a62 |
+++ b/hw/usb/hcd-xhci.c
|
|
|
016a62 |
@@ -1853,6 +1853,13 @@ static void xhci_kick_ep(XHCIState *xhci, unsigned int slotid,
|
|
|
016a62 |
xhci_kick_epctx(epctx, streamid);
|
|
|
016a62 |
}
|
|
|
016a62 |
|
|
|
016a62 |
+static bool xhci_slot_ok(XHCIState *xhci, int slotid)
|
|
|
016a62 |
+{
|
|
|
016a62 |
+ return (xhci->slots[slotid - 1].uport &&
|
|
|
016a62 |
+ xhci->slots[slotid - 1].uport->dev &&
|
|
|
016a62 |
+ xhci->slots[slotid - 1].uport->dev->attached);
|
|
|
016a62 |
+}
|
|
|
016a62 |
+
|
|
|
016a62 |
static void xhci_kick_epctx(XHCIEPContext *epctx, unsigned int streamid)
|
|
|
016a62 |
{
|
|
|
016a62 |
XHCIState *xhci = epctx->xhci;
|
|
|
016a62 |
@@ -1870,9 +1877,7 @@ static void xhci_kick_epctx(XHCIEPContext *epctx, unsigned int streamid)
|
|
|
016a62 |
|
|
|
016a62 |
/* If the device has been detached, but the guest has not noticed this
|
|
|
016a62 |
yet the 2 above checks will succeed, but we must NOT continue */
|
|
|
016a62 |
- if (!xhci->slots[epctx->slotid - 1].uport ||
|
|
|
016a62 |
- !xhci->slots[epctx->slotid - 1].uport->dev ||
|
|
|
016a62 |
- !xhci->slots[epctx->slotid - 1].uport->dev->attached) {
|
|
|
016a62 |
+ if (!xhci_slot_ok(xhci, epctx->slotid)) {
|
|
|
016a62 |
return;
|
|
|
016a62 |
}
|
|
|
016a62 |
|
|
|
016a62 |
@@ -1968,6 +1973,10 @@ static void xhci_kick_epctx(XHCIEPContext *epctx, unsigned int streamid)
|
|
|
016a62 |
} else {
|
|
|
016a62 |
xhci_fire_transfer(xhci, xfer, epctx);
|
|
|
016a62 |
}
|
|
|
016a62 |
+ if (!xhci_slot_ok(xhci, epctx->slotid)) {
|
|
|
016a62 |
+ /* surprise removal -> stop processing */
|
|
|
016a62 |
+ break;
|
|
|
016a62 |
+ }
|
|
|
016a62 |
if (xfer->complete) {
|
|
|
016a62 |
/* update ring dequeue ptr */
|
|
|
016a62 |
xhci_set_ep_state(xhci, epctx, stctx, epctx->state);
|
|
|
016a62 |
--
|
|
|
016a62 |
1.8.3.1
|
|
|
016a62 |
|