|
 |
9ae3a8 |
From 46415e245ed90b1bb08ff4d67559a6c0f34cf9db Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Jeffrey Cody <jcody@redhat.com>
|
|
|
9ae3a8 |
Date: Wed, 29 Jul 2015 16:59:53 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 02/13] vpc: Handle failure for potentially large allocations
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Message-id: <e1f23ed0869898acec75825bec74cf375bee876b.1438188988.git.jcody@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 67196
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.2 qemu-kvm PATCH 1/3] vpc: Handle failure for potentially large allocations
|
|
|
9ae3a8 |
Bugzilla: 1217349
|
|
|
9ae3a8 |
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Some code in the block layer makes potentially huge allocations. Failure
|
|
|
9ae3a8 |
is not completely unexpected there, so avoid aborting qemu and handle
|
|
|
9ae3a8 |
out-of-memory situations gracefully.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
This patch addresses the allocations in the vpc block driver.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9ae3a8 |
Reviewed-by: Benoit Canet <benoit@irqsave.net>
|
|
|
9ae3a8 |
(cherry picked from commit 5fb09cd5867aabf26d5b85b0913dccd496b71421)
|
|
|
9ae3a8 |
Signed-off-by: Jeff Cody <jcody@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
block/vpc.c | 6 +++++-
|
|
|
9ae3a8 |
1 file changed, 5 insertions(+), 1 deletion(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/block/vpc.c b/block/vpc.c
|
|
|
9ae3a8 |
index 849501a..6fdce40 100644
|
|
|
9ae3a8 |
--- a/block/vpc.c
|
|
|
9ae3a8 |
+++ b/block/vpc.c
|
|
|
9ae3a8 |
@@ -260,7 +260,11 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags,
|
|
|
9ae3a8 |
goto fail;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- s->pagetable = qemu_blockalign(bs, s->max_table_entries * 4);
|
|
|
9ae3a8 |
+ s->pagetable = qemu_try_blockalign(bs->file, s->max_table_entries * 4);
|
|
|
9ae3a8 |
+ if (s->pagetable == NULL) {
|
|
|
9ae3a8 |
+ ret = -ENOMEM;
|
|
|
9ae3a8 |
+ goto fail;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
s->bat_offset = be64_to_cpu(dyndisk_header->table_offset);
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|