|
 |
958e1b |
From 31c38d22c1d0e852c05eb8d74295f940fc93aaa8 Mon Sep 17 00:00:00 2001
|
|
|
958e1b |
From: Fam Zheng <famz@redhat.com>
|
|
|
958e1b |
Date: Mon, 14 Jul 2014 02:38:04 -0500
|
|
|
958e1b |
Subject: [CHANGE 23/29] virtio-pci: Report an error when msix vectors init
|
|
|
958e1b |
fails
|
|
|
958e1b |
To: rhvirt-patches@redhat.com,
|
|
|
958e1b |
jen@redhat.com
|
|
|
958e1b |
|
|
|
958e1b |
RH-Author: Fam Zheng <famz@redhat.com>
|
|
|
958e1b |
Message-id: <1405305484-12175-1-git-send-email-famz@redhat.com>
|
|
|
958e1b |
Patchwork-id: 59873
|
|
|
958e1b |
O-Subject: [RHEL-7 qemu-kvm PATCH] virtio-pci: Report an error when msix vectors init fails
|
|
|
958e1b |
Bugzilla: 1095645
|
|
|
958e1b |
RH-Acked-by: Markus Armbruster <armbru@redhat.com>
|
|
|
958e1b |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
958e1b |
RH-Acked-by: Dr. David Alan Gilbert (git) <dgilbert@redhat.com>
|
|
|
958e1b |
|
|
|
958e1b |
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1095645
|
|
|
958e1b |
Brew: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=7695836
|
|
|
958e1b |
|
|
|
958e1b |
Currently vectors silently cleared to 0 if the initialization is failed,
|
|
|
958e1b |
but user should at least have one way to notice this.
|
|
|
958e1b |
|
|
|
958e1b |
Signed-off-by: Fam Zheng <famz@redhat.com>
|
|
|
958e1b |
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
|
958e1b |
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
|
958e1b |
|
|
|
958e1b |
(cherry picked from commit c7ff54825b74f27c3aac85aad540542801630d0a)
|
|
|
958e1b |
Signed-off-by: Fam Zheng <famz@redhat.com>
|
|
|
958e1b |
---
|
|
|
958e1b |
hw/virtio/virtio-pci.c | 2 ++
|
|
|
958e1b |
1 file changed, 2 insertions(+)
|
|
|
958e1b |
|
|
|
958e1b |
Signed-off-by: jen <jen@redhat.com>
|
|
|
958e1b |
---
|
|
|
958e1b |
hw/virtio/virtio-pci.c | 2 ++
|
|
|
958e1b |
1 file changed, 2 insertions(+)
|
|
|
958e1b |
|
|
|
958e1b |
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
|
|
|
958e1b |
index 00df4aa..7c09ac4 100644
|
|
|
958e1b |
--- a/hw/virtio/virtio-pci.c
|
|
|
958e1b |
+++ b/hw/virtio/virtio-pci.c
|
|
|
958e1b |
@@ -981,6 +981,8 @@ static void virtio_pci_device_plugged(DeviceState *d)
|
|
|
958e1b |
|
|
|
958e1b |
if (proxy->nvectors &&
|
|
|
958e1b |
msix_init_exclusive_bar(&proxy->pci_dev, proxy->nvectors, 1)) {
|
|
|
958e1b |
+ error_report("unable to init msix vectors to %" PRIu32,
|
|
|
958e1b |
+ proxy->nvectors);
|
|
|
958e1b |
proxy->nvectors = 0;
|
|
|
958e1b |
}
|
|
|
958e1b |
|
|
|
958e1b |
--
|
|
|
958e1b |
1.9.3
|
|
|
958e1b |
|