|
 |
9ae3a8 |
From 81278fd6c82c8a1c22c65f1ae1ea048d2473dbfe Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Date: Tue, 8 Sep 2015 18:06:24 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 6/7] util/uri: URI member path can be null, compare more
|
|
|
9ae3a8 |
carfully
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Message-id: <1441735585-23432-7-git-send-email-armbru@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 67709
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.2 qemu-kvm PATCH 6/7] util/uri: URI member path can be null, compare more carfully
|
|
|
9ae3a8 |
Bugzilla: 1218919
|
|
|
9ae3a8 |
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
uri_resolve_relative() calls strcmp(bas->path, ref->path). However,
|
|
|
9ae3a8 |
either argument could be null! Evidence: the code checks for null
|
|
|
9ae3a8 |
after the comparison. Spotted by Coverity.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
I suspect this was screwed up when we stole the code from libxml2.
|
|
|
9ae3a8 |
There the conditional reads
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
xmlStrEqual((xmlChar *)bas->path, (xmlChar *)ref->path)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
with
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
int
|
|
|
9ae3a8 |
xmlStrEqual(const xmlChar *str1, const xmlChar *str2) {
|
|
|
9ae3a8 |
if (str1 == str2) return(1);
|
|
|
9ae3a8 |
if (str1 == NULL) return(0);
|
|
|
9ae3a8 |
if (str2 == NULL) return(0);
|
|
|
9ae3a8 |
do {
|
|
|
9ae3a8 |
if (*str1++ != *str2) return(0);
|
|
|
9ae3a8 |
} while (*str2++);
|
|
|
9ae3a8 |
return(1);
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Fix by replicating libxml2's logic faithfully.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Cc: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
|
|
|
9ae3a8 |
(cherry picked from commit afb30dde3ad71349fc65726946d58e5d3c61f8af)
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
util/uri.c | 3 ++-
|
|
|
9ae3a8 |
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/util/uri.c b/util/uri.c
|
|
|
9ae3a8 |
index b9a7b54..1cfd78b 100644
|
|
|
9ae3a8 |
--- a/util/uri.c
|
|
|
9ae3a8 |
+++ b/util/uri.c
|
|
|
9ae3a8 |
@@ -1935,7 +1935,8 @@ uri_resolve_relative (const char *uri, const char * base)
|
|
|
9ae3a8 |
val = g_strdup (uri);
|
|
|
9ae3a8 |
goto done;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
- if (!strcmp(bas->path, ref->path)) {
|
|
|
9ae3a8 |
+ if (bas->path == ref->path ||
|
|
|
9ae3a8 |
+ (bas->path && ref->path && !strcmp(bas->path, ref->path))) {
|
|
|
9ae3a8 |
val = g_strdup("");
|
|
|
9ae3a8 |
goto done;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|