yeahuh / rpms / qemu-kvm

Forked from rpms/qemu-kvm 2 years ago
Clone
5d360b
From cbfdbd7430e27c24d55b880144d5df05ef949417 Mon Sep 17 00:00:00 2001
5d360b
From: "Daniel P. Berrange" <berrange@redhat.com>
5d360b
Date: Thu, 8 Feb 2018 17:50:31 +0100
5d360b
Subject: [PATCH 17/27] ui: avoid pointless VNC updates if framebuffer isn't
5d360b
 dirty
5d360b
MIME-Version: 1.0
5d360b
Content-Type: text/plain; charset=UTF-8
5d360b
Content-Transfer-Encoding: 8bit
5d360b
5d360b
RH-Author: Daniel P. Berrange <berrange@redhat.com>
5d360b
Message-id: <20180208175041.5634-18-berrange@redhat.com>
5d360b
Patchwork-id: 78946
5d360b
O-Subject: [RHEL-7.5 qemu-kvm PATCH v1 17/27] ui: avoid pointless VNC updates if framebuffer isn't dirty
5d360b
Bugzilla: 1527405
5d360b
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
5d360b
RH-Acked-by: Gerd Hoffmann <kraxel@redhat.com>
5d360b
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
5d360b
5d360b
From: "Daniel P. Berrange" <berrange@redhat.com>
5d360b
5d360b
The vnc_update_client() method checks the 'has_dirty' flag to see if there are
5d360b
dirty regions that are pending to send to the client. Regardless of this flag,
5d360b
if a forced update is requested, updates must be sent. For unknown reasons
5d360b
though, the code also tries to sent updates if audio capture is enabled. This
5d360b
makes no sense as audio capture state does not impact framebuffer contents, so
5d360b
this check is removed.
5d360b
5d360b
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
5d360b
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
5d360b
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
5d360b
Message-id: 20171218191228.31018-5-berrange@redhat.com
5d360b
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
5d360b
(cherry picked from commit 3541b08475d51bddf8aded36576a0ff5a547a978)
5d360b
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
5d360b
---
5d360b
 ui/vnc.c | 2 +-
5d360b
 1 file changed, 1 insertion(+), 1 deletion(-)
5d360b
5d360b
diff --git a/ui/vnc.c b/ui/vnc.c
5d360b
index aebaa37..eea5702 100644
5d360b
--- a/ui/vnc.c
5d360b
+++ b/ui/vnc.c
5d360b
@@ -869,7 +869,7 @@ static int vnc_update_client(VncState *vs, int has_dirty)
5d360b
         return 0;
5d360b
     }
5d360b
 
5d360b
-    if (!vs->has_dirty && !vs->audio_cap && !vs->force_update) {
5d360b
+    if (!vs->has_dirty && !vs->force_update) {
5d360b
         return 0;
5d360b
     }
5d360b
 
5d360b
-- 
5d360b
1.8.3.1
5d360b