From 5bb9f99d9dbe71424f656f597b650d5088faca23 Mon Sep 17 00:00:00 2001

From: Thomas Huth <thuth@redhat.com>

Date: Fri, 29 Mar 2019 11:13:35 +0000

Subject: [PATCH 1/7] s390x/cpumodel: mepochptff: warn when no mepoch and

 re-align group init

RH-Author: Thomas Huth <thuth@redhat.com>

Message-id: <1553858017-376-2-git-send-email-thuth@redhat.com>

Patchwork-id: 85237

O-Subject: [RHEL-8.1.0 qemu-kvm PATCH 1/3] s390x/cpumodel: mepochptff: warn when no mepoch and re-align group init

Bugzilla: 1664371

RH-Acked-by: David Hildenbrand <david@redhat.com>

RH-Acked-by: Cornelia Huck <cohuck@redhat.com>

RH-Acked-by: Jens Freimann <jfreimann@redhat.com>

From: Collin Walling <walling@linux.ibm.com>

The extended PTFF features (qsie, qtoue, stoe, stoue) are dependent

on the multiple-epoch facility (mepoch). Let's print a warning if these

features are enabled without mepoch.

While we're at it, let's move the FEAT_GROUP_INIT for mepochptff down

the s390_feature_groups list so it can be properly indexed with its

generated S390FeatGroup enum.

Signed-off-by: Collin Walling <walling@linux.ibm.com>

Message-Id: <20190212011657.18324-1-walling@linux.ibm.com>

Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>

Reviewed-by: David Hildenbrand <david@redhat.com>

Signed-off-by: Cornelia Huck <cohuck@redhat.com>

(cherry picked from commit ddf5d18af3ce3029d5b93222af5a9e8160d4c34b)

Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>

---

 target/s390x/cpu_features.c | 2 +-

 target/s390x/cpu_models.c   | 4 ++++

 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c

index 0fbee27..91e40c2 100644

--- a/target/s390x/cpu_features.c

+++ b/target/s390x/cpu_features.c

@@ -457,7 +457,6 @@ static S390FeatGroupDef s390_feature_groups[] = {

     FEAT_GROUP_INIT("plo", PLO, "Perform-locked-operation facility"),

     FEAT_GROUP_INIT("tods", TOD_CLOCK_STEERING, "Tod-clock-steering facility"),

     FEAT_GROUP_INIT("gen13ptff", GEN13_PTFF, "PTFF enhancements introduced with z13"),

-    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

     FEAT_GROUP_INIT("msa", MSA, "Message-security-assist facility"),

     FEAT_GROUP_INIT("msa1", MSA_EXT_1, "Message-security-assist-extension 1 facility"),

     FEAT_GROUP_INIT("msa2", MSA_EXT_2, "Message-security-assist-extension 2 facility"),

@@ -467,6 +466,7 @@ static S390FeatGroupDef s390_feature_groups[] = {

     FEAT_GROUP_INIT("msa6", MSA_EXT_6, "Message-security-assist-extension 6 facility"),

     FEAT_GROUP_INIT("msa7", MSA_EXT_7, "Message-security-assist-extension 7 facility"),

     FEAT_GROUP_INIT("msa8", MSA_EXT_8, "Message-security-assist-extension 8 facility"),

+    FEAT_GROUP_INIT("mepochptff", MULTIPLE_EPOCH_PTFF, "PTFF enhancements introduced with Multiple-epoch facility"),

 };

 const S390FeatGroupDef *s390_feat_group_def(S390FeatGroup group)

diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c

index 3856104..43f16a7 100644

--- a/target/s390x/cpu_models.c

+++ b/target/s390x/cpu_models.c

@@ -776,6 +776,10 @@ static void check_consistency(const S390CPUModel *model)

         { S390_FEAT_SIE_KSS, S390_FEAT_SIE_F2 },

         { S390_FEAT_AP_QUERY_CONFIG_INFO, S390_FEAT_AP },

         { S390_FEAT_AP_FACILITIES_TEST, S390_FEAT_AP },

+        { S390_FEAT_PTFF_QSIE, S390_FEAT_MULTIPLE_EPOCH },

+        { S390_FEAT_PTFF_QTOUE, S390_FEAT_MULTIPLE_EPOCH },

+        { S390_FEAT_PTFF_STOE, S390_FEAT_MULTIPLE_EPOCH },

+        { S390_FEAT_PTFF_STOUE, S390_FEAT_MULTIPLE_EPOCH },

     };

     int i;

-- 

1.8.3.1