|
 |
9ae3a8 |
From 2badec2441d95d693d7125d87fa8867f24f1ea9d Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Date: Sat, 2 Nov 2013 15:05:06 +0100
|
|
|
9ae3a8 |
Subject: [PATCH 49/81] rhel: Drop "isa-vga" device
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1383404707-6015-2-git-send-email-armbru@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 55272
|
|
|
9ae3a8 |
O-Subject: [PATCH 7.0 qemu-kvm 1/2] rhel: Drop "isa-vga" device
|
|
|
9ae3a8 |
Bugzilla: 1001088
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Marcel Apfelbaum <marcel.a@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Alex Williamson <alex.williamson@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
We can drop a device from the build only when it isn't referenced from
|
|
|
9ae3a8 |
code we build. References come in two forms: extern symbols, and qdev
|
|
|
9ae3a8 |
driver names.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Unresolved extern symbols pose no real danger, because they fail
|
|
|
9ae3a8 |
safely at link time. The dropped code doesn't define any extern
|
|
|
9ae3a8 |
symbols anyway.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Unresolved driver names get detected only at runtime, so we better be
|
|
|
9ae3a8 |
extra careful. Occurences of the driver name outside the code dropped
|
|
|
9ae3a8 |
by this patch:
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
* default_list[] in vl.c: Used only to disable default VGA with
|
|
|
9ae3a8 |
-device isa-vga. Safe.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
* vga_available() in vl.c: Tests whether the device is compiled in.
|
|
|
9ae3a8 |
No change, because device "VGA" is still compiled in, therfore safe.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
* isa_vga_init() in hw/isa/isa-bus.c: Its only potential caller
|
|
|
9ae3a8 |
pc_vga_init() never calls in RHEL, because it never gets a null
|
|
|
9ae3a8 |
pci_bus argument. Safe.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
default-configs/x86_64-softmmu.mak | 1 -
|
|
|
9ae3a8 |
1 file changed, 1 deletion(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
default-configs/x86_64-softmmu.mak | 1 -
|
|
|
9ae3a8 |
1 files changed, 0 insertions(+), 1 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
|
|
|
9ae3a8 |
index 70d8bd9..e7c48ec 100644
|
|
|
9ae3a8 |
--- a/default-configs/x86_64-softmmu.mak
|
|
|
9ae3a8 |
+++ b/default-configs/x86_64-softmmu.mak
|
|
|
9ae3a8 |
@@ -6,7 +6,6 @@ include usb.mak
|
|
|
9ae3a8 |
CONFIG_VGA=y
|
|
|
9ae3a8 |
CONFIG_QXL=$(CONFIG_SPICE)
|
|
|
9ae3a8 |
CONFIG_VGA_PCI=y
|
|
|
9ae3a8 |
-CONFIG_VGA_ISA=y
|
|
|
9ae3a8 |
CONFIG_VGA_CIRRUS=y
|
|
|
9ae3a8 |
CONFIG_VMMOUSE=y
|
|
|
9ae3a8 |
CONFIG_SERIAL=y
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|