|
 |
9ae3a8 |
From f54c8f7db9bca89e9989cbfe1af652f5b4552c92 Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Vlad Yasevich <vyasevic@redhat.com>
|
|
|
9ae3a8 |
Date: Thu, 4 Sep 2014 20:31:00 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 5/6] qdev-properties-system.c: Allow vlan or netdev for -device, not both
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Message-id: <1409862660-30181-1-git-send-email-vyasevic@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 60839
|
|
|
9ae3a8 |
O-Subject: [RHEL7.1 qemu-kvm PATCH] qdev-properties-system.c: Allow vlan or netdev for -device, not both
|
|
|
9ae3a8 |
Bugzilla: 996011
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Xiao Wang <jasowang@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Vlad Yasevich <vyasevic@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
It is currently possible to specify things like:
|
|
|
9ae3a8 |
-device e1000,netdev=foo,vlan=1
|
|
|
9ae3a8 |
With this usage, whichever argument was specified last (vlan or netdev)
|
|
|
9ae3a8 |
overwrites what was previousely set and results in a non-working
|
|
|
9ae3a8 |
configuration. Even worse, when used with multiqueue devices,
|
|
|
9ae3a8 |
it causes a segmentation fault on exit in qemu_free_net_client.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
That patch treates the above command line options as invalid and
|
|
|
9ae3a8 |
generates an error at start-up.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
|
|
|
9ae3a8 |
Acked-by: Jason Wang <jasowang@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9ae3a8 |
(cherry picked from commit 30c367ed446b6ea53245589a5cf373578ac075d7)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
hw/core/qdev-properties-system.c | 9 +++++++++
|
|
|
9ae3a8 |
1 files changed, 9 insertions(+), 0 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
|
|
|
9ae3a8 |
index 0eada32..729efa8 100644
|
|
|
9ae3a8 |
--- a/hw/core/qdev-properties-system.c
|
|
|
9ae3a8 |
+++ b/hw/core/qdev-properties-system.c
|
|
|
9ae3a8 |
@@ -205,6 +205,11 @@ static int parse_netdev(DeviceState *dev, const char *str, void **ptr)
|
|
|
9ae3a8 |
goto err;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
+ if (ncs[i]) {
|
|
|
9ae3a8 |
+ ret = -EINVAL;
|
|
|
9ae3a8 |
+ goto err;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
+
|
|
|
9ae3a8 |
ncs[i] = peers[i];
|
|
|
9ae3a8 |
ncs[i]->queue_index = i;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
@@ -301,6 +306,10 @@ static void set_vlan(Object *obj, Visitor *v, void *opaque,
|
|
|
9ae3a8 |
*ptr = NULL;
|
|
|
9ae3a8 |
return;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
+ if (*ptr) {
|
|
|
9ae3a8 |
+ error_set_from_qdev_prop_error(errp, -EINVAL, dev, prop, name);
|
|
|
9ae3a8 |
+ return;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
hubport = net_hub_port_find(id);
|
|
|
9ae3a8 |
if (!hubport) {
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|