|
 |
9ae3a8 |
From 48aa83a2a3e42665e3e3e390909ebc147e234f73 Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Date: Fri, 17 Jan 2014 17:07:57 +0100
|
|
|
9ae3a8 |
Subject: [PATCH 07/11] qdev: Do not let the user try to device_add when it cannot work
|
|
|
9ae3a8 |
MIME-Version: 1.0
|
|
|
9ae3a8 |
Content-Type: text/plain; charset=UTF-8
|
|
|
9ae3a8 |
Content-Transfer-Encoding: 8bit
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Message-id: <1389978479-30595-8-git-send-email-armbru@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 56788
|
|
|
9ae3a8 |
O-Subject: [PATCH 7.0 qemu-kvm 7/9] qdev: Do not let the user try to device_add when it cannot work
|
|
|
9ae3a8 |
Bugzilla: 669524
|
|
|
9ae3a8 |
RH-Acked-by: Eduardo Habkost <ehabkost@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Michael S. Tsirkin <mst@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Marcel Apfelbaum <marcel.a@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Such devices have always been unavailable and omitted from the list of
|
|
|
9ae3a8 |
available devices shown by device_add help. Until commit 18b6dad
|
|
|
9ae3a8 |
silently broke the former, setting up nasty traps for unwary users,
|
|
|
9ae3a8 |
like this one:
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
$ qemu-system-x86_64 -nodefaults -monitor stdio -display none
|
|
|
9ae3a8 |
QEMU 1.6.50 monitor - type 'help' for more information
|
|
|
9ae3a8 |
(qemu) device_add apic
|
|
|
9ae3a8 |
Segmentation fault (core dumped)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
I call that a regression. Fix it.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Markus Armbruster <armbru@redhat.com>
|
|
|
9ae3a8 |
Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Andreas Färber <afaerber@suse.de>
|
|
|
9ae3a8 |
(cherry picked from commit 7ea5e78f3d8d64e99c4017ea211b7518f2629756)
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
qdev-monitor.c | 5 +++++
|
|
|
9ae3a8 |
1 file changed, 5 insertions(+)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
qdev-monitor.c | 5 +++++
|
|
|
9ae3a8 |
1 files changed, 5 insertions(+), 0 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/qdev-monitor.c b/qdev-monitor.c
|
|
|
9ae3a8 |
index eb05b4c..da7fe0d 100644
|
|
|
9ae3a8 |
--- a/qdev-monitor.c
|
|
|
9ae3a8 |
+++ b/qdev-monitor.c
|
|
|
9ae3a8 |
@@ -490,6 +490,11 @@ DeviceState *qdev_device_add(QemuOpts *opts)
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
dc = DEVICE_CLASS(oc);
|
|
|
9ae3a8 |
+ if (dc->cannot_instantiate_with_device_add_yet) {
|
|
|
9ae3a8 |
+ qerror_report(QERR_INVALID_PARAMETER_VALUE, "driver",
|
|
|
9ae3a8 |
+ "pluggable device type");
|
|
|
9ae3a8 |
+ return NULL;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
/* find bus */
|
|
|
9ae3a8 |
path = qemu_opt_get(opts, "bus");
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.7.1
|
|
|
9ae3a8 |
|