|
 |
9ae3a8 |
From f3113f5709ae7c1f1ca25b6075662c49fc415ca7 Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Max Reitz <mreitz@redhat.com>
|
|
|
9ae3a8 |
Date: Sat, 13 Jun 2015 16:22:16 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 22/42] qcow2: Split fail code in L1 and L2 checks
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Message-id: <1434212556-3927-23-git-send-email-mreitz@redhat.com>
|
|
|
9ae3a8 |
Patchwork-id: 66041
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.2 qemu-kvm PATCH 22/42] qcow2: Split fail code in L1 and L2 checks
|
|
|
9ae3a8 |
Bugzilla: 1129893
|
|
|
9ae3a8 |
RH-Acked-by: Jeffrey Cody <jcody@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
BZ: 1129893
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Instead of printing out an error message, incrementing check_errors and
|
|
|
9ae3a8 |
returning a fixed -errno, just do cleanups and return -ret, with ret set
|
|
|
9ae3a8 |
by the code which threw the exception (jumped to the fail label).
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Also, increment check_errors on error in check_refcounts_l2().
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
9ae3a8 |
(cherry picked from commit ad27390c85c50df402c7ec0d3864fc43e6559fb3)
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Conflicts:
|
|
|
9ae3a8 |
block/qcow2-refcount.c
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
One conflict because of g_malloc() downstream instead of g_try_malloc()
|
|
|
9ae3a8 |
(contextual); I fixed up the context because there was no real reason
|
|
|
9ae3a8 |
not to.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Max Reitz <mreitz@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
block/qcow2-refcount.c | 29 +++++++++++++++++++----------
|
|
|
9ae3a8 |
1 file changed, 19 insertions(+), 10 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
|
|
|
9ae3a8 |
index 7e2bb7d..0dac4c9 100644
|
|
|
9ae3a8 |
--- a/block/qcow2-refcount.c
|
|
|
9ae3a8 |
+++ b/block/qcow2-refcount.c
|
|
|
9ae3a8 |
@@ -1105,14 +1105,18 @@ static int check_refcounts_l2(BlockDriverState *bs, BdrvCheckResult *res,
|
|
|
9ae3a8 |
BDRVQcowState *s = bs->opaque;
|
|
|
9ae3a8 |
uint64_t *l2_table, l2_entry;
|
|
|
9ae3a8 |
uint64_t next_contiguous_offset = 0;
|
|
|
9ae3a8 |
- int i, l2_size, nb_csectors;
|
|
|
9ae3a8 |
+ int i, l2_size, nb_csectors, ret;
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
/* Read L2 table from disk */
|
|
|
9ae3a8 |
l2_size = s->l2_size * sizeof(uint64_t);
|
|
|
9ae3a8 |
l2_table = g_malloc(l2_size);
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
- if (bdrv_pread(bs->file, l2_offset, l2_table, l2_size) != l2_size)
|
|
|
9ae3a8 |
+ ret = bdrv_pread(bs->file, l2_offset, l2_table, l2_size);
|
|
|
9ae3a8 |
+ if (ret < 0) {
|
|
|
9ae3a8 |
+ fprintf(stderr, "ERROR: I/O error in check_refcounts_l2\n");
|
|
|
9ae3a8 |
+ res->check_errors++;
|
|
|
9ae3a8 |
goto fail;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
/* Do the actual checks */
|
|
|
9ae3a8 |
for(i = 0; i < s->l2_size; i++) {
|
|
|
9ae3a8 |
@@ -1193,9 +1197,8 @@ static int check_refcounts_l2(BlockDriverState *bs, BdrvCheckResult *res,
|
|
|
9ae3a8 |
return 0;
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
fail:
|
|
|
9ae3a8 |
- fprintf(stderr, "ERROR: I/O error in check_refcounts_l2\n");
|
|
|
9ae3a8 |
g_free(l2_table);
|
|
|
9ae3a8 |
- return -EIO;
|
|
|
9ae3a8 |
+ return ret;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
/*
|
|
|
9ae3a8 |
@@ -1227,10 +1230,18 @@ static int check_refcounts_l1(BlockDriverState *bs,
|
|
|
9ae3a8 |
if (l1_size2 == 0) {
|
|
|
9ae3a8 |
l1_table = NULL;
|
|
|
9ae3a8 |
} else {
|
|
|
9ae3a8 |
- l1_table = g_malloc(l1_size2);
|
|
|
9ae3a8 |
- if (bdrv_pread(bs->file, l1_table_offset,
|
|
|
9ae3a8 |
- l1_table, l1_size2) != l1_size2)
|
|
|
9ae3a8 |
+ l1_table = g_try_malloc(l1_size2);
|
|
|
9ae3a8 |
+ if (l1_table == NULL) {
|
|
|
9ae3a8 |
+ ret = -ENOMEM;
|
|
|
9ae3a8 |
+ res->check_errors++;
|
|
|
9ae3a8 |
+ goto fail;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
+ ret = bdrv_pread(bs->file, l1_table_offset, l1_table, l1_size2);
|
|
|
9ae3a8 |
+ if (ret < 0) {
|
|
|
9ae3a8 |
+ fprintf(stderr, "ERROR: I/O error in check_refcounts_l1\n");
|
|
|
9ae3a8 |
+ res->check_errors++;
|
|
|
9ae3a8 |
goto fail;
|
|
|
9ae3a8 |
+ }
|
|
|
9ae3a8 |
for(i = 0;i < l1_size; i++)
|
|
|
9ae3a8 |
be64_to_cpus(&l1_table[i]);
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
@@ -1263,10 +1274,8 @@ static int check_refcounts_l1(BlockDriverState *bs,
|
|
|
9ae3a8 |
return 0;
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
fail:
|
|
|
9ae3a8 |
- fprintf(stderr, "ERROR: I/O error in check_refcounts_l1\n");
|
|
|
9ae3a8 |
- res->check_errors++;
|
|
|
9ae3a8 |
g_free(l1_table);
|
|
|
9ae3a8 |
- return -EIO;
|
|
|
9ae3a8 |
+ return ret;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
/*
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|