From 47eda5e717db143f5135e00f5bd6a478f613c28d Mon Sep 17 00:00:00 2001

From: John Snow <jsnow@redhat.com>

Date: Tue, 25 Sep 2018 22:34:28 +0100

Subject: [PATCH 25/28] qapi/block-mirror: expose new job properties

RH-Author: John Snow <jsnow@redhat.com>

Message-id: <20180925223431.24791-23-jsnow@redhat.com>

Patchwork-id: 82274

O-Subject: [RHEL8/rhel qemu-kvm PATCH 22/25] qapi/block-mirror: expose new job properties

Bugzilla: 1632939

RH-Acked-by: Jeffrey Cody <jcody@redhat.com>

RH-Acked-by: Max Reitz <mreitz@redhat.com>

RH-Acked-by: Kevin Wolf <kwolf@redhat.com>

Signed-off-by: John Snow <jsnow@redhat.com>

Reviewed-by: Max Reitz <mreitz@redhat.com>

Message-id: 20180906130225.5118-14-jsnow@redhat.com

Reviewed-by: Jeff Cody <jcody@redhat.com>

Signed-off-by: Max Reitz <mreitz@redhat.com>

(cherry picked from commit a6b58adec28ff43c0f29ff7c95cdd5d11e87cf61)

Signed-off-by: John Snow <jsnow@redhat.com>

Conflicts: downstream does not have has_copy_mode.

    -blockdev.c

    -qapi/block-core.json

Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>

---

 blockdev.c           | 14 ++++++++++++++

 qapi/block-core.json | 30 ++++++++++++++++++++++++++++--

 2 files changed, 42 insertions(+), 2 deletions(-)

diff --git a/blockdev.c b/blockdev.c

index 10b5944..fadafe0 100644

--- a/blockdev.c

+++ b/blockdev.c

@@ -3707,6 +3707,8 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,

                                    bool has_unmap, bool unmap,

                                    bool has_filter_node_name,

                                    const char *filter_node_name,

+                                   bool has_auto_finalize, bool auto_finalize,

+                                   bool has_auto_dismiss, bool auto_dismiss,

                                    Error **errp)

 {

     int job_flags = JOB_DEFAULT;

@@ -3732,6 +3734,12 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs,

     if (!has_filter_node_name) {

         filter_node_name = NULL;

     }

+    if (has_auto_finalize && !auto_finalize) {

+        job_flags |= JOB_MANUAL_FINALIZE;

+    }

+    if (has_auto_dismiss && !auto_dismiss) {

+        job_flags |= JOB_MANUAL_DISMISS;

+    }

     if (granularity != 0 && (granularity < 512 || granularity > 1048576 * 64)) {

         error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "granularity",

@@ -3908,6 +3916,8 @@ void qmp_drive_mirror(DriveMirror *arg, Error **errp)

                            arg->has_on_target_error, arg->on_target_error,

                            arg->has_unmap, arg->unmap,

                            false, NULL,

+                           arg->has_auto_finalize, arg->auto_finalize,

+                           arg->has_auto_dismiss, arg->auto_dismiss,

                            &local_err);

     bdrv_unref(target_bs);

     error_propagate(errp, local_err);

@@ -3928,6 +3938,8 @@ void qmp_blockdev_mirror(bool has_job_id, const char *job_id,

                          BlockdevOnError on_target_error,

                          bool has_filter_node_name,

                          const char *filter_node_name,

+                         bool has_auto_finalize, bool auto_finalize,

+                         bool has_auto_dismiss, bool auto_dismiss,

                          Error **errp)

 {

     BlockDriverState *bs;

@@ -3960,6 +3972,8 @@ void qmp_blockdev_mirror(bool has_job_id, const char *job_id,

                            has_on_target_error, on_target_error,

                            true, true,

                            has_filter_node_name, filter_node_name,

+                           has_auto_finalize, auto_finalize,

+                           has_auto_dismiss, auto_dismiss,

                            &local_err);

     error_propagate(errp, local_err);

diff --git a/qapi/block-core.json b/qapi/block-core.json

index c29c4b6..3f9ff18 100644

--- a/qapi/block-core.json

+++ b/qapi/block-core.json

@@ -1706,6 +1706,18 @@

 #         written. Both will result in identical contents.

 #         Default is true. (Since 2.4)

 #

+# @auto-finalize: When false, this job will wait in a PENDING state after it has

+#                 finished its work, waiting for @block-job-finalize before

+#                 making any block graph changes.

+#                 When true, this job will automatically

+#                 perform its abort or commit actions.

+#                 Defaults to true. (Since 3.1)

+#

+# @auto-dismiss: When false, this job will wait in a CONCLUDED state after it

+#                has completely ceased all work, and awaits @block-job-dismiss.

+#                When true, this job will automatically disappear from the query

+#                list without user intervention.

+#                Defaults to true. (Since 3.1)

 # Since: 1.3

 ##

 { 'struct': 'DriveMirror',

@@ -1715,7 +1727,8 @@

             '*speed': 'int', '*granularity': 'uint32',

             '*buf-size': 'int', '*on-source-error': 'BlockdevOnError',

             '*on-target-error': 'BlockdevOnError',

-            '*unmap': 'bool' } }

+            '*unmap': 'bool',

+            '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } }

 ##

 # @BlockDirtyBitmap:

@@ -1978,6 +1991,18 @@

 #                    above @device. If this option is not given, a node name is

 #                    autogenerated. (Since: 2.9)

 #

+# @auto-finalize: When false, this job will wait in a PENDING state after it has

+#                 finished its work, waiting for @block-job-finalize before

+#                 making any block graph changes.

+#                 When true, this job will automatically

+#                 perform its abort or commit actions.

+#                 Defaults to true. (Since 3.1)

+#

+# @auto-dismiss: When false, this job will wait in a CONCLUDED state after it

+#                has completely ceased all work, and awaits @block-job-dismiss.

+#                When true, this job will automatically disappear from the query

+#                list without user intervention.

+#                Defaults to true. (Since 3.1)

 # Returns: nothing on success.

 #

 # Since: 2.6

@@ -1998,7 +2023,8 @@

             '*speed': 'int', '*granularity': 'uint32',

             '*buf-size': 'int', '*on-source-error': 'BlockdevOnError',

             '*on-target-error': 'BlockdevOnError',

-            '*filter-node-name': 'str' } }

+            '*filter-node-name': 'str',

+            '*auto-finalize': 'bool', '*auto-dismiss': 'bool' } }

 ##

 # @block_set_io_throttle:

-- 

1.8.3.1