From 7ab2261eebf90ea8a3cf5701fa177d181fe665d1 Mon Sep 17 00:00:00 2001

From: Laurent Vivier <lvivier@redhat.com>

Date: Thu, 10 Oct 2019 07:34:38 +0100

Subject: [PATCH 22/22] pseries: do not allow memory-less/cpu-less NUMA node

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

RH-Author: Laurent Vivier <lvivier@redhat.com>

Message-id: <20191010073438.16478-1-lvivier@redhat.com>

Patchwork-id: 91379

O-Subject: [RHEL-8.2.0 qemu-kvm PATCH] pseries: do not allow memory-less/cpu-less NUMA node

Bugzilla: 1651474

RH-Acked-by: David Gibson <dgibson@redhat.com>

RH-Acked-by: Thomas Huth <thuth@redhat.com>

RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>

When we hotplug a CPU on memory-less/cpu-less node, the linux kernel

crashes.

This happens because linux kernel needs to know the NUMA topology at

start to be able to initialize the distance lookup table.

On pseries, the topology is provided by the firmware via the existing

CPUs and memory information. Thus a node without memory and CPU cannot be

discovered by the kernel.

To avoid the kernel crash, do not allow to start pseries with empty

nodes.

Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Message-Id: <20190830161345.22436-1-lvivier@redhat.com>

[dwg: Rework to cope with movement of numa state from globals to MachineState]

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

(cherry picked from commit 58c46efa451caa3935224223f950216872e2eee3)

Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Conflicts in the context:

	hw/ppc/spapr.c

because of missing downstream commits:

  0550b1206a91 ("spapr: don't advertise radix GTSE if max-compat-cpu < power9")

  ad99d04c76de ("target/ppc: Allow cpu compatiblity checks based on type, not instance")

because of missing donwtream commit:

  7e721e7b10e1 ("numa: move numa global variable numa_info into MachineState")

replaced numa_state by numa_info (revert dwg rework), back to original

patch I sent:

  https://patchew.org/QEMU/20190830161345.22436-1-lvivier@redhat.com/

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1651474

BRANCH: rhel-8.2.0

UPSTREAM: merged

BREW: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=23924908

Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>

---

 hw/ppc/spapr.c | 33 +++++++++++++++++++++++++++++++++

 1 file changed, 33 insertions(+)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c

index 1a2f0d9..b4c9993 100644

--- a/hw/ppc/spapr.c

+++ b/hw/ppc/spapr.c

@@ -2527,6 +2527,39 @@ static void spapr_machine_init(MachineState *machine)

     /* init CPUs */

     spapr_init_cpus(spapr);

+    /*

+     * check we don't have a memory-less/cpu-less NUMA node

+     * Firmware relies on the existing memory/cpu topology to provide the

+     * NUMA topology to the kernel.

+     * And the linux kernel needs to know the NUMA topology at start

+     * to be able to hotplug CPUs later.

+     */

+    if (nb_numa_nodes) {

+        for (i = 0; i < nb_numa_nodes; ++i) {

+            /* check for memory-less node */

+            if (numa_info[i].node_mem == 0) {

+                CPUState *cs;

+                int found = 0;

+                /* check for cpu-less node */

+                CPU_FOREACH(cs) {

+                    PowerPCCPU *cpu = POWERPC_CPU(cs);

+                    if (cpu->node_id == i) {

+                        found = 1;

+                        break;

+                    }

+                }

+                /* memory-less and cpu-less node */

+                if (!found) {

+                    error_report(

+                       "Memory-less/cpu-less nodes are not supported (node %d)",

+                                 i);

+                    exit(1);

+                }

+            }

+        }

+

+    }

+

     if (kvm_enabled()) {

         /* Enable H_LOGICAL_CI_* so SLOF can talk to in-kernel devices */

         kvmppc_enable_logical_ci_hcalls();

-- 

1.8.3.1