|
 |
4ec855 |
From ad3b92699ba5e2280950fa9866f79673cecdb695 Mon Sep 17 00:00:00 2001
|
|
|
4ec855 |
From: Thomas Huth <thuth@redhat.com>
|
|
|
4ec855 |
Date: Mon, 14 Oct 2019 10:06:29 +0100
|
|
|
4ec855 |
Subject: [PATCH 04/21] pc-bios/s390-ccw: define loadparm length
|
|
|
4ec855 |
|
|
|
4ec855 |
RH-Author: Thomas Huth <thuth@redhat.com>
|
|
|
4ec855 |
Message-id: <20191014100645.22862-2-thuth@redhat.com>
|
|
|
4ec855 |
Patchwork-id: 91780
|
|
|
4ec855 |
O-Subject: [RHEL-8.2.0 qemu-kvm PATCH v2 01/17] pc-bios/s390-ccw: define loadparm length
|
|
|
4ec855 |
Bugzilla: 1664376
|
|
|
4ec855 |
RH-Acked-by: Cornelia Huck <cohuck@redhat.com>
|
|
|
4ec855 |
RH-Acked-by: David Hildenbrand <david@redhat.com>
|
|
|
4ec855 |
RH-Acked-by: Jens Freimann <jfreimann@redhat.com>
|
|
|
4ec855 |
|
|
|
4ec855 |
From: Collin Walling <walling@linux.ibm.com>
|
|
|
4ec855 |
|
|
|
4ec855 |
Loadparm is defined by the s390 architecture to be 8 bytes
|
|
|
4ec855 |
in length. Let's define this size in the s390-ccw bios.
|
|
|
4ec855 |
|
|
|
4ec855 |
Suggested-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
4ec855 |
Signed-off-by: Collin Walling <walling@linux.ibm.com>
|
|
|
4ec855 |
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
4ec855 |
Reviewed-by: Thomas Huth <thuth@redhat.com>
|
|
|
4ec855 |
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
|
|
4ec855 |
(cherry picked from commit a0e11b617b9ef41cefe8739dff4d6a7b01ca967f)
|
|
|
4ec855 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
4ec855 |
---
|
|
|
4ec855 |
pc-bios/s390-ccw/iplb.h | 4 +++-
|
|
|
4ec855 |
pc-bios/s390-ccw/main.c | 8 ++++----
|
|
|
4ec855 |
pc-bios/s390-ccw/sclp.c | 2 +-
|
|
|
4ec855 |
pc-bios/s390-ccw/sclp.h | 2 +-
|
|
|
4ec855 |
4 files changed, 9 insertions(+), 7 deletions(-)
|
|
|
4ec855 |
|
|
|
4ec855 |
diff --git a/pc-bios/s390-ccw/iplb.h b/pc-bios/s390-ccw/iplb.h
|
|
|
4ec855 |
index ded20c8..772d5c5 100644
|
|
|
4ec855 |
--- a/pc-bios/s390-ccw/iplb.h
|
|
|
4ec855 |
+++ b/pc-bios/s390-ccw/iplb.h
|
|
|
4ec855 |
@@ -12,6 +12,8 @@
|
|
|
4ec855 |
#ifndef IPLB_H
|
|
|
4ec855 |
#define IPLB_H
|
|
|
4ec855 |
|
|
|
4ec855 |
+#define LOADPARM_LEN 8
|
|
|
4ec855 |
+
|
|
|
4ec855 |
struct IplBlockCcw {
|
|
|
4ec855 |
uint8_t reserved0[85];
|
|
|
4ec855 |
uint8_t ssid;
|
|
|
4ec855 |
@@ -61,7 +63,7 @@ struct IplParameterBlock {
|
|
|
4ec855 |
uint8_t pbt;
|
|
|
4ec855 |
uint8_t flags;
|
|
|
4ec855 |
uint16_t reserved01;
|
|
|
4ec855 |
- uint8_t loadparm[8];
|
|
|
4ec855 |
+ uint8_t loadparm[LOADPARM_LEN];
|
|
|
4ec855 |
union {
|
|
|
4ec855 |
IplBlockCcw ccw;
|
|
|
4ec855 |
IplBlockFcp fcp;
|
|
|
4ec855 |
diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
|
|
|
4ec855 |
index 26f9adf..544851d 100644
|
|
|
4ec855 |
--- a/pc-bios/s390-ccw/main.c
|
|
|
4ec855 |
+++ b/pc-bios/s390-ccw/main.c
|
|
|
4ec855 |
@@ -15,7 +15,7 @@
|
|
|
4ec855 |
char stack[PAGE_SIZE * 8] __attribute__((__aligned__(PAGE_SIZE)));
|
|
|
4ec855 |
static SubChannelId blk_schid = { .one = 1 };
|
|
|
4ec855 |
IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));
|
|
|
4ec855 |
-static char loadparm_str[9] = { 0, 0, 0, 0, 0, 0, 0, 0, 0 };
|
|
|
4ec855 |
+static char loadparm_str[LOADPARM_LEN + 1] = { 0, 0, 0, 0, 0, 0, 0, 0, 0 };
|
|
|
4ec855 |
QemuIplParameters qipl;
|
|
|
4ec855 |
|
|
|
4ec855 |
#define LOADPARM_PROMPT "PROMPT "
|
|
|
4ec855 |
@@ -80,13 +80,13 @@ static bool find_dev(Schib *schib, int dev_no)
|
|
|
4ec855 |
|
|
|
4ec855 |
static void menu_setup(void)
|
|
|
4ec855 |
{
|
|
|
4ec855 |
- if (memcmp(loadparm_str, LOADPARM_PROMPT, 8) == 0) {
|
|
|
4ec855 |
+ if (memcmp(loadparm_str, LOADPARM_PROMPT, LOADPARM_LEN) == 0) {
|
|
|
4ec855 |
menu_set_parms(QIPL_FLAG_BM_OPTS_CMD, 0);
|
|
|
4ec855 |
return;
|
|
|
4ec855 |
}
|
|
|
4ec855 |
|
|
|
4ec855 |
/* If loadparm was set to any other value, then do not enable menu */
|
|
|
4ec855 |
- if (memcmp(loadparm_str, LOADPARM_EMPTY, 8) != 0) {
|
|
|
4ec855 |
+ if (memcmp(loadparm_str, LOADPARM_EMPTY, LOADPARM_LEN) != 0) {
|
|
|
4ec855 |
return;
|
|
|
4ec855 |
}
|
|
|
4ec855 |
|
|
|
4ec855 |
@@ -117,7 +117,7 @@ static void virtio_setup(void)
|
|
|
4ec855 |
enable_mss_facility();
|
|
|
4ec855 |
|
|
|
4ec855 |
sclp_get_loadparm_ascii(loadparm_str);
|
|
|
4ec855 |
- memcpy(ldp + 10, loadparm_str, 8);
|
|
|
4ec855 |
+ memcpy(ldp + 10, loadparm_str, LOADPARM_LEN);
|
|
|
4ec855 |
sclp_print(ldp);
|
|
|
4ec855 |
|
|
|
4ec855 |
memcpy(&qipl, early_qipl, sizeof(QemuIplParameters));
|
|
|
4ec855 |
diff --git a/pc-bios/s390-ccw/sclp.c b/pc-bios/s390-ccw/sclp.c
|
|
|
4ec855 |
index 3836cb4..c0223fa 100644
|
|
|
4ec855 |
--- a/pc-bios/s390-ccw/sclp.c
|
|
|
4ec855 |
+++ b/pc-bios/s390-ccw/sclp.c
|
|
|
4ec855 |
@@ -114,7 +114,7 @@ void sclp_get_loadparm_ascii(char *loadparm)
|
|
|
4ec855 |
memset((char *)_sccb, 0, sizeof(ReadInfo));
|
|
|
4ec855 |
sccb->h.length = sizeof(ReadInfo);
|
|
|
4ec855 |
if (!sclp_service_call(SCLP_CMDW_READ_SCP_INFO, sccb)) {
|
|
|
4ec855 |
- ebcdic_to_ascii((char *) sccb->loadparm, loadparm, 8);
|
|
|
4ec855 |
+ ebcdic_to_ascii((char *) sccb->loadparm, loadparm, LOADPARM_LEN);
|
|
|
4ec855 |
}
|
|
|
4ec855 |
}
|
|
|
4ec855 |
|
|
|
4ec855 |
diff --git a/pc-bios/s390-ccw/sclp.h b/pc-bios/s390-ccw/sclp.h
|
|
|
4ec855 |
index 0dd987f..8450161 100644
|
|
|
4ec855 |
--- a/pc-bios/s390-ccw/sclp.h
|
|
|
4ec855 |
+++ b/pc-bios/s390-ccw/sclp.h
|
|
|
4ec855 |
@@ -56,7 +56,7 @@ typedef struct ReadInfo {
|
|
|
4ec855 |
uint16_t rnmax;
|
|
|
4ec855 |
uint8_t rnsize;
|
|
|
4ec855 |
uint8_t reserved[13];
|
|
|
4ec855 |
- uint8_t loadparm[8];
|
|
|
4ec855 |
+ uint8_t loadparm[LOADPARM_LEN];
|
|
|
4ec855 |
} __attribute__((packed)) ReadInfo;
|
|
|
4ec855 |
|
|
|
4ec855 |
typedef struct SCCB {
|
|
|
4ec855 |
--
|
|
|
4ec855 |
1.8.3.1
|
|
|
4ec855 |
|