|
 |
4ec855 |
From e541592f0c98696276261a7c36afe074a3bdd956 Mon Sep 17 00:00:00 2001
|
|
|
4ec855 |
From: Maxim Levitsky <mlevitsk@redhat.com>
|
|
|
4ec855 |
Date: Wed, 18 Sep 2019 18:45:52 +0100
|
|
|
4ec855 |
Subject: [PATCH 11/22] ccid: Fix dwProtocols advertisement of T=0
|
|
|
4ec855 |
MIME-Version: 1.0
|
|
|
4ec855 |
Content-Type: text/plain; charset=UTF-8
|
|
|
4ec855 |
Content-Transfer-Encoding: 8bit
|
|
|
4ec855 |
|
|
|
4ec855 |
RH-Author: Maxim Levitsky <mlevitsk@redhat.com>
|
|
|
4ec855 |
Message-id: <20190918184552.10820-2-mlevitsk@redhat.com>
|
|
|
4ec855 |
Patchwork-id: 90769
|
|
|
4ec855 |
O-Subject: [RHEL-8.2.0 qemu-kvm PATCH 1/1] ccid: Fix dwProtocols advertisement of T=0
|
|
|
4ec855 |
Bugzilla: 1746361
|
|
|
4ec855 |
RH-Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
|
|
4ec855 |
RH-Acked-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
4ec855 |
RH-Acked-by: John Snow <jsnow@redhat.com>
|
|
|
4ec855 |
|
|
|
4ec855 |
From: Jason Andryuk <jandryuk@gmail.com>
|
|
|
4ec855 |
|
|
|
4ec855 |
Commit d7d218ef02d87c637d20d64da8f575d434ff6f78 attempted to change
|
|
|
4ec855 |
dwProtocols to only advertise support for T=0 and not T=1. The change
|
|
|
4ec855 |
was incorrect as it changed 0x00000003 to 0x00010000.
|
|
|
4ec855 |
|
|
|
4ec855 |
lsusb -v in a linux guest shows:
|
|
|
4ec855 |
"dwProtocols 65536 (Invalid values detected)", though the
|
|
|
4ec855 |
smart card could still be accessed. Windows 7 does not detect inserted
|
|
|
4ec855 |
smart cards and logs the the following Error in the Event Logs:
|
|
|
4ec855 |
|
|
|
4ec855 |
Source: Smart Card Service
|
|
|
4ec855 |
Event ID: 610
|
|
|
4ec855 |
Smart Card Reader 'QEMU QEMU USB CCID 0' rejected IOCTL SET_PROTOCOL:
|
|
|
4ec855 |
Incorrect function. If this error persists, your smart card or reader
|
|
|
4ec855 |
may not be functioning correctly
|
|
|
4ec855 |
|
|
|
4ec855 |
Command Header: 03 00 00 00
|
|
|
4ec855 |
|
|
|
4ec855 |
Setting to 0x00000001 fixes the Windows issue.
|
|
|
4ec855 |
|
|
|
4ec855 |
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
|
|
|
4ec855 |
Message-id: 20180420183219.20722-1-jandryuk@gmail.com
|
|
|
4ec855 |
Cc: qemu-stable@nongnu.org
|
|
|
4ec855 |
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
|
4ec855 |
(cherry picked from commit 0ee86bb6c5beb6498488850104f7557c376d0bef)
|
|
|
4ec855 |
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
|
|
|
4ec855 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
4ec855 |
---
|
|
|
4ec855 |
hw/usb/dev-smartcard-reader.c | 4 ++--
|
|
|
4ec855 |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
4ec855 |
|
|
|
4ec855 |
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
|
|
|
4ec855 |
index e646805..cabb564 100644
|
|
|
4ec855 |
--- a/hw/usb/dev-smartcard-reader.c
|
|
|
4ec855 |
+++ b/hw/usb/dev-smartcard-reader.c
|
|
|
4ec855 |
@@ -329,8 +329,8 @@ static const uint8_t qemu_ccid_descriptor[] = {
|
|
|
4ec855 |
*/
|
|
|
4ec855 |
0x07, /* u8 bVoltageSupport; 01h - 5.0v, 02h - 3.0, 03 - 1.8 */
|
|
|
4ec855 |
|
|
|
4ec855 |
- 0x00, 0x00, /* u32 dwProtocols; RRRR PPPP. RRRR = 0000h.*/
|
|
|
4ec855 |
- 0x01, 0x00, /* PPPP: 0001h = Protocol T=0, 0002h = Protocol T=1 */
|
|
|
4ec855 |
+ 0x01, 0x00, /* u32 dwProtocols; RRRR PPPP. RRRR = 0000h.*/
|
|
|
4ec855 |
+ 0x00, 0x00, /* PPPP: 0001h = Protocol T=0, 0002h = Protocol T=1 */
|
|
|
4ec855 |
/* u32 dwDefaultClock; in kHZ (0x0fa0 is 4 MHz) */
|
|
|
4ec855 |
0xa0, 0x0f, 0x00, 0x00,
|
|
|
4ec855 |
/* u32 dwMaximumClock; */
|
|
|
4ec855 |
--
|
|
|
4ec855 |
1.8.3.1
|
|
|
4ec855 |
|