|
 |
ae23c9 |
From be690258db5ef9b4b80dd1d24d8a275ffc36f84c Mon Sep 17 00:00:00 2001
|
|
|
ae23c9 |
From: Kevin Wolf <kwolf@redhat.com>
|
|
|
ae23c9 |
Date: Thu, 10 Jan 2019 12:44:42 +0000
|
|
|
ae23c9 |
Subject: [PATCH 12/14] block: Fix update of BDRV_O_AUTO_RDONLY in
|
|
|
ae23c9 |
update_flags_from_options()
|
|
|
ae23c9 |
|
|
|
ae23c9 |
RH-Author: Kevin Wolf <kwolf@redhat.com>
|
|
|
ae23c9 |
Message-id: <20190110124442.30132-13-kwolf@redhat.com>
|
|
|
ae23c9 |
Patchwork-id: 83960
|
|
|
ae23c9 |
O-Subject: [RHEL-8.0 qemu-kvm PATCH 12/12] block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()
|
|
|
ae23c9 |
Bugzilla: 1644996
|
|
|
ae23c9 |
RH-Acked-by: Max Reitz <mreitz@redhat.com>
|
|
|
ae23c9 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
ae23c9 |
RH-Acked-by: Eric Blake <eblake@redhat.com>
|
|
|
ae23c9 |
|
|
|
ae23c9 |
From: Alberto Garcia <berto@igalia.com>
|
|
|
ae23c9 |
|
|
|
ae23c9 |
Commit e35bdc123a4ace9f4d3fcca added the auto-read-only option and the
|
|
|
ae23c9 |
code to update its corresponding flag in update_flags_from_options(),
|
|
|
ae23c9 |
but forgot to clear the flag if auto-read-only is false.
|
|
|
ae23c9 |
|
|
|
ae23c9 |
Signed-off-by: Alberto Garcia <berto@igalia.com>
|
|
|
ae23c9 |
Reported-by: Max Reitz <mreitz@redhat.com>
|
|
|
ae23c9 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
ae23c9 |
(cherry picked from commit 2a3d4331fa2d40708188b8000f98ff1f7dcd33bc)
|
|
|
ae23c9 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
ae23c9 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
ae23c9 |
---
|
|
|
ae23c9 |
block.c | 4 +---
|
|
|
ae23c9 |
1 file changed, 1 insertion(+), 3 deletions(-)
|
|
|
ae23c9 |
|
|
|
ae23c9 |
diff --git a/block.c b/block.c
|
|
|
ae23c9 |
index 268debe..d0f0dc6 100644
|
|
|
ae23c9 |
--- a/block.c
|
|
|
ae23c9 |
+++ b/block.c
|
|
|
ae23c9 |
@@ -1112,7 +1112,7 @@ static int bdrv_open_flags(BlockDriverState *bs, int flags)
|
|
|
ae23c9 |
|
|
|
ae23c9 |
static void update_flags_from_options(int *flags, QemuOpts *opts)
|
|
|
ae23c9 |
{
|
|
|
ae23c9 |
- *flags &= ~BDRV_O_CACHE_MASK;
|
|
|
ae23c9 |
+ *flags &= ~(BDRV_O_CACHE_MASK | BDRV_O_RDWR | BDRV_O_AUTO_RDONLY);
|
|
|
ae23c9 |
|
|
|
ae23c9 |
assert(qemu_opt_find(opts, BDRV_OPT_CACHE_NO_FLUSH));
|
|
|
ae23c9 |
if (qemu_opt_get_bool(opts, BDRV_OPT_CACHE_NO_FLUSH, false)) {
|
|
|
ae23c9 |
@@ -1124,8 +1124,6 @@ static void update_flags_from_options(int *flags, QemuOpts *opts)
|
|
|
ae23c9 |
*flags |= BDRV_O_NOCACHE;
|
|
|
ae23c9 |
}
|
|
|
ae23c9 |
|
|
|
ae23c9 |
- *flags &= ~BDRV_O_RDWR;
|
|
|
ae23c9 |
-
|
|
|
ae23c9 |
assert(qemu_opt_find(opts, BDRV_OPT_READ_ONLY));
|
|
|
ae23c9 |
if (!qemu_opt_get_bool(opts, BDRV_OPT_READ_ONLY, false)) {
|
|
|
ae23c9 |
*flags |= BDRV_O_RDWR;
|
|
|
ae23c9 |
--
|
|
|
ae23c9 |
1.8.3.1
|
|
|
ae23c9 |
|