|
 |
ae23c9 |
From 9997a461dc882720fff3990aeca0725a91f20ac3 Mon Sep 17 00:00:00 2001
|
|
|
ae23c9 |
From: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
ae23c9 |
Date: Wed, 12 Sep 2018 09:43:39 +0100
|
|
|
ae23c9 |
Subject: [PATCH 2/4] Fix annocheck issues
|
|
|
ae23c9 |
|
|
|
ae23c9 |
RH-Author: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
ae23c9 |
Message-id: <1536745419-16795-1-git-send-email-mrezanin@redhat.com>
|
|
|
ae23c9 |
Patchwork-id: 82139
|
|
|
ae23c9 |
O-Subject: [RHEL8/rhel qemu-kvm PATCH] Fix annocheck issues
|
|
|
ae23c9 |
Bugzilla: 1624164
|
|
|
ae23c9 |
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
ae23c9 |
RH-Acked-by: Danilo de Paula <ddepaula@redhat.com>
|
|
|
ae23c9 |
RH-Acked-by: Laszlo Ersek <lersek@redhat.com>
|
|
|
ae23c9 |
|
|
|
ae23c9 |
From: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
ae23c9 |
|
|
|
ae23c9 |
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1624164
|
|
|
ae23c9 |
Brew: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=18283300
|
|
|
ae23c9 |
BRANCH: rhel8/master-2.12.0
|
|
|
ae23c9 |
Upstream: Do we want have this upstream?
|
|
|
ae23c9 |
|
|
|
ae23c9 |
annocheck reports several issues with qemu-kvm packages.
|
|
|
ae23c9 |
|
|
|
ae23c9 |
Most of them is "Compiled without -D_GLIBCXX_ASSERTIONS.". These issues
|
|
|
ae23c9 |
comes from capstone submodule as we strip all -W compile flags. We can
|
|
|
ae23c9 |
add missing flag downstream but I'm not sure this change should be done
|
|
|
ae23c9 |
upstream too.
|
|
|
ae23c9 |
|
|
|
ae23c9 |
In addition, there's "Not linked with -Wl,-z,now." error for s390-ccw.img
|
|
|
ae23c9 |
and s390-netboot.img. However, this flag is used for building these files
|
|
|
ae23c9 |
as build log shows.
|
|
|
ae23c9 |
|
|
|
ae23c9 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
ae23c9 |
Signed-off-by: Danilo C. L. de Paula <ddepaula@redhat.com>
|
|
|
ae23c9 |
---
|
|
|
ae23c9 |
Makefile | 1 +
|
|
|
ae23c9 |
1 file changed, 1 insertion(+)
|
|
|
ae23c9 |
|
|
|
ae23c9 |
diff --git a/Makefile b/Makefile
|
|
|
ae23c9 |
index 9803f27..da3eedb 100644
|
|
|
ae23c9 |
--- a/Makefile
|
|
|
ae23c9 |
+++ b/Makefile
|
|
|
ae23c9 |
@@ -502,6 +502,7 @@ CAP_CFLAGS += -DCAPSTONE_HAS_ARM
|
|
|
ae23c9 |
CAP_CFLAGS += -DCAPSTONE_HAS_ARM64
|
|
|
ae23c9 |
CAP_CFLAGS += -DCAPSTONE_HAS_POWERPC
|
|
|
ae23c9 |
CAP_CFLAGS += -DCAPSTONE_HAS_X86
|
|
|
ae23c9 |
+CAP_CFLAGS += -Wp,-D_GLIBCXX_ASSERTIONS
|
|
|
ae23c9 |
|
|
|
ae23c9 |
subdir-capstone: .git-submodule-status
|
|
|
ae23c9 |
$(call quiet-command,$(MAKE) -C $(SRC_PATH)/capstone CAPSTONE_SHARED=no BUILDDIR="$(BUILD_DIR)/capstone" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(CAP_CFLAGS)" $(SUBDIR_MAKEFLAGS) $(BUILD_DIR)/capstone/$(LIBCAPSTONE))
|
|
|
ae23c9 |
--
|
|
|
ae23c9 |
1.8.3.1
|
|
|
ae23c9 |
|