|
 |
719b13 |
From ad1844e7e2294fa71bc07f9d1da6d10150ba9607 Mon Sep 17 00:00:00 2001
|
|
|
719b13 |
From: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
719b13 |
Date: Thu, 9 Jun 2022 17:47:11 +0100
|
|
|
719b13 |
Subject: [PATCH 1/2] linux-aio: fix unbalanced plugged counter in
|
|
|
719b13 |
laio_io_unplug()
|
|
|
719b13 |
|
|
|
719b13 |
RH-Author: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
719b13 |
RH-MergeRequest: 209: linux-aio: fix unbalanced plugged counter in laio_io_unplug()
|
|
|
719b13 |
RH-Commit: [1/2] 3a73bdb8237cf99c5264a6e1caac632494412953
|
|
|
719b13 |
RH-Bugzilla: 2109570
|
|
|
719b13 |
RH-Acked-by: Hanna Reitz <hreitz@redhat.com>
|
|
|
719b13 |
RH-Acked-by: Kevin Wolf <kwolf@redhat.com>
|
|
|
719b13 |
RH-Acked-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
719b13 |
|
|
|
719b13 |
Every laio_io_plug() call has a matching laio_io_unplug() call. There is
|
|
|
719b13 |
a plugged counter that tracks the number of levels of plugging and
|
|
|
719b13 |
allows for nesting.
|
|
|
719b13 |
|
|
|
719b13 |
The plugged counter must reflect the balance between laio_io_plug() and
|
|
|
719b13 |
laio_io_unplug() calls accurately. Otherwise I/O stalls occur since
|
|
|
719b13 |
io_submit(2) calls are skipped while plugged.
|
|
|
719b13 |
|
|
|
719b13 |
Reported-by: Nikolay Tenev <nt@storpool.com>
|
|
|
719b13 |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
719b13 |
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
719b13 |
Message-id: 20220609164712.1539045-2-stefanha@redhat.com
|
|
|
719b13 |
Cc: Stefano Garzarella <sgarzare@redhat.com>
|
|
|
719b13 |
Fixes: 68d7946648 ("linux-aio: add `dev_max_batch` parameter to laio_io_unplug()")
|
|
|
719b13 |
[Stefano Garzarella suggested adding a Fixes tag.
|
|
|
719b13 |
--Stefan]
|
|
|
719b13 |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
719b13 |
(cherry picked from commit f387cac5af030a58ac5a0dacf64cab5e5a4fe5c7)
|
|
|
719b13 |
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
719b13 |
---
|
|
|
719b13 |
block/linux-aio.c | 4 +++-
|
|
|
719b13 |
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
719b13 |
|
|
|
719b13 |
diff --git a/block/linux-aio.c b/block/linux-aio.c
|
|
|
719b13 |
index f53ae72e21..77f17ad596 100644
|
|
|
719b13 |
--- a/block/linux-aio.c
|
|
|
719b13 |
+++ b/block/linux-aio.c
|
|
|
719b13 |
@@ -360,8 +360,10 @@ void laio_io_unplug(BlockDriverState *bs, LinuxAioState *s,
|
|
|
719b13 |
uint64_t dev_max_batch)
|
|
|
719b13 |
{
|
|
|
719b13 |
assert(s->io_q.plugged);
|
|
|
719b13 |
+ s->io_q.plugged--;
|
|
|
719b13 |
+
|
|
|
719b13 |
if (s->io_q.in_queue >= laio_max_batch(s, dev_max_batch) ||
|
|
|
719b13 |
- (--s->io_q.plugged == 0 &&
|
|
|
719b13 |
+ (!s->io_q.plugged &&
|
|
|
719b13 |
!s->io_q.blocked && !QSIMPLEQ_EMPTY(&s->io_q.pending))) {
|
|
|
719b13 |
ioq_submit(s);
|
|
|
719b13 |
}
|
|
|
719b13 |
--
|
|
|
719b13 |
2.35.3
|
|
|
719b13 |
|