From 28dfbf252a31b4e8c1d0f5e038f6889b7eadfc16 Mon Sep 17 00:00:00 2001

From: Honggang Li <honli@redhat.com>

Date: Wed, 1 Apr 2020 10:52:12 +0800

Subject: [PATCH] Fix a format security compilation defect

subcommands.cpp:1852:42: error: format not a string literal and no format arguments [-Werror=format-security]

1852 | false, "N/A").c_str());

Signed-off-by: Honggang Li <honli@redhat.com>

---

 flint/subcommands.cpp | 6 +++---

 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/flint/subcommands.cpp b/flint/subcommands.cpp

index 7230f9a59f94..0f6440be7b28 100755

--- a/flint/subcommands.cpp

+++ b/flint/subcommands.cpp

@@ -1847,7 +1847,7 @@ bool BurnSubCommand::checkFwVersion(bool CreateFromImgInfo, u_int16_t fw_ver0, u

     char curr_ver[124], new_ver[124];

     printf("\n");

     printf("    Current FW version on flash:  ");

-    snprintf(curr_ver, 124,

+    snprintf(curr_ver, 124, "%s",

             current.get_fw_version(VERSION_FORMAT(_devInfo.fw_info.fw_ver[1]),

                     false, "N/A").c_str());

@@ -1856,13 +1856,13 @@ bool BurnSubCommand::checkFwVersion(bool CreateFromImgInfo, u_int16_t fw_ver0, u

     printf("    New FW version:               ");

     if (CreateFromImgInfo) {

-        snprintf(new_ver, 124,

+        snprintf(new_ver, 124, "%s",

                 new_version.get_fw_version(

                         VERSION_FORMAT(_imgInfo.fw_info.fw_ver[1]), false,

                         "N/A").c_str());

     }

     else {

-        snprintf(new_ver, 124,

+        snprintf(new_ver, 124, "%s",

                 new_version.get_fw_version(VERSION_FORMAT(fw_ver1), false,

                         "N/A").c_str());

     }

-- 

2.25.1