ryantimwilson / rpms / systemd

Forked from rpms/systemd a month ago
Clone
Blob Blame History Raw
From 9ebdde4ac22bd0e33ffbb606a27fa79acb7fc7bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>
Date: Fri, 15 Mar 2019 00:04:17 +0100
Subject: [PATCH] Skip dhcp[6]-client tests

---
 src/libsystemd-network/test-dhcp-client.c  | 1 -
 src/libsystemd-network/test-dhcp6-client.c | 6 ++++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/libsystemd-network/test-dhcp-client.c b/src/libsystemd-network/test-dhcp-client.c
index fe6788d91b..9645d87c6c 100644
--- a/src/libsystemd-network/test-dhcp-client.c
+++ b/src/libsystemd-network/test-dhcp-client.c
@@ -566,7 +566,6 @@ int main(int argc, char *argv[]) {
         test_dhcp_identifier_set_iaid();
 
         test_discover_message(e);
-        test_addr_acq(e);
 
 #if VALGRIND
         /* Make sure the async_close thread has finished.
diff --git a/src/libsystemd-network/test-dhcp6-client.c b/src/libsystemd-network/test-dhcp6-client.c
index fa94b3cb75..2681cdf03f 100644
--- a/src/libsystemd-network/test-dhcp6-client.c
+++ b/src/libsystemd-network/test-dhcp6-client.c
@@ -889,7 +889,7 @@ static int test_client_solicit(sd_event *e) {
         sd_dhcp6_client *client;
         usec_t time_now = now(clock_boottime_or_monotonic());
         struct in6_addr address = { { { 0xfe, 0x80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x01 } } };
-        int val;
+        int val, r;
 
         log_debug("/* %s */", __func__);
 
@@ -919,7 +919,9 @@ static int test_client_solicit(sd_event *e) {
 
         assert_se(sd_dhcp6_client_set_local_address(client, &address) >= 0);
 
-        assert_se(sd_dhcp6_client_start(client) >= 0);
+        r = sd_dhcp6_client_start(client);
+        if (r < 0)
+                return log_warning_errno(r, "Failed to start dhcp6 client: %m");
 
         sd_event_loop(e);