From cc1ab04e1ce05fc0aa917249677ab2818ea87eee Mon Sep 17 00:00:00 2001

From: Tom Gundersen <teg@jklm.no>

Date: Wed, 24 Jul 2013 14:55:19 +0200

Subject: [PATCH] udev: log error if chmod/chown of static dev nodes fails

---

 src/udev/udev-rules.c | 16 ++++++++++++----

 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c

index 8ace705..fe4965f 100644

--- a/src/udev/udev-rules.c

+++ b/src/udev/udev-rules.c

@@ -2593,13 +2593,21 @@ int udev_rules_apply_static_dev_perms(struct udev_rules *rules)

                                         mode = 0600;

                         }

                         if (mode != (stats.st_mode & 01777)) {

-                                chmod(device_node, mode);

-                                log_debug("chmod '%s' %#o\n", device_node, mode);

+                                r = chmod(device_node, mode);

+                                if (r < 0) {

+                                        log_error("failed to chmod '%s' %#o\n", device_node, mode);

+                                        return -errno;

+                                } else

+                                        log_debug("chmod '%s' %#o\n", device_node, mode);

                         }

                         if ((uid != 0 && uid != stats.st_uid) || (gid != 0 && gid != stats.st_gid)) {

-                                chown(device_node, uid, gid);

-                                log_debug("chown '%s' %u %u\n", device_node, uid, gid);

+                                r = chown(device_node, uid, gid);

+                                if (r < 0) {

+                                        log_error("failed to chown '%s' %u %u \n", device_node, uid, gid);

+                                        return -errno;

+                                } else

+                                        log_debug("chown '%s' %u %u\n", device_node, uid, gid);

                         }

                         utimensat(AT_FDCWD, device_node, NULL, 0);