richardphibel / rpms / systemd

Forked from rpms/systemd 2 years ago
Clone
84b277
From 865e6e46f235bc9c58e61024696fff216e7a2182 Mon Sep 17 00:00:00 2001
84b277
From: Lennart Poettering <lennart@poettering.net>
84b277
Date: Mon, 7 Jul 2014 17:32:44 +0200
84b277
Subject: [PATCH] service: don't accept negative ERRNO= notification messages
84b277
84b277
(cherry picked from commit 2040ccf171404b709acb0ecf1d1f17b87c5d05f0)
84b277
84b277
Related: #1106457
84b277
---
84b277
 src/core/service.c | 2 +-
84b277
 1 file changed, 1 insertion(+), 1 deletion(-)
84b277
84b277
diff --git a/src/core/service.c b/src/core/service.c
84b277
index 3f6c8ac..814019d 100644
84b277
--- a/src/core/service.c
84b277
+++ b/src/core/service.c
84b277
@@ -3534,7 +3534,7 @@ static void service_notify_message(Unit *u, pid_t pid, char **tags) {
84b277
         if (e) {
84b277
                 int status_errno;
84b277
 
84b277
-                if (safe_atoi(e + 6, &status_errno) < 0)
84b277
+                if (safe_atoi(e + 6, &status_errno) < 0 || status_errno < 0)
84b277
                         log_warning_unit(u->id, "Failed to parse ERRNO= field in notification message: %s", e);
84b277
                 else {
84b277
                         log_debug_unit(u->id, "%s: got %s", u->id, e);